Re: [PATCH v2 4/4] drm/i915/selftests: Verify whitelist of context registers

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2614 bytes --]

Hi Chris,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20190416]
[cannot apply to v5.1-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Verify-workarounds-immediately-after-application/20190417-035630
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x017-201915 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/i915/intel_workarounds.c:1401:0:
   drivers/gpu/drm/i915/selftests/intel_workarounds.c: In function 'neq_whitelisted_registers':
>> drivers/gpu/drm/i915/selftests/intel_workarounds.c:902:36: error: incompatible type for argument 2 of 'writeonly_reg'
          !writeonly_reg(engine->i915, engine->whitelist.list[i])) {
                                       ^~~~~~
   drivers/gpu/drm/i915/selftests/intel_workarounds.c:862:13: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'struct i915_wa'
    static bool writeonly_reg(struct drm_i915_private *i915, i915_reg_t reg)
                ^~~~~~~~~~~~~

vim +/writeonly_reg +902 drivers/gpu/drm/i915/selftests/intel_workarounds.c

   881	
   882	static int neq_whitelisted_registers(struct i915_vma *A,
   883					     struct i915_vma *B,
   884					     struct intel_engine_cs *engine)
   885	{
   886		u32 *a, *b;
   887		int i, err;
   888	
   889		a = i915_gem_object_pin_map(A->obj, I915_MAP_WB);
   890		if (IS_ERR(a))
   891			return PTR_ERR(a);
   892	
   893		b = i915_gem_object_pin_map(B->obj, I915_MAP_WB);
   894		if (IS_ERR(b)) {
   895			err = PTR_ERR(b);
   896			goto err_a;
   897		}
   898	
   899		err = 0;
   900		for (i = 0; i < engine->whitelist.count; i++) {
   901			if (a[i] == b[i] &&
 > 902			    !writeonly_reg(engine->i915, engine->whitelist.list[i])) {
   903				pr_err("[%d] Whitelist register 0x%4x:%08x was unwritable\n",
   904				       i, i915_mmio_reg_offset(engine->whitelist.list[i].reg), a[i]);
   905				err = -EINVAL;
   906			}
   907		}
   908	
   909		i915_gem_object_unpin_map(B->obj);
   910	err_a:
   911		i915_gem_object_unpin_map(A->obj);
   912		return err;
   913	}
   914	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27290 bytes --]

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx