From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [RFC 2/8] drm/i915: Move IRQ related stuff from intel_rps to the new intel_irq.
Date: Thu, 18 Apr 2019 15:48:31 -0700 [thread overview]
Message-ID: <20190418224831.GC26706@intel.com> (raw)
In-Reply-To: <155562215589.11755.4526946838683894156@skylake-alporthouse-com>
On Thu, Apr 18, 2019 at 10:15:55PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2019-04-18 21:53:41)
> > The plan is to consolidate all IRQ related stuff together
> > under the new intel_irq.
> >
> > So let's continue with RPS stuff.
>
> Nah, this is the wrong direction
you mean just this rps moving to intel_irq?
or the whole idea of intel_irq is bad in your opinion?
> as we don't have to pull this under a
> more global lock but push it under a local one.
yeap, I noticed this big lock around everything and
that we need to reduce that indeed...
> If you are touching this
> code, you could review the bug fixes first... :)
:(
Thanks a lot,
Rodrigo.
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-18 22:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 20:53 [RFC 0/8] Start some re-org around IRQ Rodrigo Vivi
2019-04-18 20:53 ` [RFC 1/8] drm/i915: Introduce intel_irq Rodrigo Vivi
2019-04-18 20:53 ` [RFC 2/8] drm/i915: Move IRQ related stuff from intel_rps to the new intel_irq Rodrigo Vivi
2019-04-18 21:15 ` Chris Wilson
2019-04-18 22:48 ` Rodrigo Vivi [this message]
2019-04-18 20:53 ` [RFC 3/8] drm/i915: Move display_irqs_enabled to intel_irq Rodrigo Vivi
2019-04-18 20:53 ` [RFC 4/8] drm/i915: Consolidated iir, imr and ier Rodrigo Vivi
2019-04-18 20:53 ` [RFC 5/8] drm/i915: Move all irq related masks to intel_irq Rodrigo Vivi
2019-04-18 20:53 ` [RFC 6/8] drm/i915: Prefer passing intel_irq instead of intel_core Rodrigo Vivi
2019-04-18 20:53 ` [RFC 7/8] drm/i915: Start the conversion from passing intel_irq instead of dev_priv/i915 Rodrigo Vivi
2019-04-18 20:53 ` [RFC 8/8] drm/i915: Migrate more gen11 irq functions towards intel_irq and uncore funcs Rodrigo Vivi
2019-04-18 21:31 ` ✗ Fi.CI.SPARSE: warning for Start some re-org around IRQ Patchwork
2019-04-18 21:50 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-19 0:25 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418224831.GC26706@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox