* [CI] drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt @ 2019-04-19 20:12 Chris Wilson 2019-04-19 20:54 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-04-20 0:37 ` ✓ Fi.CI.IGT: " Patchwork 0 siblings, 2 replies; 3+ messages in thread From: Chris Wilson @ 2019-04-19 20:12 UTC (permalink / raw) To: intel-gfx If we know that the user cannot access the GGTT, by virtue of having a segregated memory area, we can skip clearing the unused entries as they cannot be accessed. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Cc: Matthew Auld <matthew.william.auld@gmail.com> Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 8f460cc4cc1f..10558bc8bf90 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -3280,7 +3280,9 @@ static int gen6_gmch_probe(struct i915_ggtt *ggtt) size = gen6_get_total_gtt_size(snb_gmch_ctl); ggtt->vm.total = (size / sizeof(gen6_pte_t)) * I915_GTT_PAGE_SIZE; - ggtt->vm.clear_range = gen6_ggtt_clear_range; + ggtt->vm.clear_range = nop_clear_range; + if (!HAS_FULL_PPGTT(dev_priv) || intel_scanout_needs_vtd_wa(dev_priv)) + ggtt->vm.clear_range = gen6_ggtt_clear_range; ggtt->vm.insert_page = gen6_ggtt_insert_page; ggtt->vm.insert_entries = gen6_ggtt_insert_entries; ggtt->vm.cleanup = gen6_gmch_remove; -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt 2019-04-19 20:12 [CI] drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt Chris Wilson @ 2019-04-19 20:54 ` Patchwork 2019-04-20 0:37 ` ✓ Fi.CI.IGT: " Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2019-04-19 20:54 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt URL : https://patchwork.freedesktop.org/series/59773/ State : success == Summary == CI Bug Log - changes from CI_DRM_5960 -> Patchwork_12848 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/59773/revisions/1/mbox/ Known issues ------------ Here are the changes found in Patchwork_12848 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@semaphore: - fi-icl-y: NOTRUN -> SKIP [fdo#109315] +17 * igt@gem_exec_basic@gtt-bsd: - fi-bwr-2160: NOTRUN -> SKIP [fdo#109271] +98 * igt@gem_exec_basic@gtt-bsd1: - fi-bxt-j4205: NOTRUN -> SKIP [fdo#109271] +47 * igt@gem_exec_basic@readonly-bsd1: - fi-icl-y: NOTRUN -> SKIP [fdo#109276] +7 * igt@gem_exec_parse@basic-rejected: - fi-icl-y: NOTRUN -> SKIP [fdo#109289] +1 * igt@i915_module_load@reload: - fi-blb-e6850: NOTRUN -> INCOMPLETE [fdo#107718] * igt@kms_busy@basic-flip-c: - fi-bwr-2160: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] - fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_chamelium@dp-crc-fast: - fi-icl-y: NOTRUN -> SKIP [fdo#109284] +8 * igt@kms_chamelium@hdmi-edid-read: - fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +24 * igt@kms_force_connector_basic@force-edid: - fi-icl-y: NOTRUN -> SKIP [fdo#109285] +3 * igt@kms_psr@primary_mmap_gtt: - fi-icl-y: NOTRUN -> SKIP [fdo#110189] +3 * igt@kms_psr@primary_page_flip: - fi-skl-lmem: NOTRUN -> SKIP [fdo#109271] +37 * igt@prime_vgem@basic-fence-flip: - fi-icl-y: NOTRUN -> SKIP [fdo#109294] #### Possible fixes #### * igt@gem_exec_suspend@basic-s4-devices: - fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS * igt@i915_selftest@live_contexts: - fi-bdw-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235 Participating hosts (35 -> 32) ------------------------------ Additional (4): fi-icl-y fi-skl-lmem fi-bxt-j4205 fi-bwr-2160 Missing (7): fi-ilk-m540 fi-icl-u2 fi-snb-2520m fi-ctg-p8600 fi-hsw-4770 fi-cfl-8109u fi-bdw-samus Build changes ------------- * Linux: CI_DRM_5960 -> Patchwork_12848 CI_DRM_5960: fa2ef64bd2b4890021eda01248a2de4290248522 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12848: 45a2b940a818d709b784ba3c9d065603efa557d2 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 45a2b940a818 drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12848/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt 2019-04-19 20:12 [CI] drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt Chris Wilson 2019-04-19 20:54 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-04-20 0:37 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2019-04-20 0:37 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt URL : https://patchwork.freedesktop.org/series/59773/ State : success == Summary == CI Bug Log - changes from CI_DRM_5960_full -> Patchwork_12848_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_12848_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_switch@basic-default: - shard-iclb: NOTRUN -> INCOMPLETE [fdo#107713] / [fdo#108569] * igt@gem_exec_params@rsvd2-dirt: - shard-iclb: NOTRUN -> SKIP [fdo#109283] * igt@gem_exec_schedule@preempt-queue-bsd1: - shard-iclb: NOTRUN -> SKIP [fdo#109276] +9 * igt@gem_pwrite@huge-cpu-fbr: - shard-iclb: NOTRUN -> SKIP [fdo#109290] +1 * igt@gem_stolen@stolen-fill-purge: - shard-iclb: NOTRUN -> SKIP [fdo#109277] * igt@gem_tiled_swapping@non-threaded: - shard-iclb: PASS -> FAIL [fdo#108686] * igt@gem_userptr_blits@readonly-pwrite-unsync: - shard-iclb: NOTRUN -> SKIP [fdo#110426] * igt@i915_query@query-topology-known-pci-ids: - shard-iclb: NOTRUN -> SKIP [fdo#109303] * igt@kms_atomic_transition@5x-modeset-transitions: - shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6 * igt@kms_atomic_transition@6x-modeset-transitions: - shard-iclb: NOTRUN -> SKIP [fdo#109278] +6 * igt@kms_chamelium@dp-hpd-storm-disable: - shard-glk: NOTRUN -> SKIP [fdo#109271] +93 * igt@kms_chamelium@hdmi-cmp-nv12: - shard-iclb: NOTRUN -> SKIP [fdo#109284] +2 * igt@kms_color@pipe-a-gamma: - shard-iclb: NOTRUN -> FAIL [fdo#104782] * igt@kms_cursor_crc@cursor-256x256-sliding: - shard-glk: NOTRUN -> FAIL [fdo#103232] +2 * igt@kms_cursor_crc@cursor-512x512-dpms: - shard-iclb: NOTRUN -> SKIP [fdo#109279] +1 * igt@kms_cursor_edge_walk@pipe-b-256x256-left-edge: - shard-snb: PASS -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy: - shard-iclb: NOTRUN -> SKIP [fdo#109274] +6 * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: PASS -> FAIL [fdo#105363] +1 * igt@kms_flip@flip-vs-suspend: - shard-apl: PASS -> DMESG-WARN [fdo#108566] +1 * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack: - shard-skl: NOTRUN -> FAIL [fdo#103167] +1 * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-cpu: - shard-snb: PASS -> SKIP [fdo#109271] * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite: - shard-iclb: PASS -> FAIL [fdo#103167] +2 * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render: - shard-snb: NOTRUN -> SKIP [fdo#109271] +37 * igt@kms_frontbuffer_tracking@fbcpsr-1p-rte: - shard-iclb: PASS -> FAIL [fdo#103167] / [fdo#110378] * igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt: - shard-iclb: NOTRUN -> SKIP [fdo#109280] +18 * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-move: - shard-skl: NOTRUN -> SKIP [fdo#109271] +78 * igt@kms_panel_fitting@legacy: - shard-kbl: NOTRUN -> SKIP [fdo#109271] +21 * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-e: - shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5 * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2 * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping: - shard-glk: PASS -> SKIP [fdo#109271] * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-skl: NOTRUN -> FAIL [fdo#108145] +7 * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max: - shard-glk: NOTRUN -> FAIL [fdo#108145] * igt@kms_psr@psr2_dpms: - shard-iclb: NOTRUN -> SKIP [fdo#109441] * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: PASS -> SKIP [fdo#109441] +1 * igt@kms_setmode@basic: - shard-skl: PASS -> FAIL [fdo#99912] - shard-iclb: NOTRUN -> FAIL [fdo#99912] * igt@kms_sysfs_edid_timing: - shard-iclb: NOTRUN -> FAIL [fdo#100047] * igt@kms_vblank@pipe-c-wait-idle-hang: - shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +4 * igt@kms_vrr@flip-dpms: - shard-iclb: NOTRUN -> SKIP [fdo#109502] * igt@perf@per-context-mode-unprivileged: - shard-iclb: NOTRUN -> SKIP [fdo#109289] +1 * igt@prime_nv_api@nv_self_import: - shard-iclb: NOTRUN -> SKIP [fdo#109291] +2 #### Possible fixes #### * igt@gem_eio@in-flight-suspend: - shard-glk: FAIL [fdo#105957] -> PASS * igt@gem_eio@unwedge-stress: - shard-snb: FAIL [fdo#109661] -> PASS * igt@gem_workarounds@suspend-resume: - shard-apl: DMESG-WARN [fdo#108566] -> PASS +3 * igt@i915_pm_rpm@legacy-planes-dpms: - shard-skl: INCOMPLETE [fdo#107807] -> PASS * igt@i915_pm_rpm@universal-planes-dpms: - shard-iclb: INCOMPLETE [fdo#107713] / [fdo#108840] -> PASS * igt@kms_atomic_interruptible@legacy-dpms: - shard-iclb: INCOMPLETE [fdo#107713] -> PASS * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render: - shard-iclb: FAIL [fdo#103167] -> PASS +3 * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping: - shard-glk: SKIP [fdo#109271] -> PASS +1 * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: FAIL [fdo#108145] / [fdo#110403] -> PASS * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping: - shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS +1 * igt@kms_psr@no_drrs: - shard-iclb: FAIL [fdo#108341] -> PASS * igt@kms_psr@psr2_primary_mmap_gtt: - shard-iclb: SKIP [fdo#109441] -> PASS +1 [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105957]: https://bugs.freedesktop.org/show_bug.cgi?id=105957 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686 [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109502]: https://bugs.freedesktop.org/show_bug.cgi?id=109502 [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661 [fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110426]: https://bugs.freedesktop.org/show_bug.cgi?id=110426 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (10 -> 9) ------------------------------ Missing (1): shard-hsw Build changes ------------- * Linux: CI_DRM_5960 -> Patchwork_12848 CI_DRM_5960: fa2ef64bd2b4890021eda01248a2de4290248522 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12848: 45a2b940a818d709b784ba3c9d065603efa557d2 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12848/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-20 0:37 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-04-19 20:12 [CI] drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt Chris Wilson 2019-04-19 20:54 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-04-20 0:37 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox