* [PATCH v3] drm: Fire off KMS hotplug events if probe detect says the connector is connected
@ 2019-04-20 14:57 Gwan-gyeong Mun
2019-04-20 14:54 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev3) Patchwork
2019-04-20 15:15 ` ✗ Fi.CI.BAT: failure " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Gwan-gyeong Mun @ 2019-04-20 14:57 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, daniel.vetter, dri-devel, Gwan-gyeong Mun
The hotplug detection routine of drm_helper_hpd_irq_event() can detect
changing of status of connector, but it can not detect changing of
properties of the connector.
e.g. changing of edid while suspend/resume, changing of dp lanes in dp aux.
Following scenario explains one of them; A detection of changing of edid.
1) plug display device to a connector
2) system suspend
3) unplug 1)'s display device and plug the other display device to a
connector
4) system resume
To solve explained cases, It fires off KMS hotplug events if
drm_helper_probe_detect() says the connector is connected.
Testcase: igt/kms_chamelium/hdmi-edid-change-during-hibernate
Testcase: igt/kms_chamelium/hdmi-edid-change-during-suspend
Testcase: igt/kms_chamelium/dp-edid-change-during-hibernate
Testcase: igt/kms_chamelium/dp-edid-change-during-suspend
v2: Remove suggested-by line (danvet)
v3: Remove a misused Link line and add References (Jani)
References: https://bugs.freedesktop.org/show_bug.cgi?id=105540
References: https://lists.freedesktop.org/archives/dri-devel/2019-April/214572.html
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
---
drivers/gpu/drm/drm_probe_helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
index 6fd08e04b323..081a849104f2 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/drivers/gpu/drm/drm_probe_helper.c
@@ -780,7 +780,8 @@ bool drm_helper_hpd_irq_event(struct drm_device *dev)
connector->name,
drm_get_connector_status_name(old_status),
drm_get_connector_status_name(connector->status));
- if (old_status != connector->status)
+ if (old_status != connector->status ||
+ connector->status == connector_status_connected)
changed = true;
}
drm_connector_list_iter_end(&conn_iter);
--
2.21.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev3) 2019-04-20 14:57 [PATCH v3] drm: Fire off KMS hotplug events if probe detect says the connector is connected Gwan-gyeong Mun @ 2019-04-20 14:54 ` Patchwork 2019-04-20 15:15 ` ✗ Fi.CI.BAT: failure " Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2019-04-20 14:54 UTC (permalink / raw) To: Gwan-gyeong Mun; +Cc: intel-gfx == Series Details == Series: drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev3) URL : https://patchwork.freedesktop.org/series/59691/ State : warning == Summary == $ dim checkpatch origin/drm-tip 56fec13ce383 drm: Fire off KMS hotplug events if probe detect says the connector is connected -:32: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #32: References: https://lists.freedesktop.org/archives/dri-devel/2019-April/214572.html -:48: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Gwan-gyeong Mun <elongbug@gmail.com>' total: 0 errors, 2 warnings, 0 checks, 9 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: failure for drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev3) 2019-04-20 14:57 [PATCH v3] drm: Fire off KMS hotplug events if probe detect says the connector is connected Gwan-gyeong Mun 2019-04-20 14:54 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev3) Patchwork @ 2019-04-20 15:15 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2019-04-20 15:15 UTC (permalink / raw) To: Gwan-gyeong Mun; +Cc: intel-gfx == Series Details == Series: drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev3) URL : https://patchwork.freedesktop.org/series/59691/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5964 -> Patchwork_12852 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_12852 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_12852, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/59691/revisions/3/mbox/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_12852: ### IGT changes ### #### Possible regressions #### * igt@i915_module_load@reload-with-fault-injection: - fi-byt-n2820: PASS -> DMESG-WARN * igt@kms_chamelium@common-hpd-after-suspend: - fi-icl-u2: NOTRUN -> FAIL * igt@runner@aborted: - fi-byt-n2820: NOTRUN -> FAIL Known issues ------------ Here are the changes found in Patchwork_12852 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_cs_nop@fork-compute0: - fi-icl-y: NOTRUN -> SKIP [fdo#109315] +17 * igt@amdgpu/amd_cs_nop@fork-gfx0: - fi-icl-u2: NOTRUN -> SKIP [fdo#109315] +17 * igt@gem_exec_basic@basic-bsd2: - fi-icl-y: NOTRUN -> SKIP [fdo#109276] +7 * igt@gem_exec_basic@readonly-bsd1: - fi-icl-u2: NOTRUN -> SKIP [fdo#109276] +7 * igt@gem_exec_parse@basic-allowed: - fi-icl-u2: NOTRUN -> SKIP [fdo#109289] +1 * igt@gem_exec_parse@basic-rejected: - fi-icl-y: NOTRUN -> SKIP [fdo#109289] +1 * igt@i915_module_load@reload-with-fault-injection: - fi-bsw-n3050: PASS -> DMESG-WARN [fdo#107732] * igt@i915_selftest@live_contexts: - fi-bdw-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ] - fi-skl-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ] * igt@kms_chamelium@dp-crc-fast: - fi-icl-y: NOTRUN -> SKIP [fdo#109284] +8 * igt@kms_chamelium@dp-edid-read: - fi-icl-u2: NOTRUN -> SKIP [fdo#109316] +2 * igt@kms_chamelium@vga-hpd-fast: - fi-icl-u2: NOTRUN -> SKIP [fdo#109309] +1 * igt@kms_force_connector_basic@force-load-detect: - fi-icl-y: NOTRUN -> SKIP [fdo#109285] +3 * igt@kms_force_connector_basic@prune-stale-modes: - fi-icl-u2: NOTRUN -> SKIP [fdo#109285] +3 * igt@kms_frontbuffer_tracking@basic: - fi-byt-clapper: PASS -> FAIL [fdo#103167] * igt@kms_pipe_crc_basic@read-crc-pipe-b: - fi-byt-clapper: PASS -> FAIL [fdo#103191] +1 * igt@kms_psr@primary_mmap_gtt: - fi-icl-y: NOTRUN -> SKIP [fdo#110189] +3 * igt@prime_vgem@basic-fence-flip: - fi-icl-y: NOTRUN -> SKIP [fdo#109294] * igt@runner@aborted: - fi-bsw-n3050: NOTRUN -> FAIL [fdo#110446] #### Possible fixes #### * igt@i915_selftest@live_hangcheck: - fi-skl-iommu: INCOMPLETE [fdo#108602] / [fdo#108744] -> PASS * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: - fi-byt-clapper: FAIL [fdo#103191] -> PASS [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732 [fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602 [fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294 [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109316]: https://bugs.freedesktop.org/show_bug.cgi?id=109316 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235 [fdo#110446]: https://bugs.freedesktop.org/show_bug.cgi?id=110446 Participating hosts (45 -> 41) ------------------------------ Additional (2): fi-icl-y fi-icl-u2 Missing (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ilk-650 fi-ctg-p8600 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_5964 -> Patchwork_12852 CI_DRM_5964: 9b6a59cae93143b34f19ed05c84b6a0eb668c52c @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12852: 56fec13ce38388d675e7c24eb9fb45bb01700218 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 56fec13ce383 drm: Fire off KMS hotplug events if probe detect says the connector is connected == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12852/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-20 15:15 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-04-20 14:57 [PATCH v3] drm: Fire off KMS hotplug events if probe detect says the connector is connected Gwan-gyeong Mun 2019-04-20 14:54 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev3) Patchwork 2019-04-20 15:15 ` ✗ Fi.CI.BAT: failure " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox