* [PATCH 1/2] RFC: hung_task: taint kernel
@ 2019-05-02 19:42 Daniel Vetter
2019-05-02 19:42 ` [PATCH 2/2] RFC: soft/hardlookup: " Daniel Vetter
` (6 more replies)
0 siblings, 7 replies; 13+ messages in thread
From: Daniel Vetter @ 2019-05-02 19:42 UTC (permalink / raw)
To: Intel Graphics Development
Cc: LKML, Daniel Vetter, Daniel Vetter, Andrew Morton, Tetsuo Handa,
Dmitry Vyukov, Paul E. McKenney, Valdis Kletnieks,
Vitaly Kuznetsov, Liu, Chuansheng
There's the hung_task_panic sysctl, but that's a bit an extreme measure.
As a fallback taint at least the machine.
Our CI uses this to decide when a reboot is necessary, plus to figure
out whether the kernel is still happy.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: "Liu, Chuansheng" <chuansheng.liu@intel.com>
---
kernel/hung_task.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index f108a95882c6..7fae16f1b49c 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -203,6 +203,8 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout)
if (hung_task_call_panic) {
trigger_all_cpu_backtrace();
panic("hung_task: blocked tasks");
+ } else {
+ add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/2] RFC: soft/hardlookup: taint kernel
2019-05-02 19:42 [PATCH 1/2] RFC: hung_task: taint kernel Daniel Vetter
@ 2019-05-02 19:42 ` Daniel Vetter
2019-05-03 0:00 ` Laurence Oberman
2019-05-09 9:24 ` Sergey Senozhatsky
2019-05-02 20:01 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] RFC: hung_task: " Patchwork
` (5 subsequent siblings)
6 siblings, 2 replies; 13+ messages in thread
From: Daniel Vetter @ 2019-05-02 19:42 UTC (permalink / raw)
To: Intel Graphics Development
Cc: LKML, Daniel Vetter, Daniel Vetter, Thomas Gleixner, Ingo Molnar,
Peter Zijlstra, Valdis Kletnieks, Laurence Oberman,
Vincent Whitchurch, Don Zickus, Andrew Morton, Sergey Senozhatsky,
Sinan Kaya
There's the soft/hardlookup_panic sysctls, but that's a bit an extreme
measure. As a fallback taint at least the machine.
Our CI uses this to decide when a reboot is necessary, plus to figure
out whether the kernel is still happy.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Cc: Laurence Oberman <loberman@redhat.com>
Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Sinan Kaya <okaya@kernel.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
kernel/watchdog.c | 2 ++
kernel/watchdog_hld.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 6a5787233113..de7a60503517 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -469,6 +469,8 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
add_taint(TAINT_SOFTLOCKUP, LOCKDEP_STILL_OK);
if (softlockup_panic)
panic("softlockup: hung tasks");
+ else
+ add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
__this_cpu_write(soft_watchdog_warn, true);
} else
__this_cpu_write(soft_watchdog_warn, false);
diff --git a/kernel/watchdog_hld.c b/kernel/watchdog_hld.c
index 247bf0b1582c..cce46cf75d76 100644
--- a/kernel/watchdog_hld.c
+++ b/kernel/watchdog_hld.c
@@ -154,6 +154,8 @@ static void watchdog_overflow_callback(struct perf_event *event,
if (hardlockup_panic)
nmi_panic(regs, "Hard LOCKUP");
+ else
+ add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
__this_cpu_write(hard_watchdog_warn, true);
return;
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] RFC: hung_task: taint kernel
2019-05-02 19:42 [PATCH 1/2] RFC: hung_task: taint kernel Daniel Vetter
2019-05-02 19:42 ` [PATCH 2/2] RFC: soft/hardlookup: " Daniel Vetter
@ 2019-05-02 20:01 ` Patchwork
2019-05-02 20:21 ` ✗ Fi.CI.BAT: failure " Patchwork
` (4 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2019-05-02 20:01 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] RFC: hung_task: taint kernel
URL : https://patchwork.freedesktop.org/series/60228/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
71eca6313419 RFC: hung_task: taint kernel
-:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
3adccbe564af RFC: soft/hardlookup: taint kernel
-:50: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [1/2] RFC: hung_task: taint kernel
2019-05-02 19:42 [PATCH 1/2] RFC: hung_task: taint kernel Daniel Vetter
2019-05-02 19:42 ` [PATCH 2/2] RFC: soft/hardlookup: " Daniel Vetter
2019-05-02 20:01 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] RFC: hung_task: " Patchwork
@ 2019-05-02 20:21 ` Patchwork
2019-05-02 20:46 ` [PATCH] " Daniel Vetter
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2019-05-02 20:21 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] RFC: hung_task: taint kernel
URL : https://patchwork.freedesktop.org/series/60228/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6029 -> Patchwork_12950
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_12950 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_12950, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60228/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12950:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- fi-ilk-650: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-ilk-650/igt@runner@aborted.html
- fi-pnv-d510: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-pnv-d510/igt@runner@aborted.html
- fi-bdw-gvtdvm: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-bdw-gvtdvm/igt@runner@aborted.html
- fi-cfl-8109u: NOTRUN -> [FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-cfl-8109u/igt@runner@aborted.html
- fi-hsw-peppy: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-hsw-peppy/igt@runner@aborted.html
- fi-gdg-551: NOTRUN -> [FAIL][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-gdg-551/igt@runner@aborted.html
- fi-snb-2520m: NOTRUN -> [FAIL][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-snb-2520m/igt@runner@aborted.html
- fi-hsw-4770: NOTRUN -> [FAIL][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-hsw-4770/igt@runner@aborted.html
- fi-kbl-7500u: NOTRUN -> [FAIL][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-kbl-7500u/igt@runner@aborted.html
- fi-bxt-j4205: NOTRUN -> [FAIL][10]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-bxt-j4205/igt@runner@aborted.html
- fi-whl-u: NOTRUN -> [FAIL][11]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-whl-u/igt@runner@aborted.html
- fi-icl-u3: NOTRUN -> [FAIL][12]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-icl-u3/igt@runner@aborted.html
- fi-ivb-3770: NOTRUN -> [FAIL][13]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-ivb-3770/igt@runner@aborted.html
- fi-byt-j1900: NOTRUN -> [FAIL][14]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-byt-j1900/igt@runner@aborted.html
- fi-cfl-guc: NOTRUN -> [FAIL][15]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-cfl-guc/igt@runner@aborted.html
- fi-kbl-7567u: NOTRUN -> [FAIL][16]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-kbl-7567u/igt@runner@aborted.html
- fi-blb-e6850: NOTRUN -> [FAIL][17]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-blb-e6850/igt@runner@aborted.html
- fi-kbl-x1275: NOTRUN -> [FAIL][18]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-kbl-x1275/igt@runner@aborted.html
- fi-cfl-8700k: NOTRUN -> [FAIL][19]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-cfl-8700k/igt@runner@aborted.html
- fi-hsw-4770r: NOTRUN -> [FAIL][20]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-hsw-4770r/igt@runner@aborted.html
- fi-kbl-8809g: NOTRUN -> [FAIL][21]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-kbl-8809g/igt@runner@aborted.html
- fi-apl-guc: NOTRUN -> [FAIL][22]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-apl-guc/igt@runner@aborted.html
- fi-bdw-5557u: NOTRUN -> [FAIL][23]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-bdw-5557u/igt@runner@aborted.html
- fi-bwr-2160: NOTRUN -> [FAIL][24]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-bwr-2160/igt@runner@aborted.html
- fi-byt-n2820: NOTRUN -> [FAIL][25]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-byt-n2820/igt@runner@aborted.html
- fi-elk-e7500: NOTRUN -> [FAIL][26]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-elk-e7500/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@runner@aborted:
- {fi-cml-u2}: NOTRUN -> [FAIL][27]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-cml-u2/igt@runner@aborted.html
- {fi-cml-u}: NOTRUN -> [FAIL][28]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/fi-cml-u/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
Participating hosts (54 -> 41)
------------------------------
Missing (13): fi-kbl-soraka fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-kbl-guc fi-ctg-p8600 fi-icl-y fi-bdw-samus fi-byt-clapper fi-skl-6600u
Build changes
-------------
* Linux: CI_DRM_6029 -> Patchwork_12950
CI_DRM_6029: 0548213ff6d52d4638778a95a4b3a7900e683ac3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12950: 3adccbe564afab6576f19e48281a11c916900548 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3adccbe564af RFC: soft/hardlookup: taint kernel
71eca6313419 RFC: hung_task: taint kernel
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12950/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] RFC: hung_task: taint kernel
2019-05-02 19:42 [PATCH 1/2] RFC: hung_task: taint kernel Daniel Vetter
` (2 preceding siblings ...)
2019-05-02 20:21 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2019-05-02 20:46 ` Daniel Vetter
2019-05-03 0:47 ` Tetsuo Handa
2019-05-02 23:04 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with RFC: hung_task: taint kernel (rev2) Patchwork
` (2 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Daniel Vetter @ 2019-05-02 20:46 UTC (permalink / raw)
To: Intel Graphics Development
Cc: LKML, Daniel Vetter, Daniel Vetter, Andrew Morton, Tetsuo Handa,
Dmitry Vyukov, Paul E. McKenney, Valdis Kletnieks,
Vitaly Kuznetsov, Liu, Chuansheng
There's the hung_task_panic sysctl, but that's a bit an extreme measure.
As a fallback taint at least the machine.
Our CI uses this to decide when a reboot is necessary, plus to figure
out whether the kernel is still happy.
v2: Works much better when I put the else { add_taint() } at the right
place.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: "Liu, Chuansheng" <chuansheng.liu@intel.com>
---
kernel/hung_task.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index f108a95882c6..d90d98f53ccb 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -117,6 +117,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
console_verbose();
hung_task_show_lock = true;
hung_task_call_panic = true;
+ } else {
+ add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
}
/*
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with RFC: hung_task: taint kernel (rev2)
2019-05-02 19:42 [PATCH 1/2] RFC: hung_task: taint kernel Daniel Vetter
` (3 preceding siblings ...)
2019-05-02 20:46 ` [PATCH] " Daniel Vetter
@ 2019-05-02 23:04 ` Patchwork
2019-05-02 23:34 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-03 6:06 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2019-05-02 23:04 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: series starting with RFC: hung_task: taint kernel (rev2)
URL : https://patchwork.freedesktop.org/series/60228/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
fb98bc124cb7 RFC: hung_task: taint kernel
-:37: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
1b7921825c1b RFC: soft/hardlookup: taint kernel
-:50: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with RFC: hung_task: taint kernel (rev2)
2019-05-02 19:42 [PATCH 1/2] RFC: hung_task: taint kernel Daniel Vetter
` (4 preceding siblings ...)
2019-05-02 23:04 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with RFC: hung_task: taint kernel (rev2) Patchwork
@ 2019-05-02 23:34 ` Patchwork
2019-05-03 6:06 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2019-05-02 23:34 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: series starting with RFC: hung_task: taint kernel (rev2)
URL : https://patchwork.freedesktop.org/series/60228/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6031 -> Patchwork_12953
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60228/revisions/2/mbox/
Known issues
------------
Here are the changes found in Patchwork_12953 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][1] ([fdo#108511]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: [DMESG-FAIL][3] ([fdo#110235]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (48 -> 42)
------------------------------
Additional (2): fi-blb-e6850 fi-icl-u3
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-whl-u fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6031 -> Patchwork_12953
CI_DRM_6031: 6f67b24f2fc7b90a94e4163ae4cd01bc2783fbfd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12953: 1b7921825c1b6d3e728f8551e6108d7efbb0dbd6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1b7921825c1b RFC: soft/hardlookup: taint kernel
fb98bc124cb7 RFC: hung_task: taint kernel
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] RFC: soft/hardlookup: taint kernel
2019-05-02 19:42 ` [PATCH 2/2] RFC: soft/hardlookup: " Daniel Vetter
@ 2019-05-03 0:00 ` Laurence Oberman
2019-05-09 9:24 ` Sergey Senozhatsky
1 sibling, 0 replies; 13+ messages in thread
From: Laurence Oberman @ 2019-05-03 0:00 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics Development
Cc: LKML, Daniel Vetter, Thomas Gleixner, Ingo Molnar, Peter Zijlstra,
Valdis Kletnieks, Vincent Whitchurch, Don Zickus, Andrew Morton,
Sergey Senozhatsky, Sinan Kaya
On Thu, 2019-05-02 at 21:42 +0200, Daniel Vetter wrote:
> There's the soft/hardlookup_panic sysctls, but that's a bit an
> extreme
> measure. As a fallback taint at least the machine.
>
> Our CI uses this to decide when a reboot is necessary, plus to figure
> out whether the kernel is still happy.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> Cc: Laurence Oberman <loberman@redhat.com>
> Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
> Cc: Don Zickus <dzickus@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
> Cc: Sinan Kaya <okaya@kernel.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> kernel/watchdog.c | 2 ++
> kernel/watchdog_hld.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 6a5787233113..de7a60503517 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -469,6 +469,8 @@ static enum hrtimer_restart
> watchdog_timer_fn(struct hrtimer *hrtimer)
> add_taint(TAINT_SOFTLOCKUP, LOCKDEP_STILL_OK);
> if (softlockup_panic)
> panic("softlockup: hung tasks");
> + else
> + add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
> __this_cpu_write(soft_watchdog_warn, true);
> } else
> __this_cpu_write(soft_watchdog_warn, false);
> diff --git a/kernel/watchdog_hld.c b/kernel/watchdog_hld.c
> index 247bf0b1582c..cce46cf75d76 100644
> --- a/kernel/watchdog_hld.c
> +++ b/kernel/watchdog_hld.c
> @@ -154,6 +154,8 @@ static void watchdog_overflow_callback(struct
> perf_event *event,
>
> if (hardlockup_panic)
> nmi_panic(regs, "Hard LOCKUP");
> + else
> + add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
>
> __this_cpu_write(hard_watchdog_warn, true);
> return;
This looks OK to me, could be useful to know we would have triggered
had the flags been set.
Reviewed-by: Laurence Oberman <loberman@redhat.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] RFC: hung_task: taint kernel
2019-05-02 20:46 ` [PATCH] " Daniel Vetter
@ 2019-05-03 0:47 ` Tetsuo Handa
2019-05-03 8:51 ` Daniel Vetter
0 siblings, 1 reply; 13+ messages in thread
From: Tetsuo Handa @ 2019-05-03 0:47 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics Development
Cc: LKML, Daniel Vetter, Andrew Morton, Dmitry Vyukov,
Paul E. McKenney, Valdis Kletnieks, Vitaly Kuznetsov,
Liu, Chuansheng
On 2019/05/03 5:46, Daniel Vetter wrote:
> There's the hung_task_panic sysctl, but that's a bit an extreme measure.
> As a fallback taint at least the machine.
>
> Our CI uses this to decide when a reboot is necessary, plus to figure
> out whether the kernel is still happy.
Why your CI can't watch for "blocked for more than" message instead of
setting the taint flag? How does your CI decide a reboot is necessary?
There is no need to set the tainted flag when some task was just blocked
for a while. It might be due to memory pressure, it might be due to setting
very short timeout (e.g. a few seconds), it might be due to busy CPUs doing
something else...
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with RFC: hung_task: taint kernel (rev2)
2019-05-02 19:42 [PATCH 1/2] RFC: hung_task: taint kernel Daniel Vetter
` (5 preceding siblings ...)
2019-05-02 23:34 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-05-03 6:06 ` Patchwork
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2019-05-03 6:06 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: series starting with RFC: hung_task: taint kernel (rev2)
URL : https://patchwork.freedesktop.org/series/60228/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6031_full -> Patchwork_12953_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12953_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-rte:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] ([fdo#107807] / [fdo#110581]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-skl8/igt@i915_pm_rpm@basic-rte.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-skl8/igt@i915_pm_rpm@basic-rte.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +6 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-apl1/igt@i915_suspend@fence-restore-untiled.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-apl7/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_flip@dpms-vs-vblank-race-interruptible:
- shard-kbl: [PASS][5] -> [FAIL][6] ([fdo#103060])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-kbl7/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-kbl7/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
* igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-glk: [PASS][7] -> [INCOMPLETE][8] ([fdo#103359] / [fdo#110581] / [k.org#198133])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-glk8/igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-glk8/igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-iclb: [PASS][9] -> [FAIL][10] ([fdo#103167]) +6 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
* igt@kms_plane_scaling@pipe-a-scaler-with-rotation:
- shard-glk: [PASS][11] -> [SKIP][12] ([fdo#109271] / [fdo#109278])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-rotation.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-glk1/igt@kms_plane_scaling@pipe-a-scaler-with-rotation.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html
#### Possible fixes ####
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: [DMESG-WARN][15] ([fdo#108686]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-hsw5/igt@gem_tiled_swapping@non-threaded.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-hsw5/igt@gem_tiled_swapping@non-threaded.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][17] ([fdo#108566]) -> [PASS][18] +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-apl6/igt@i915_suspend@sysfs-reader.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-apl7/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-snb: [SKIP][19] ([fdo#109271]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-snb4/igt@kms_cursor_crc@cursor-128x128-onscreen.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-snb2/igt@kms_cursor_crc@cursor-128x128-onscreen.html
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [FAIL][21] ([fdo#106509] / [fdo#107409]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-glk8/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-glk8/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-skl: [FAIL][23] ([fdo#100368]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-skl4/igt@kms_flip@plain-flip-ts-check-interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-skl3/igt@kms_flip@plain-flip-ts-check-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-tilingchange:
- shard-iclb: [FAIL][25] ([fdo#103167]) -> [PASS][26] +6 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][27] ([fdo#104108] / [fdo#106978] / [fdo#110581]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-skl9/igt@kms_frontbuffer_tracking@psr-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-skl3/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: [SKIP][29] ([fdo#109271] / [fdo#109278]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-glk7/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][31] ([fdo#109441]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-iclb7/igt@kms_psr@psr2_sprite_blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][33] ([fdo#99912]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6031/shard-apl2/igt@kms_setmode@basic.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/shard-apl5/igt@kms_setmode@basic.html
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110581]: https://bugs.freedesktop.org/show_bug.cgi?id=110581
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6031 -> Patchwork_12953
CI_DRM_6031: 6f67b24f2fc7b90a94e4163ae4cd01bc2783fbfd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12953: 1b7921825c1b6d3e728f8551e6108d7efbb0dbd6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12953/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] RFC: hung_task: taint kernel
2019-05-03 0:47 ` Tetsuo Handa
@ 2019-05-03 8:51 ` Daniel Vetter
0 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2019-05-03 8:51 UTC (permalink / raw)
To: Tetsuo Handa
Cc: Liu, Chuansheng, Valdis Kletnieks, Daniel Vetter,
Intel Graphics Development, LKML, Daniel Vetter, Andrew Morton,
Paul E. McKenney, Vitaly Kuznetsov, Dmitry Vyukov
On Fri, May 03, 2019 at 09:47:03AM +0900, Tetsuo Handa wrote:
> On 2019/05/03 5:46, Daniel Vetter wrote:
> > There's the hung_task_panic sysctl, but that's a bit an extreme measure.
> > As a fallback taint at least the machine.
> >
> > Our CI uses this to decide when a reboot is necessary, plus to figure
> > out whether the kernel is still happy.
>
> Why your CI can't watch for "blocked for more than" message instead of
> setting the taint flag? How does your CI decide a reboot is necessary?
We spam an awful lot into dmesg, and at least historically had
occasionally trouble capturing it all (we're better than that now I
think). Plus the thing that parses dmesg isn't the thing that runs
testcases, hence why we started to use taint flags (or procfs lockdep
status) and similar things to check the kernel is still alive enough.
> There is no need to set the tainted flag when some task was just blocked
> for a while. It might be due to memory pressure, it might be due to setting
> very short timeout (e.g. a few seconds), it might be due to busy CPUs doing
> something else...
Yeah I realize that this probably doesn't have much use outside of our CI,
but maybe there's someone how likes the idea.
Wrt spurious taints: You can disable the hung_tasks checker outright,
which also stops the tainting.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] RFC: soft/hardlookup: taint kernel
2019-05-02 19:42 ` [PATCH 2/2] RFC: soft/hardlookup: " Daniel Vetter
2019-05-03 0:00 ` Laurence Oberman
@ 2019-05-09 9:24 ` Sergey Senozhatsky
2019-05-09 10:16 ` Daniel Vetter
1 sibling, 1 reply; 13+ messages in thread
From: Sergey Senozhatsky @ 2019-05-09 9:24 UTC (permalink / raw)
To: Daniel Vetter
Cc: Intel Graphics Development, LKML, Daniel Vetter, Thomas Gleixner,
Ingo Molnar, Peter Zijlstra, Valdis Kletnieks, Laurence Oberman,
Vincent Whitchurch, Don Zickus, Andrew Morton, Sergey Senozhatsky,
Sinan Kaya
On (05/02/19 21:42), Daniel Vetter wrote:
[..]
> @@ -469,6 +469,8 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
> add_taint(TAINT_SOFTLOCKUP, LOCKDEP_STILL_OK);
> if (softlockup_panic)
> panic("softlockup: hung tasks");
> + else
> + add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
> __this_cpu_write(soft_watchdog_warn, true);
Soft lockup sets TAINT_SOFTLOCKUP bit. Would it be enough for your CI?
[..]
> @@ -154,6 +154,8 @@ static void watchdog_overflow_callback(struct perf_event *event,
>
> if (hardlockup_panic)
> nmi_panic(regs, "Hard LOCKUP");
> + else
> + add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
Maybe you can mirror what soft lockup does. Add a HARDLOCKUP taint bit
+++ b/include/linux/kernel.h
@@ -571,7 +571,8 @@ extern enum system_states {
#define TAINT_LIVEPATCH 15
#define TAINT_AUX 16
#define TAINT_RANDSTRUCT 17
-#define TAINT_FLAGS_COUNT 18
+#define TAINT_HARDLOCKUP 18
+#define TAINT_FLAGS_COUNT 19
and then set TAINT_HARDLOCKUP in watchdog_overflow_callback().
Just a small idea, I'll leave this to more experienced people.
-ss
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] RFC: soft/hardlookup: taint kernel
2019-05-09 9:24 ` Sergey Senozhatsky
@ 2019-05-09 10:16 ` Daniel Vetter
0 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2019-05-09 10:16 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Don Zickus, Valdis Kletnieks, Andrew Morton, Peter Zijlstra,
Intel Graphics Development, Vincent Whitchurch, Sinan Kaya, LKML,
Laurence Oberman, Daniel Vetter, Thomas Gleixner, Ingo Molnar
On Thu, May 9, 2019 at 11:24 AM Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
>
> On (05/02/19 21:42), Daniel Vetter wrote:
> [..]
> > @@ -469,6 +469,8 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
> > add_taint(TAINT_SOFTLOCKUP, LOCKDEP_STILL_OK);
> > if (softlockup_panic)
> > panic("softlockup: hung tasks");
> > + else
> > + add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
> > __this_cpu_write(soft_watchdog_warn, true);
>
> Soft lockup sets TAINT_SOFTLOCKUP bit. Would it be enough for your CI?
I'm blind :-/ Yes this is totally useful.
> [..]
> > @@ -154,6 +154,8 @@ static void watchdog_overflow_callback(struct perf_event *event,
> >
> > if (hardlockup_panic)
> > nmi_panic(regs, "Hard LOCKUP");
> > + else
> > + add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
>
> Maybe you can mirror what soft lockup does. Add a HARDLOCKUP taint bit
We'd also want a taint for hung tasks (separate patch, same idea), not
sure it's a good idea to use a new taint bit for all of them? Atm we
don't check for all taint bits (some of them are set because of things
our testcases do, like module reload or setting unsafe kernel options
meant for testing only, so picking one of the bits we check already
was least resistance.
> +++ b/include/linux/kernel.h
> @@ -571,7 +571,8 @@ extern enum system_states {
> #define TAINT_LIVEPATCH 15
> #define TAINT_AUX 16
> #define TAINT_RANDSTRUCT 17
> -#define TAINT_FLAGS_COUNT 18
> +#define TAINT_HARDLOCKUP 18
> +#define TAINT_FLAGS_COUNT 19
>
> and then set TAINT_HARDLOCKUP in watchdog_overflow_callback().
>
> Just a small idea, I'll leave this to more experienced people.
The hung_tasks taint wasn't all that positively received, I feels like
this will stay a hack private to our CI. Except if someone else pipes
up who wants this, then I'm happy to polish.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-05-09 10:16 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-02 19:42 [PATCH 1/2] RFC: hung_task: taint kernel Daniel Vetter
2019-05-02 19:42 ` [PATCH 2/2] RFC: soft/hardlookup: " Daniel Vetter
2019-05-03 0:00 ` Laurence Oberman
2019-05-09 9:24 ` Sergey Senozhatsky
2019-05-09 10:16 ` Daniel Vetter
2019-05-02 20:01 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] RFC: hung_task: " Patchwork
2019-05-02 20:21 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-05-02 20:46 ` [PATCH] " Daniel Vetter
2019-05-03 0:47 ` Tetsuo Handa
2019-05-03 8:51 ` Daniel Vetter
2019-05-02 23:04 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with RFC: hung_task: taint kernel (rev2) Patchwork
2019-05-02 23:34 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-03 6:06 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox