public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] i915/gem_busy: Fix typo killing snb!
@ 2019-05-24 13:54 Chris Wilson
  2019-05-24 14:04 ` Andi Shyti
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Wilson @ 2019-05-24 13:54 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

Check the right engine to see if it is the one that explodes!

Fixes: 88318b0771f9 ("test/i915: gem_busy: use the gem_engine_topology library")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andi Shyti <andi.shyti@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/i915/gem_busy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index f3ebb37a3..a55358708 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -256,7 +256,7 @@ static void one(int fd, const struct intel_execution_engine2 *e, unsigned test_f
 			    e2->instance == e->instance)
 				continue;
 
-			if (!gem_class_can_store_dword(fd, e->class))
+			if (!gem_class_can_store_dword(fd, e2->class))
 				continue;
 
 			igt_debug("Testing %s in parallel\n", e2->name);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH i-g-t] i915/gem_busy: Fix typo killing snb!
  2019-05-24 13:54 [PATCH i-g-t] i915/gem_busy: Fix typo killing snb! Chris Wilson
@ 2019-05-24 14:04 ` Andi Shyti
  0 siblings, 0 replies; 2+ messages in thread
From: Andi Shyti @ 2019-05-24 14:04 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, intel-gfx

> -			if (!gem_class_can_store_dword(fd, e->class))
> +			if (!gem_class_can_store_dword(fd, e2->class))
>  				continue;

ops!

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi

>  			igt_debug("Testing %s in parallel\n", e2->name);
> -- 
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-24 14:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-24 13:54 [PATCH i-g-t] i915/gem_busy: Fix typo killing snb! Chris Wilson
2019-05-24 14:04 ` Andi Shyti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox