From: Stuart Summers <stuart.summers@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [CI 1/5] drm/i915: Use local variable for SSEU info in GETPARAM ioctl
Date: Fri, 24 May 2019 08:40:18 -0700 [thread overview]
Message-ID: <20190524154022.13575-2-stuart.summers@intel.com> (raw)
In-Reply-To: <20190524154022.13575-1-stuart.summers@intel.com>
In the GETPARAM ioctl handler, use a local variable to consolidate
usage of SSEU runtime info.
v2: add const to sseu_dev_info variable
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Stuart Summers <stuart.summers@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 83d2eb9e74cb..712d48936e8a 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -329,6 +329,7 @@ static int i915_getparam_ioctl(struct drm_device *dev, void *data,
{
struct drm_i915_private *dev_priv = to_i915(dev);
struct pci_dev *pdev = dev_priv->drm.pdev;
+ const struct sseu_dev_info *sseu = &RUNTIME_INFO(dev_priv)->sseu;
drm_i915_getparam_t *param = data;
int value;
@@ -382,12 +383,12 @@ static int i915_getparam_ioctl(struct drm_device *dev, void *data,
value = i915_cmd_parser_get_version(dev_priv);
break;
case I915_PARAM_SUBSLICE_TOTAL:
- value = sseu_subslice_total(&RUNTIME_INFO(dev_priv)->sseu);
+ value = sseu_subslice_total(sseu);
if (!value)
return -ENODEV;
break;
case I915_PARAM_EU_TOTAL:
- value = RUNTIME_INFO(dev_priv)->sseu.eu_total;
+ value = sseu->eu_total;
if (!value)
return -ENODEV;
break;
@@ -404,7 +405,7 @@ static int i915_getparam_ioctl(struct drm_device *dev, void *data,
value = HAS_POOLED_EU(dev_priv);
break;
case I915_PARAM_MIN_EU_IN_POOL:
- value = RUNTIME_INFO(dev_priv)->sseu.min_eu_in_pool;
+ value = sseu->min_eu_in_pool;
break;
case I915_PARAM_HUC_STATUS:
value = intel_huc_check_status(&dev_priv->huc);
@@ -455,12 +456,12 @@ static int i915_getparam_ioctl(struct drm_device *dev, void *data,
value = intel_engines_has_context_isolation(dev_priv);
break;
case I915_PARAM_SLICE_MASK:
- value = RUNTIME_INFO(dev_priv)->sseu.slice_mask;
+ value = sseu->slice_mask;
if (!value)
return -ENODEV;
break;
case I915_PARAM_SUBSLICE_MASK:
- value = RUNTIME_INFO(dev_priv)->sseu.subslice_mask[0];
+ value = sseu->subslice_mask[0];
if (!value)
return -ENODEV;
break;
--
2.21.0.5.gaeb582a983
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-24 15:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 15:40 [CI 0/5] Refactor to expand subslice mask Stuart Summers
2019-05-24 15:40 ` Stuart Summers [this message]
2019-05-24 15:40 ` [CI 2/5] drm/i915: Add macro for SSEU stride calculation Stuart Summers
2019-05-24 15:40 ` [CI 3/5] drm/i915: Move calculation of subslices per slice to new function Stuart Summers
2019-05-24 15:40 ` [CI 4/5] drm/i915: Refactor sseu helper functions Stuart Summers
2019-05-24 15:40 ` [CI 5/5] drm/i915: Expand subslice mask Stuart Summers
2019-05-29 7:58 ` [CI,5/5] " Nathan Chancellor
2019-05-29 14:33 ` Jani Nikula
2019-05-29 15:55 ` Summers, Stuart
2019-05-29 14:58 ` [CI 5/5] " Jani Nikula
2019-05-29 15:58 ` Summers, Stuart
2019-05-26 11:46 ` ✗ Fi.CI.CHECKPATCH: warning for Refactor to expand subslice mask (rev10) Patchwork
2019-05-26 11:49 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-05-26 12:40 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-26 22:20 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-28 18:32 ` [CI 0/5] Refactor to expand subslice mask Manasi Navare
2019-05-28 18:33 ` Summers, Stuart
2019-05-29 6:48 ` Saarinen, Jani
2019-05-29 14:21 ` Daniele Ceraolo Spurio
2019-05-29 16:02 ` Summers, Stuart
2019-05-30 8:29 ` Saarinen, Jani
2019-05-30 14:46 ` Summers, Stuart
2019-05-30 14:55 ` Daniele Ceraolo Spurio
2019-05-29 14:29 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524154022.13575-2-stuart.summers@intel.com \
--to=stuart.summers@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox