[PATCH] mm: Use local variable for swap address space

[PATCH] mm: Use local variable for swap address space

[Stuart Summers]

This addresses the following build error:
mm/huge_memory.c: In function ‘__split_huge_page’:
mm/huge_memory.c:2506:41: warning: dereferencing ‘void *’ pointer
    __xa_store(&swap_address_space(entry)->i_pages,
                                         ^~
mm/huge_memory.c:2506:41: error: request for member ‘i_pages’ in
something not a structure or union

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Stuart Summers <stuart.summers@intel.com>
---
 mm/huge_memory.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index affb2c3667f9..bced5485137b 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2503,7 +2503,9 @@ static void __split_huge_page(struct page *page, struct list_head *list,
 					head + i, 0);
 		} else if (PageSwapCache(page)) {
 			swp_entry_t entry = { .val = page_private(head + i) };
-			__xa_store(&swap_address_space(entry)->i_pages,
+			struct address_space *address_space =
+				swap_address_space(entry);
+			__xa_store(&address_space->i_pages,
 				   swp_offset(entry),
 				   head + i, 0);
 		}
-- 
2.21.0.5.gaeb582a983

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for mm: Use local variable for swap address space

[Patchwork]

== Series Details ==

Series: mm: Use local variable for swap address space
URL   : https://patchwork.freedesktop.org/series/62358/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6299 -> Patchwork_13339
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_13339 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_13339, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_13339:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_sync@basic-store-each:
    - fi-skl-gvtdvm:      [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-skl-gvtdvm/igt@gem_sync@basic-store-each.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-skl-gvtdvm/igt@gem_sync@basic-store-each.html

  
Known issues
------------

  Here are the changes found in Patchwork_13339 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_basic@bad-close:
    - fi-icl-dsi:         [PASS][3] -> [INCOMPLETE][4] ([fdo#107713])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-icl-dsi/igt@gem_basic@bad-close.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-icl-dsi/igt@gem_basic@bad-close.html

  * igt@gem_ctx_switch@basic-default:
    - fi-icl-guc:         [PASS][5] -> [INCOMPLETE][6] ([fdo#107713] / [fdo#108569])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-icl-guc/igt@gem_ctx_switch@basic-default.html

  * igt@gem_exec_reloc@basic-gtt-noreloc:
    - fi-icl-u3:          [PASS][7] -> [DMESG-WARN][8] ([fdo#107724])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-icl-u3/igt@gem_exec_reloc@basic-gtt-noreloc.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-icl-u3/igt@gem_exec_reloc@basic-gtt-noreloc.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][9] -> [FAIL][10] ([fdo#109485])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@gem_sync@basic-store-each:
    - fi-kbl-7567u:       [FAIL][11] -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-kbl-7567u/igt@gem_sync@basic-store-each.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-kbl-7567u/igt@gem_sync@basic-store-each.html

  * igt@i915_module_load@reload:
    - fi-blb-e6850:       [INCOMPLETE][13] ([fdo#107718]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-blb-e6850/igt@i915_module_load@reload.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-blb-e6850/igt@i915_module_load@reload.html

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [FAIL][15] ([fdo#108511]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live_contexts:
    - fi-skl-gvtdvm:      [DMESG-FAIL][17] ([fdo#110235]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
    - fi-bdw-gvtdvm:      [DMESG-FAIL][19] ([fdo#110235]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       [DMESG-WARN][21] ([fdo#102614]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
    - fi-icl-u2:          [FAIL][23] ([fdo#103167]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6299/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235


Participating hosts (44 -> 37)
------------------------------

  Additional (1): fi-bdw-5557u 
  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6299 -> Patchwork_13339

  CI_DRM_6299: 2a6cf9f4dc05b77beab4b7d9d1c9f16c7e55a001 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13339: 9a13e1f212c4d6a14bd2876e2b05168db755b784 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

9a13e1f212c4 mm: Use local variable for swap address space

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13339/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] mm: Use local variable for swap address space

[Jani Nikula]

On Tue, 18 Jun 2019, Stuart Summers <stuart.summers@intel.com> wrote:
> This addresses the following build error:
> mm/huge_memory.c: In function ‘__split_huge_page’:
> mm/huge_memory.c:2506:41: warning: dereferencing ‘void *’ pointer
>     __xa_store(&swap_address_space(entry)->i_pages,
>                                          ^~
> mm/huge_memory.c:2506:41: error: request for member ‘i_pages’ in
> something not a structure or union

Did you check under what circumstances it would be a void pointer?

Under those circumstances, what do you think will happen runtime after
you've brushed the build error under the carpet?

Anyway, the patch is against a commit in topic/core-for-CI, not to be
merged elsewhere.

BR,
Jani.



>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> ---
>  mm/huge_memory.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index affb2c3667f9..bced5485137b 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -2503,7 +2503,9 @@ static void __split_huge_page(struct page *page, struct list_head *list,
>  					head + i, 0);
>  		} else if (PageSwapCache(page)) {
>  			swp_entry_t entry = { .val = page_private(head + i) };
> -			__xa_store(&swap_address_space(entry)->i_pages,
> +			struct address_space *address_space =
> +				swap_address_space(entry);
> +			__xa_store(&address_space->i_pages,
>  				   swp_offset(entry),
>  				   head + i, 0);
>  		}

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] mm: Use local variable for swap address space

[Summers, Stuart]

[-- Attachment #1.1: Type: text/plain, Size: 1933 bytes --]

On Wed, 2019-06-19 at 18:30 +0300, Jani Nikula wrote:
> On Tue, 18 Jun 2019, Stuart Summers <stuart.summers@intel.com> wrote:
> > This addresses the following build error:
> > mm/huge_memory.c: In function ‘__split_huge_page’:
> > mm/huge_memory.c:2506:41: warning: dereferencing ‘void *’ pointer
> >     __xa_store(&swap_address_space(entry)->i_pages,
> >                                          ^~
> > mm/huge_memory.c:2506:41: error: request for member ‘i_pages’ in
> > something not a structure or union
> 
> Did you check under what circumstances it would be a void pointer?

This got things working, but I agree probably needs at least some basic
checks here. I'll rework it.

> 
> Under those circumstances, what do you think will happen runtime
> after
> you've brushed the build error under the carpet?
> 
> Anyway, the patch is against a commit in topic/core-for-CI, not to be
> merged elsewhere.

Ok thanks for the feedback and makes sense. I'll resubmit.

Thanks,
Stuart

> 
> BR,
> Jani.
> 
> 
> 
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> > ---
> >  mm/huge_memory.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> > index affb2c3667f9..bced5485137b 100644
> > --- a/mm/huge_memory.c
> > +++ b/mm/huge_memory.c
> > @@ -2503,7 +2503,9 @@ static void __split_huge_page(struct page
> > *page, struct list_head *list,
> >  					head + i, 0);
> >  		} else if (PageSwapCache(page)) {
> >  			swp_entry_t entry = { .val = page_private(head
> > + i) };
> > -			__xa_store(&swap_address_space(entry)->i_pages,
> > +			struct address_space *address_space =
> > +				swap_address_space(entry);
> > +			__xa_store(&address_space->i_pages,
> >  				   swp_offset(entry),
> >  				   head + i, 0);
> >  		}
> 
> 

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] mm: Use local variable for swap address space

[Jani Nikula]

On Wed, 19 Jun 2019, "Summers, Stuart" <stuart.summers@intel.com> wrote:
> On Wed, 2019-06-19 at 18:30 +0300, Jani Nikula wrote:
>> On Tue, 18 Jun 2019, Stuart Summers <stuart.summers@intel.com> wrote:
>> > This addresses the following build error:
>> > mm/huge_memory.c: In function ‘__split_huge_page’:
>> > mm/huge_memory.c:2506:41: warning: dereferencing ‘void *’ pointer
>> >     __xa_store(&swap_address_space(entry)->i_pages,
>> >                                          ^~
>> > mm/huge_memory.c:2506:41: error: request for member ‘i_pages’ in
>> > something not a structure or union
>> 
>> Did you check under what circumstances it would be a void pointer?
>
> This got things working, but I agree probably needs at least some basic
> checks here. I'll rework it.

Hint: CONFIG_SWAP.

BR,
Jani.


>
>> 
>> Under those circumstances, what do you think will happen runtime
>> after
>> you've brushed the build error under the carpet?
>> 
>> Anyway, the patch is against a commit in topic/core-for-CI, not to be
>> merged elsewhere.
>
> Ok thanks for the feedback and makes sense. I'll resubmit.
>
> Thanks,
> Stuart
>
>> 
>> BR,
>> Jani.
>> 
>> 
>> 
>> > 
>> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> > Signed-off-by: Stuart Summers <stuart.summers@intel.com>
>> > ---
>> >  mm/huge_memory.c | 4 +++-
>> >  1 file changed, 3 insertions(+), 1 deletion(-)
>> > 
>> > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
>> > index affb2c3667f9..bced5485137b 100644
>> > --- a/mm/huge_memory.c
>> > +++ b/mm/huge_memory.c
>> > @@ -2503,7 +2503,9 @@ static void __split_huge_page(struct page
>> > *page, struct list_head *list,
>> >  					head + i, 0);
>> >  		} else if (PageSwapCache(page)) {
>> >  			swp_entry_t entry = { .val = page_private(head
>> > + i) };
>> > -			__xa_store(&swap_address_space(entry)->i_pages,
>> > +			struct address_space *address_space =
>> > +				swap_address_space(entry);
>> > +			__xa_store(&address_space->i_pages,
>> >  				   swp_offset(entry),
>> >  				   head + i, 0);
>> >  		}
>> 
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx