* [PATCH v2 1/2] drm/i915: Use port clock to set correct N value
@ 2019-06-27 22:07 Aditya Swarup
2019-06-27 22:07 ` [PATCH v2 2/2] drm/i915: Add N & CTS values for 10/12 bit deep color Aditya Swarup
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Aditya Swarup @ 2019-06-27 22:07 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
Use port_clock to check the clock values in n/cts lookup table instead
of crtc_clock. As port_clock is already adjusted based on color mode set
(8 bit or deep color), this will help in checking clock values for deep
color modes from n/cts lookup table.
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_audio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
index 840daff12246..156d524c29d9 100644
--- a/drivers/gpu/drm/i915/display/intel_audio.c
+++ b/drivers/gpu/drm/i915/display/intel_audio.c
@@ -212,13 +212,11 @@ static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_sta
static int audio_config_hdmi_get_n(const struct intel_crtc_state *crtc_state,
int rate)
{
- const struct drm_display_mode *adjusted_mode =
- &crtc_state->base.adjusted_mode;
int i;
for (i = 0; i < ARRAY_SIZE(hdmi_aud_ncts); i++) {
if (rate == hdmi_aud_ncts[i].sample_rate &&
- adjusted_mode->crtc_clock == hdmi_aud_ncts[i].clock) {
+ crtc_state->port_clock == hdmi_aud_ncts[i].clock) {
return hdmi_aud_ncts[i].n;
}
}
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/2] drm/i915: Add N & CTS values for 10/12 bit deep color 2019-06-27 22:07 [PATCH v2 1/2] drm/i915: Use port clock to set correct N value Aditya Swarup @ 2019-06-27 22:07 ` Aditya Swarup 2019-06-27 22:33 ` ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915: Use port clock to set correct N value Patchwork ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: Aditya Swarup @ 2019-06-27 22:07 UTC (permalink / raw) To: intel-gfx; +Cc: Jani Nikula Adding N & CTS values for 10/12 bit deep color from Appendix C table in HDMI 2.0 spec. The correct values for N is not chosen automatically by hardware for deep color modes. v2: Remove unnecessary initialization of size Signed-off-by: Aditya Swarup <aditya.swarup@intel.com> Cc: Clint Taylor <Clinton.A.Taylor@intel.com> Cc: Jani Nikula <jani.nikula@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_audio.c | 79 +++++++++++++++++++--- 1 file changed, 68 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c index 156d524c29d9..c8fd35a7ca42 100644 --- a/drivers/gpu/drm/i915/display/intel_audio.c +++ b/drivers/gpu/drm/i915/display/intel_audio.c @@ -72,6 +72,13 @@ struct dp_aud_n_m { u16 n; }; +struct hdmi_aud_ncts { + int sample_rate; + int clock; + int n; + int cts; +}; + /* Values according to DP 1.4 Table 2-104 */ static const struct dp_aud_n_m dp_aud_n_m[] = { { 32000, LC_162M, 1024, 10125 }, @@ -148,12 +155,7 @@ static const struct { #define TMDS_594M 594000 #define TMDS_593M 593407 -static const struct { - int sample_rate; - int clock; - int n; - int cts; -} hdmi_aud_ncts[] = { +static const struct hdmi_aud_ncts hdmi_aud_ncts_24bpp[] = { { 32000, TMDS_296M, 5824, 421875 }, { 32000, TMDS_297M, 3072, 222750 }, { 32000, TMDS_593M, 5824, 843750 }, @@ -184,6 +186,49 @@ static const struct { { 192000, TMDS_594M, 24576, 594000 }, }; +/* Appendix C - N & CTS values for deep color from HDMI 2.0 spec*/ +/* HDMI N/CTS table for 10 bit deep color(30 bpp)*/ +#define TMDS_371M 371250 +#define TMDS_370M 370878 + +static const struct hdmi_aud_ncts hdmi_aud_ncts_30bpp[] = { + { 32000, TMDS_370M, 5824, 527344 }, + { 32000, TMDS_371M, 6144, 556875 }, + { 44100, TMDS_370M, 8918, 585938 }, + { 44100, TMDS_371M, 4704, 309375 }, + { 88200, TMDS_370M, 17836, 585938 }, + { 88200, TMDS_371M, 9408, 309375 }, + { 176400, TMDS_370M, 35672, 585938 }, + { 176400, TMDS_371M, 18816, 309375 }, + { 48000, TMDS_370M, 11648, 703125 }, + { 48000, TMDS_371M, 5120, 309375 }, + { 96000, TMDS_370M, 23296, 703125 }, + { 96000, TMDS_371M, 10240, 309375 }, + { 192000, TMDS_370M, 46592, 703125 }, + { 192000, TMDS_371M, 20480, 309375 }, +}; + +/* HDMI N/CTS table for 12 bit deep color(36 bpp)*/ +#define TMDS_445_5M 445500 +#define TMDS_445M 445054 + +static const struct hdmi_aud_ncts hdmi_aud_ncts_36bpp[] = { + { 32000, TMDS_445M, 5824, 632813 }, + { 32000, TMDS_445_5M, 4096, 445500 }, + { 44100, TMDS_445M, 8918, 703125 }, + { 44100, TMDS_445_5M, 4704, 371250 }, + { 88200, TMDS_445M, 17836, 703125 }, + { 88200, TMDS_445_5M, 9408, 371250 }, + { 176400, TMDS_445M, 35672, 703125 }, + { 176400, TMDS_445_5M, 18816, 371250 }, + { 48000, TMDS_445M, 5824, 421875 }, + { 48000, TMDS_445_5M, 5120, 371250 }, + { 96000, TMDS_445M, 11648, 421875 }, + { 96000, TMDS_445_5M, 10240, 371250 }, + { 192000, TMDS_445M, 23296, 421875 }, + { 192000, TMDS_445_5M, 20480, 371250 }, +}; + /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */ static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_state) { @@ -212,12 +257,24 @@ static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_sta static int audio_config_hdmi_get_n(const struct intel_crtc_state *crtc_state, int rate) { - int i; + const struct hdmi_aud_ncts *hdmi_ncts_table; + int i, size; + + if (crtc_state->pipe_bpp == 36) { + hdmi_ncts_table = hdmi_aud_ncts_36bpp; + size = ARRAY_SIZE(hdmi_aud_ncts_36bpp); + } else if (crtc_state->pipe_bpp == 30) { + hdmi_ncts_table = hdmi_aud_ncts_30bpp; + size = ARRAY_SIZE(hdmi_aud_ncts_30bpp); + } else { + hdmi_ncts_table = hdmi_aud_ncts_24bpp; + size = ARRAY_SIZE(hdmi_aud_ncts_24bpp); + } - for (i = 0; i < ARRAY_SIZE(hdmi_aud_ncts); i++) { - if (rate == hdmi_aud_ncts[i].sample_rate && - crtc_state->port_clock == hdmi_aud_ncts[i].clock) { - return hdmi_aud_ncts[i].n; + for (i = 0; i < size; i++) { + if (rate == hdmi_ncts_table[i].sample_rate && + crtc_state->port_clock == hdmi_ncts_table[i].clock) { + return hdmi_ncts_table[i].n; } } return 0; -- 2.17.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915: Use port clock to set correct N value 2019-06-27 22:07 [PATCH v2 1/2] drm/i915: Use port clock to set correct N value Aditya Swarup 2019-06-27 22:07 ` [PATCH v2 2/2] drm/i915: Add N & CTS values for 10/12 bit deep color Aditya Swarup @ 2019-06-27 22:33 ` Patchwork 2019-06-28 10:18 ` ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2019-06-27 22:33 UTC (permalink / raw) To: Aditya Swarup; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/2] drm/i915: Use port clock to set correct N value URL : https://patchwork.freedesktop.org/series/62895/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Use port clock to set correct N value Okay! Commit: drm/i915: Add N & CTS values for 10/12 bit deep color +drivers/gpu/drm/i915/display/intel_audio.c:1026:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_audio.c:1026:34: warning: expression using sizeof(void) -drivers/gpu/drm/i915/display/intel_audio.c:1026:34: warning: expression using sizeof(void) -drivers/gpu/drm/i915/display/intel_audio.c:1026:34: warning: expression using sizeof(void) _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Use port clock to set correct N value 2019-06-27 22:07 [PATCH v2 1/2] drm/i915: Use port clock to set correct N value Aditya Swarup 2019-06-27 22:07 ` [PATCH v2 2/2] drm/i915: Add N & CTS values for 10/12 bit deep color Aditya Swarup 2019-06-27 22:33 ` ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915: Use port clock to set correct N value Patchwork @ 2019-06-28 10:18 ` Patchwork 2019-06-28 19:02 ` ✓ Fi.CI.IGT: " Patchwork 2019-07-03 18:53 ` [PATCH v2 1/2] " Ville Syrjälä 4 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2019-06-28 10:18 UTC (permalink / raw) To: Aditya Swarup; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/2] drm/i915: Use port clock to set correct N value URL : https://patchwork.freedesktop.org/series/62895/ State : success == Summary == CI Bug Log - changes from CI_DRM_6376 -> Patchwork_13462 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/ Known issues ------------ Here are the changes found in Patchwork_13462 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_create@basic-files: - fi-icl-u3: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#109100]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/fi-icl-u3/igt@gem_ctx_create@basic-files.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/fi-icl-u3/igt@gem_ctx_create@basic-files.html * igt@gem_ctx_switch@basic-default: - fi-icl-guc: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#108569]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/fi-icl-guc/igt@gem_ctx_switch@basic-default.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/fi-icl-guc/igt@gem_ctx_switch@basic-default.html * igt@i915_selftest@live_blt: - fi-skl-iommu: [PASS][5] -> [INCOMPLETE][6] ([fdo#108602]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/fi-skl-iommu/igt@i915_selftest@live_blt.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/fi-skl-iommu/igt@i915_selftest@live_blt.html * igt@i915_selftest@live_hangcheck: - fi-icl-dsi: [PASS][7] -> [INCOMPLETE][8] ([fdo#107713] / [fdo#108569]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html #### Possible fixes #### * igt@i915_pm_rpm@basic-pci-d3-state: - fi-kbl-r: [DMESG-WARN][9] ([fdo#111012]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/fi-kbl-r/igt@i915_pm_rpm@basic-pci-d3-state.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/fi-kbl-r/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@module-reload: - fi-cml-u2: [DMESG-WARN][11] -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/fi-cml-u2/igt@i915_pm_rpm@module-reload.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/fi-cml-u2/igt@i915_pm_rpm@module-reload.html * igt@kms_frontbuffer_tracking@basic: - fi-icl-u2: [FAIL][13] ([fdo#103167]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html #### Warnings #### * igt@runner@aborted: - fi-kbl-r: [FAIL][15] ([fdo#103841] / [fdo#110992]) -> [FAIL][16] ([fdo#103841] / [fdo#109383] / [fdo#110992]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/fi-kbl-r/igt@runner@aborted.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/fi-kbl-r/igt@runner@aborted.html [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#109383]: https://bugs.freedesktop.org/show_bug.cgi?id=109383 [fdo#110992]: https://bugs.freedesktop.org/show_bug.cgi?id=110992 [fdo#111012]: https://bugs.freedesktop.org/show_bug.cgi?id=111012 Participating hosts (53 -> 45) ------------------------------ Additional (1): fi-snb-2600 Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bdw-gvtdvm fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * Linux: CI_DRM_6376 -> Patchwork_13462 CI_DRM_6376: 092d19896d2abb3f132713e72608386f670ddbb0 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5071: 3c4edeba35ac699db5b39600eb17f4151c6b42fd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13462: 8acbd2fa223a4da75324284094e12649e35a1a63 @ git://anongit.freedesktop.org/gfx-ci/linux == Kernel 32bit build == Warning: Kernel 32bit buildtest failed: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/build_32bit.log CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 112 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1287: recipe for target 'modules' failed make: *** [modules] Error 2 == Linux commits == 8acbd2fa223a drm/i915: Add N & CTS values for 10/12 bit deep color 74ba1961c02a drm/i915: Use port clock to set correct N value == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915: Use port clock to set correct N value 2019-06-27 22:07 [PATCH v2 1/2] drm/i915: Use port clock to set correct N value Aditya Swarup ` (2 preceding siblings ...) 2019-06-28 10:18 ` ✓ Fi.CI.BAT: success " Patchwork @ 2019-06-28 19:02 ` Patchwork 2019-07-03 18:53 ` [PATCH v2 1/2] " Ville Syrjälä 4 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2019-06-28 19:02 UTC (permalink / raw) To: Aditya Swarup; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/2] drm/i915: Use port clock to set correct N value URL : https://patchwork.freedesktop.org/series/62895/ State : success == Summary == CI Bug Log - changes from CI_DRM_6376_full -> Patchwork_13462_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_13462_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-iclb1/igt@gem_exec_balancer@smoke.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-iclb6/igt@gem_exec_balancer@smoke.html * igt@i915_pm_rpm@i2c: - shard-hsw: [PASS][3] -> [FAIL][4] ([fdo#104097]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-hsw2/igt@i915_pm_rpm@i2c.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-hsw6/igt@i915_pm_rpm@i2c.html * igt@i915_selftest@live_hangcheck: - shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713] / [fdo#108569]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-iclb5/igt@i915_selftest@live_hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-iclb2/igt@i915_selftest@live_hangcheck.html * igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen: - shard-skl: [PASS][7] -> [FAIL][8] ([fdo#103232]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen.html * igt@kms_cursor_legacy@cursorb-vs-flipb-atomic: - shard-hsw: [PASS][9] -> [SKIP][10] ([fdo#109271]) +16 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-hsw2/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-hsw1/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt: - shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +5 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-apl: [PASS][13] -> [DMESG-WARN][14] ([fdo#108566]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-apl4/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][15] -> [FAIL][16] ([fdo#108145] / [fdo#110403]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr2_su@page_flip: - shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109642]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-iclb2/igt@kms_psr2_su@page_flip.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-iclb5/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +2 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-iclb7/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend: - shard-kbl: [PASS][21] -> [INCOMPLETE][22] ([fdo#103665]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-kbl2/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-kbl3/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html #### Possible fixes #### * igt@gem_ctx_isolation@vcs1-s3: - shard-kbl: [DMESG-WARN][23] ([fdo#108566]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-kbl3/igt@gem_ctx_isolation@vcs1-s3.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-kbl6/igt@gem_ctx_isolation@vcs1-s3.html * igt@gem_ctx_switch@basic-all-heavy: - shard-hsw: [INCOMPLETE][25] ([fdo#103540]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-hsw6/igt@gem_ctx_switch@basic-all-heavy.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-hsw6/igt@gem_ctx_switch@basic-all-heavy.html * igt@gem_mmap_gtt@hang: - shard-iclb: [FAIL][27] ([fdo#109677]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-iclb5/igt@gem_mmap_gtt@hang.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-iclb8/igt@gem_mmap_gtt@hang.html * igt@gem_tiled_swapping@non-threaded: - shard-glk: [DMESG-WARN][29] ([fdo#108686] / [fdo#110853]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-glk2/igt@gem_tiled_swapping@non-threaded.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-glk6/igt@gem_tiled_swapping@non-threaded.html * igt@i915_pm_rc6_residency@rc6-accuracy: - shard-snb: [SKIP][31] ([fdo#109271]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-snb4/igt@i915_pm_rc6_residency@rc6-accuracy.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-snb1/igt@i915_pm_rc6_residency@rc6-accuracy.html * igt@kms_fbcon_fbt@psr-suspend: - shard-skl: [INCOMPLETE][33] ([fdo#104108]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-skl5/igt@kms_fbcon_fbt@psr-suspend.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-skl10/igt@kms_fbcon_fbt@psr-suspend.html * igt@kms_flip@flip-vs-suspend: - shard-skl: [INCOMPLETE][35] ([fdo#109507]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-skl10/igt@kms_flip@flip-vs-suspend.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-skl2/igt@kms_flip@flip-vs-suspend.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff: - shard-hsw: [SKIP][37] ([fdo#109271]) -> [PASS][38] +6 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-hsw4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt: - shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +5 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [SKIP][41] ([fdo#109642]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-iclb8/igt@kms_psr2_su@frontbuffer.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-iclb2/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_cursor_plane_onoff: - shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +1 similar issue [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-iclb7/igt@kms_psr@psr2_cursor_plane_onoff.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html * igt@kms_sysfs_edid_timing: - shard-iclb: [FAIL][45] ([fdo#100047]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-iclb2/igt@kms_sysfs_edid_timing.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-iclb4/igt@kms_sysfs_edid_timing.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-apl: [DMESG-WARN][47] ([fdo#108566]) -> [PASS][48] +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6376/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/shard-apl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#109677]: https://bugs.freedesktop.org/show_bug.cgi?id=109677 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110853]: https://bugs.freedesktop.org/show_bug.cgi?id=110853 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_6376 -> Patchwork_13462 CI_DRM_6376: 092d19896d2abb3f132713e72608386f670ddbb0 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5071: 3c4edeba35ac699db5b39600eb17f4151c6b42fd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13462: 8acbd2fa223a4da75324284094e12649e35a1a63 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13462/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] drm/i915: Use port clock to set correct N value 2019-06-27 22:07 [PATCH v2 1/2] drm/i915: Use port clock to set correct N value Aditya Swarup ` (3 preceding siblings ...) 2019-06-28 19:02 ` ✓ Fi.CI.IGT: " Patchwork @ 2019-07-03 18:53 ` Ville Syrjälä 4 siblings, 0 replies; 6+ messages in thread From: Ville Syrjälä @ 2019-07-03 18:53 UTC (permalink / raw) To: Aditya Swarup; +Cc: Jani Nikula, intel-gfx On Thu, Jun 27, 2019 at 03:07:07PM -0700, Aditya Swarup wrote: > Use port_clock to check the clock values in n/cts lookup table instead > of crtc_clock. As port_clock is already adjusted based on color mode set > (8 bit or deep color), this will help in checking clock values for deep > color modes from n/cts lookup table. > > Signed-off-by: Aditya Swarup <aditya.swarup@intel.com> > Cc: Clint Taylor <Clinton.A.Taylor@intel.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Pushed the series to dinq. Thanks. > --- > drivers/gpu/drm/i915/display/intel_audio.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c > index 840daff12246..156d524c29d9 100644 > --- a/drivers/gpu/drm/i915/display/intel_audio.c > +++ b/drivers/gpu/drm/i915/display/intel_audio.c > @@ -212,13 +212,11 @@ static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_sta > static int audio_config_hdmi_get_n(const struct intel_crtc_state *crtc_state, > int rate) > { > - const struct drm_display_mode *adjusted_mode = > - &crtc_state->base.adjusted_mode; > int i; > > for (i = 0; i < ARRAY_SIZE(hdmi_aud_ncts); i++) { > if (rate == hdmi_aud_ncts[i].sample_rate && > - adjusted_mode->crtc_clock == hdmi_aud_ncts[i].clock) { > + crtc_state->port_clock == hdmi_aud_ncts[i].clock) { > return hdmi_aud_ncts[i].n; > } > } > -- > 2.17.1 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-03 18:53 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-06-27 22:07 [PATCH v2 1/2] drm/i915: Use port clock to set correct N value Aditya Swarup 2019-06-27 22:07 ` [PATCH v2 2/2] drm/i915: Add N & CTS values for 10/12 bit deep color Aditya Swarup 2019-06-27 22:33 ` ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915: Use port clock to set correct N value Patchwork 2019-06-28 10:18 ` ✓ Fi.CI.BAT: success " Patchwork 2019-06-28 19:02 ` ✓ Fi.CI.IGT: " Patchwork 2019-07-03 18:53 ` [PATCH v2 1/2] " Ville Syrjälä
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox