✗ Fi.CI.CHECKPATCH: warning for drm/i915: Vulkan performance query support (rev6)

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: drm/i915: Vulkan performance query support (rev6)
URL   : https://patchwork.freedesktop.org/series/60916/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
063d9e6a602f drm/i915/perf: add missing delay for OA muxes configuration
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 29 lines checked
5d6fb48512bb drm/i915/perf: introduce a versioning of the i915-perf uapi
61476a43f18a drm/i915/perf: allow for CS OA configs to be created lazily
-:138: CHECK:SPACING: No space is necessary after a cast
#138: FILE: drivers/gpu/drm/i915/i915_perf.c:399:
+					(u32) MI_LOAD_REGISTER_IMM_MAX_REGS);

total: 0 errors, 0 warnings, 1 checks, 361 lines checked
d84a895e334c drm/i915: enumerate scratch fields
-:25: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#25: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:30:
 {
+

-:89: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#89: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1809:
+	batch = gen8_emit_pipe_control(

total: 0 errors, 0 warnings, 2 checks, 171 lines checked
9762d251a468 drm/i915/perf: implement active wait for noa configurations
-:33: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#33: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:230:
+#define MI_MATH(x) MI_INSTR(0x1a, (x)-1)
                                      ^

-:106: CHECK:LINE_SPACING: Please don't use multiple blank lines
#106: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3672:
+
+

-:163: CHECK:LINE_SPACING: Please don't use multiple blank lines
#163: FILE: drivers/gpu/drm/i915/i915_perf.c:450:
 
+

-:187: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#187: FILE: drivers/gpu/drm/i915/i915_perf.c:1666:
+	uint32_t d;

-:204: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#204: FILE: drivers/gpu/drm/i915/i915_perf.c:1683:
+	uint32_t d;

-:243: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#243: FILE: drivers/gpu/drm/i915/i915_perf.c:1722:
+	batch = cs = i915_gem_object_pin_map(bo, I915_MAP_WB);

total: 0 errors, 0 warnings, 6 checks, 381 lines checked
35af21623514 drm/i915: introduce a mechanism to extend execbuf2
-:128: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#128: FILE: include/uapi/drm/i915_drm.h:1170:
+#define __I915_EXEC_UNKNOWN_FLAGS (-(I915_EXEC_EXT<<1))
                                                   ^

total: 0 errors, 0 warnings, 1 checks, 105 lines checked
d0bdcdd65e5d drm/i915: add syncobj timeline support
-:347: WARNING:TYPO_SPELLING: 'transfered' may be misspelled - perhaps 'transferred'?
#347: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2501:
+			 * The chain's ownership is transfered to the

-:378: ERROR:CODE_INDENT: code indent should use tabs where possible
#378: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2532:
+        [DRM_I915_GEM_EXECBUFFER_EXT_TIMELINE_FENCES] = parse_timeline_fences,$

-:378: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#378: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2532:
+        [DRM_I915_GEM_EXECBUFFER_EXT_TIMELINE_FENCES] = parse_timeline_fences,$

total: 1 errors, 2 warnings, 0 checks, 521 lines checked
243b2d67cc0f drm/i915: add a new perf configuration execbuf parameter
-:48: CHECK:LINE_SPACING: Please don't use multiple blank lines
#48: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1218:
 
+

-:140: ERROR:CODE_INDENT: code indent should use tabs where possible
#140: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2607:
+        [DRM_I915_GEM_EXECBUFFER_EXT_PERF] = parse_perf_config,$

-:140: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#140: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2607:
+        [DRM_I915_GEM_EXECBUFFER_EXT_PERF] = parse_perf_config,$

total: 1 errors, 1 warnings, 1 checks, 405 lines checked
aa1c4a084e04 drm/i915/perf: allow holding preemption on filtered ctx
-:154: WARNING:BRACES: braces {} are not necessary for single statement blocks
#154: FILE: drivers/gpu/drm/i915/i915_perf.c:2968:
+	if (IS_HASWELL(dev_priv) && specific_ctx && !props->hold_preemption) {
 		privileged_op = false;
+	}

total: 0 errors, 1 warnings, 0 checks, 220 lines checked
ee7f0b256c01 drm/i915/perf: execute OA configuration from command stream
e4ee8661e287 drm/i915: add support for perf configuration queries

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx