Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/20] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt
Date: Thu, 18 Jul 2019 07:16:41 -0000	[thread overview]
Message-ID: <20190718071641.17743.39962@emeril.freedesktop.org> (raw)
In-Reply-To: <20190718070024.21781-1-chris@chris-wilson.co.uk>

== Series Details ==

Series: series starting with [01/20] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt
URL   : https://patchwork.freedesktop.org/series/63857/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3052e16a851c drm/i915: Move aliasing_ppgtt underneath its i915_ggtt
1684f3a8d94e drm/i915/gt: Hook up intel_context_fini()
d2060ed71f61 drm/i915/gt: Provde a local intel_context.vm
f6813d8e65f0 drm/i915/execlists: Cancel breadcrumb on preempting the virtual engine
7e180af1cb48 drm/i915: Hide unshrinkable context objects from the shrinker
c7d76267ac52 drm/i915: Remove obsolete engine cleanup
a61f9122ac61 drm/i915/gt: Move the [class][inst] lookup for engines onto the GT
-:222: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#222: 
new file mode 100644

-:227: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#227: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:1:
+/*

-:228: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#228: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:2:
+ * SPDX-License-Identifier: MIT

-:299: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#299: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.h:1:
+/*

-:300: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#300: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 415 lines checked
3261a51b15e0 drm/i915: Introduce for_each_user_engine()
-:215: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects?
#215: FILE: drivers/gpu/drm/i915/i915_drv.h:1921:
+#define for_each_user_engine(engine__, i915__) \
+	for ((engine__) = rb_to_uabi_engine(rb_first(&(i915__)->uabi_engines));\
+	     (engine__); \
+	     (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))

total: 0 errors, 0 warnings, 1 checks, 187 lines checked
c9f4cfe20812 drm/i915: Use intel_engine_lookup_user for probing HAS_BSD etc
f5d82fdf1f10 drm/i915: Isolate i915_getparam_ioctl()
-:235: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#235: 
new file mode 100644

-:240: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#240: FILE: drivers/gpu/drm/i915/i915_getparam.c:1:
+/*

-:241: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#241: FILE: drivers/gpu/drm/i915/i915_getparam.c:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 3 warnings, 0 checks, 374 lines checked
36fbf18b8bbc drm/i915: Rely on spinlock protection for GPU error capture
dab6a7647b6d drm/i915: Only include active engines in the capture state
ea58bbcbcc0d drm/i915: Teach execbuffer to take the engine wakeref not GT
ffd4a96993ad drm/i915/gt: Track timeline activeness in enter/exit
9ae34c3eea1b drm/i915/gt: Convert timeline tracking to spinlock
4dc0ccc95ef6 drm/i915/gt: Guard timeline pinning with its own mutex
2a2c98f24a90 drm/i915/gt: Add to timeline requires the timeline mutex
fd3f9ca3ba1d drm/i915: Protect request retirement with timeline->mutex
cfc5c6c2edf2 drm/i915: Replace struct_mutex for batch pool serialisation
-:305: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#305: 
new file mode 100644

-:310: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#310: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:1:
+/*

-:311: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#311: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:2:
+ * SPDX-License-Identifier: MIT

-:493: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#493: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:1:
+/*

-:494: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#494: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:2:
+ * SPDX-License-Identifier: MIT

-:533: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#533: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:1:
+/*

-:534: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#534: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:2:
+ * SPDX-License-Identifier: MIT

-:550: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#550: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:18:
+	spinlock_t lock;

total: 0 errors, 7 warnings, 1 checks, 604 lines checked
3bc0b1b684ae drm/i915/gt: Mark context->active_count as protected by timeline->mutex

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-07-18  7:16 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190718070024.21781-1-chris@chris-wilson.co.uk>
2019-07-18  7:00 ` [PATCH 02/20] drm/i915/gt: Hook up intel_context_fini() Chris Wilson
2019-07-22 12:22   ` Tvrtko Ursulin
2019-07-18  7:00 ` [PATCH 04/20] drm/i915/execlists: Cancel breadcrumb on preempting the virtual engine Chris Wilson
2019-07-18  7:00 ` [PATCH 05/20] drm/i915: Hide unshrinkable context objects from the shrinker Chris Wilson
2019-07-18  7:00 ` [PATCH 06/20] drm/i915: Remove obsolete engine cleanup Chris Wilson
2019-07-22 12:46   ` Tvrtko Ursulin
2019-07-22 16:29     ` Chris Wilson
2019-07-18  7:00 ` [PATCH 07/20] drm/i915/gt: Move the [class][inst] lookup for engines onto the GT Chris Wilson
2019-07-18  7:00 ` [PATCH 09/20] drm/i915: Use intel_engine_lookup_user for probing HAS_BSD etc Chris Wilson
2019-07-22 12:49   ` Tvrtko Ursulin
2019-07-22 16:34     ` Chris Wilson
2019-07-18  7:00 ` [PATCH 11/20] drm/i915: Rely on spinlock protection for GPU error capture Chris Wilson
2019-07-22 13:40   ` Tvrtko Ursulin
2019-07-18  7:00 ` [PATCH 13/20] drm/i915: Teach execbuffer to take the engine wakeref not GT Chris Wilson
2019-07-22 16:03   ` Tvrtko Ursulin
2019-07-18  7:00 ` [PATCH 14/20] drm/i915/gt: Track timeline activeness in enter/exit Chris Wilson
2019-07-22 16:14   ` Tvrtko Ursulin
2019-07-22 16:42     ` Chris Wilson
2019-07-18  7:00 ` [PATCH 15/20] drm/i915/gt: Convert timeline tracking to spinlock Chris Wilson
2019-07-18  7:00 ` [PATCH 17/20] drm/i915/gt: Add to timeline requires the timeline mutex Chris Wilson
2019-07-18  7:00 ` [PATCH 18/20] drm/i915: Protect request retirement with timeline->mutex Chris Wilson
2019-07-18  7:00 ` [PATCH 20/20] drm/i915/gt: Mark context->active_count as protected by timeline->mutex Chris Wilson
2019-07-18  7:16 ` Patchwork [this message]
2019-07-18  7:25 ` ✗ Fi.CI.SPARSE: warning for series starting with [01/20] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Patchwork
2019-07-18  7:48 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-18 10:05 ` ✓ Fi.CI.IGT: " Patchwork
     [not found] ` <20190718070024.21781-3-chris@chris-wilson.co.uk>
2019-07-22 12:33   ` [PATCH 03/20] drm/i915/gt: Provde a local intel_context.vm Tvrtko Ursulin
2019-07-22 16:28     ` Chris Wilson
2019-07-23 13:44       ` Tvrtko Ursulin
     [not found] ` <20190718070024.21781-10-chris@chris-wilson.co.uk>
2019-07-22 12:53   ` [PATCH 10/20] drm/i915: Isolate i915_getparam_ioctl() Tvrtko Ursulin
2019-07-22 16:04   ` Tvrtko Ursulin
2019-07-22 16:16     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190718071641.17743.39962@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox