Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 03/20] drm/i915/gt: Provde a local intel_context.vm
Date: Tue, 23 Jul 2019 14:44:40 +0100	[thread overview]
Message-ID: <c9981100-2479-0066-ee8f-f16cf9dfa80d@linux.intel.com> (raw)
In-Reply-To: <156381289355.31349.2085005736634640131@skylake-alporthouse-com>


On 22/07/2019 17:28, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-07-22 13:33:14)
>>
>> On 18/07/2019 08:00, Chris Wilson wrote:
>>> @@ -1113,9 +1121,8 @@ static int set_ppgtt(struct drm_i915_file_private *file_priv,
>>>                                   set_ppgtt_barrier,
>>>                                   old);
>>>        if (err) {
>>> -             ctx->vm = old;
>>> -             ctx->desc_template = default_desc_template(ctx->i915, old);
>>> -             i915_vm_put(vm);
>>> +             i915_vm_put(__set_ppgtt(ctx, old));
>>> +             i915_vm_put(old);
>>
>> Shouldn't this still be i915_vm_out(vm), for the extra vm reference the
>> function did further up?
> 
> __set_ppgtt() returns the vm, so this is
> 	i915_vm_put(vm);
> 	i915_vm_put(old); /* since we just acquired a ref to old again */

get(old), put(vm), put(old) - okay, you seem to be right indeed.

Fix a typo in subject and:

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-07-23 13:44 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190718070024.21781-1-chris@chris-wilson.co.uk>
2019-07-18  7:00 ` [PATCH 02/20] drm/i915/gt: Hook up intel_context_fini() Chris Wilson
2019-07-22 12:22   ` Tvrtko Ursulin
2019-07-18  7:00 ` [PATCH 04/20] drm/i915/execlists: Cancel breadcrumb on preempting the virtual engine Chris Wilson
2019-07-18  7:00 ` [PATCH 05/20] drm/i915: Hide unshrinkable context objects from the shrinker Chris Wilson
2019-07-18  7:00 ` [PATCH 06/20] drm/i915: Remove obsolete engine cleanup Chris Wilson
2019-07-22 12:46   ` Tvrtko Ursulin
2019-07-22 16:29     ` Chris Wilson
2019-07-18  7:00 ` [PATCH 07/20] drm/i915/gt: Move the [class][inst] lookup for engines onto the GT Chris Wilson
2019-07-18  7:00 ` [PATCH 09/20] drm/i915: Use intel_engine_lookup_user for probing HAS_BSD etc Chris Wilson
2019-07-22 12:49   ` Tvrtko Ursulin
2019-07-22 16:34     ` Chris Wilson
2019-07-18  7:00 ` [PATCH 11/20] drm/i915: Rely on spinlock protection for GPU error capture Chris Wilson
2019-07-22 13:40   ` Tvrtko Ursulin
2019-07-18  7:00 ` [PATCH 13/20] drm/i915: Teach execbuffer to take the engine wakeref not GT Chris Wilson
2019-07-22 16:03   ` Tvrtko Ursulin
2019-07-18  7:00 ` [PATCH 14/20] drm/i915/gt: Track timeline activeness in enter/exit Chris Wilson
2019-07-22 16:14   ` Tvrtko Ursulin
2019-07-22 16:42     ` Chris Wilson
2019-07-18  7:00 ` [PATCH 15/20] drm/i915/gt: Convert timeline tracking to spinlock Chris Wilson
2019-07-18  7:00 ` [PATCH 17/20] drm/i915/gt: Add to timeline requires the timeline mutex Chris Wilson
2019-07-18  7:00 ` [PATCH 18/20] drm/i915: Protect request retirement with timeline->mutex Chris Wilson
2019-07-18  7:00 ` [PATCH 20/20] drm/i915/gt: Mark context->active_count as protected by timeline->mutex Chris Wilson
2019-07-18  7:16 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/20] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Patchwork
2019-07-18  7:25 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-07-18  7:48 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-18 10:05 ` ✓ Fi.CI.IGT: " Patchwork
     [not found] ` <20190718070024.21781-3-chris@chris-wilson.co.uk>
2019-07-22 12:33   ` [PATCH 03/20] drm/i915/gt: Provde a local intel_context.vm Tvrtko Ursulin
2019-07-22 16:28     ` Chris Wilson
2019-07-23 13:44       ` Tvrtko Ursulin [this message]
     [not found] ` <20190718070024.21781-10-chris@chris-wilson.co.uk>
2019-07-22 12:53   ` [PATCH 10/20] drm/i915: Isolate i915_getparam_ioctl() Tvrtko Ursulin
2019-07-22 16:04   ` Tvrtko Ursulin
2019-07-22 16:16     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9981100-2479-0066-ee8f-f16cf9dfa80d@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox