From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/5] drm/i915: Make wait_for_timelines take struct intel_gt
Date: Wed, 24 Jul 2019 11:07:14 +0100 [thread overview]
Message-ID: <20190724100716.10731-3-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20190724100716.10731-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Timelines live in struct intel_gt so make wait_for_timelines take
exactly what it needs.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 272e008c55ef..9a567205e32a 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -906,21 +906,20 @@ static int wait_for_engines(struct intel_gt *gt)
}
static long
-wait_for_timelines(struct drm_i915_private *i915,
- unsigned int flags, long timeout)
+wait_for_timelines(struct intel_gt *gt, unsigned int flags, long timeout)
{
- struct intel_gt_timelines *gt = &i915->gt.timelines;
+ struct intel_gt_timelines *timelines = >->timelines;
struct intel_timeline *tl;
- mutex_lock(>->mutex);
- list_for_each_entry(tl, >->active_list, link) {
+ mutex_lock(&timelines->mutex);
+ list_for_each_entry(tl, &timelines->active_list, link) {
struct i915_request *rq;
rq = i915_active_request_get_unlocked(&tl->last_request);
if (!rq)
continue;
- mutex_unlock(>->mutex);
+ mutex_unlock(&timelines->mutex);
/*
* "Race-to-idle".
@@ -940,10 +939,10 @@ wait_for_timelines(struct drm_i915_private *i915,
return timeout;
/* restart after reacquiring the lock */
- mutex_lock(>->mutex);
- tl = list_entry(>->active_list, typeof(*tl), link);
+ mutex_lock(&timelines->mutex);
+ tl = list_entry(&timelines->active_list, typeof(*tl), link);
}
- mutex_unlock(>->mutex);
+ mutex_unlock(&timelines->mutex);
return timeout;
}
@@ -951,16 +950,18 @@ wait_for_timelines(struct drm_i915_private *i915,
int i915_gem_wait_for_idle(struct drm_i915_private *i915,
unsigned int flags, long timeout)
{
+ struct intel_gt *gt = &i915->gt;
+
/* If the device is asleep, we have no requests outstanding */
- if (!READ_ONCE(i915->gt.awake))
+ if (!READ_ONCE(gt->awake))
return 0;
GEM_TRACE("flags=%x (%s), timeout=%ld%s, awake?=%s\n",
flags, flags & I915_WAIT_LOCKED ? "locked" : "unlocked",
timeout, timeout == MAX_SCHEDULE_TIMEOUT ? " (forever)" : "",
- yesno(i915->gt.awake));
+ yesno(gt->awake));
- timeout = wait_for_timelines(i915, flags, timeout);
+ timeout = wait_for_timelines(gt, flags, timeout);
if (timeout < 0)
return timeout;
@@ -969,7 +970,7 @@ int i915_gem_wait_for_idle(struct drm_i915_private *i915,
lockdep_assert_held(&i915->drm.struct_mutex);
- err = wait_for_engines(&i915->gt);
+ err = wait_for_engines(gt);
if (err)
return err;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-24 10:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 10:07 [PATCH 1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts Tvrtko Ursulin
2019-07-24 10:07 ` [PATCH 2/5] drm/i915: Avoid one round-tip through global i915 when getting to gt Tvrtko Ursulin
2019-07-24 10:14 ` Chris Wilson
2019-07-24 10:32 ` Tvrtko Ursulin
2019-07-24 10:07 ` Tvrtko Ursulin [this message]
2019-07-24 10:07 ` [PATCH 4/5] drm/i915: Avoid round-trip via i915 in intel_gt_park Tvrtko Ursulin
2019-07-24 10:07 ` [PATCH 5/5] drm/i915: Make pm_notify take intel_gt Tvrtko Ursulin
2019-07-24 10:41 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts Patchwork
2019-07-24 12:31 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-07-24 13:00 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts (rev2) Patchwork
2019-07-24 15:53 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-24 18:18 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724100716.10731-3-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox