Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/5] drm/i915: Avoid round-trip via i915 in intel_gt_park
Date: Wed, 24 Jul 2019 11:07:15 +0100	[thread overview]
Message-ID: <20190724100716.10731-4-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20190724100716.10731-1-tvrtko.ursulin@linux.intel.com>

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Both in the container_of and getting to gt->awake there is no need to go
via i915 since both the wakeref and awake are members of gt.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_gt_pm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
index 65c0d0c9d543..31c5e1910740 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
@@ -62,9 +62,9 @@ void intel_gt_pm_get(struct intel_gt *gt)
 
 static int intel_gt_park(struct intel_wakeref *wf)
 {
-	struct drm_i915_private *i915 =
-		container_of(wf, typeof(*i915), gt.wakeref);
-	intel_wakeref_t wakeref = fetch_and_zero(&i915->gt.awake);
+	struct intel_gt *gt = container_of(wf, typeof(*gt), wakeref);
+	intel_wakeref_t wakeref = fetch_and_zero(&gt->awake);
+	struct drm_i915_private *i915 = gt->i915;
 
 	GEM_TRACE("\n");
 
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-07-24 10:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24 10:07 [PATCH 1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts Tvrtko Ursulin
2019-07-24 10:07 ` [PATCH 2/5] drm/i915: Avoid one round-tip through global i915 when getting to gt Tvrtko Ursulin
2019-07-24 10:14   ` Chris Wilson
2019-07-24 10:32     ` Tvrtko Ursulin
2019-07-24 10:07 ` [PATCH 3/5] drm/i915: Make wait_for_timelines take struct intel_gt Tvrtko Ursulin
2019-07-24 10:07 ` Tvrtko Ursulin [this message]
2019-07-24 10:07 ` [PATCH 5/5] drm/i915: Make pm_notify take intel_gt Tvrtko Ursulin
2019-07-24 10:41 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts Patchwork
2019-07-24 12:31 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-07-24 13:00 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts (rev2) Patchwork
2019-07-24 15:53 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-24 18:18 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190724100716.10731-4-tvrtko.ursulin@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox