From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i915: do not leak module ref counter
Date: Fri, 2 Aug 2019 22:15:23 +0900 [thread overview]
Message-ID: <20190802131523.GB466@tigerII.localdomain> (raw)
In-Reply-To: <156475141863.6598.6809215010139776043@skylake-alporthouse-com>
On (08/02/19 14:10), Chris Wilson wrote:
> > > drivers/gpu/drm/i915/gem/i915_gemfs.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c
> > > index cf05ba72df9d..d437188d1736 100644
> > > --- a/drivers/gpu/drm/i915/gem/i915_gemfs.c
> > > +++ b/drivers/gpu/drm/i915/gem/i915_gemfs.c
> > > @@ -24,8 +24,10 @@ int i915_gemfs_init(struct drm_i915_private *i915)
> > > return -ENODEV;
> > >
> > > gemfs = kern_mount(type);
> >
> > Looking around, it looks like we always need to drop type after
> > mounting. Should the
> > put_filesystem(type);
> > be here instead?
> >
> > Anyway, nice catch.
>
> Sigh. put_filesystem() is part of fs internals. I'd be tempted to add
Good catch!
So we can switch to vfs_kern_mount(), I guess, but pass different options,
depending on has_transparent_hugepage().
-ss
next prev parent reply other threads:[~2019-08-02 13:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 12:39 [PATCH 1/2] i915: convert to new mount API Sergey Senozhatsky
2019-08-02 12:39 ` [PATCH 2/2] i915: do not leak module ref counter Sergey Senozhatsky
2019-08-02 12:58 ` Chris Wilson
2019-08-02 13:10 ` Chris Wilson
2019-08-02 13:15 ` Sergey Senozhatsky [this message]
2019-08-02 13:35 ` Sergey Senozhatsky
2019-08-02 13:41 ` Chris Wilson
2019-08-02 13:49 ` Sergey Senozhatsky
2019-08-02 13:59 ` Chris Wilson
2019-08-02 12:54 ` [PATCH 1/2] i915: convert to new mount API Chris Wilson
2019-08-02 13:10 ` Sergey Senozhatsky
2019-08-02 12:58 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2019-08-02 14:22 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] i915: convert to new mount API (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802131523.GB466@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox