From: dong.yang@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: Yang@freedesktop.org
Subject: [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0
Date: Wed, 14 Aug 2019 15:54:05 +0800 [thread overview]
Message-ID: <20190814075405.16822-1-dong.yang@intel.com> (raw)
From: "Yang, Dong" <dong.yang@intel.com>
Broxton steppings starting from GT E0 have fixed the bug, remove
WA since stepping GT E0.
v2: add comment in code, by:
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Yang, Dong <dong.yang@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5f3e5c13fbaa..a0dfd1926b1b 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define BXT_REVID_B0 0x3
#define BXT_REVID_B_LAST 0x8
#define BXT_REVID_C0 0x9
+#define BXT_REVID_D0 0xC
+#define BXT_REVID_E0 0xD
#define IS_BXT_REVID(dev_priv, since, until) \
(IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until))
@@ -2357,7 +2359,8 @@ static inline bool intel_scanout_needs_vtd_wa(struct drm_i915_private *dev_priv)
static inline bool
intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
{
- return IS_BROXTON(dev_priv) && intel_vtd_active();
+ /* Broxton steppings starting from E0 have fixed the bug. */
+ return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D0) && intel_vtd_active();
}
/* i915_drv.c */
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2019-08-14 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 7:54 dong.yang [this message]
2019-08-14 8:22 ` ✓ Fi.CI.BAT: success for drm/i915: Remove i915 ggtt WA since GT E0 (rev2) Patchwork
2019-08-14 8:53 ` [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 Chris Wilson
2019-08-14 12:07 ` Joonas Lahtinen
2019-08-14 18:46 ` ✗ Fi.CI.IGT: failure for drm/i915: Remove i915 ggtt WA since GT E0 (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-08-15 1:03 [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 dong.yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814075405.16822-1-dong.yang@intel.com \
--to=dong.yang@intel.com \
--cc=Yang@freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox