public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0
@ 2019-08-14  7:54 dong.yang
  2019-08-14  8:22 ` ✓ Fi.CI.BAT: success for drm/i915: Remove i915 ggtt WA since GT E0 (rev2) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: dong.yang @ 2019-08-14  7:54 UTC (permalink / raw)
  To: intel-gfx; +Cc: Yang

From: "Yang, Dong" <dong.yang@intel.com>

Broxton steppings starting from GT E0 have fixed the bug, remove
WA since stepping GT E0.

v2: add comment in code, by:
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Signed-off-by: Yang, Dong <dong.yang@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5f3e5c13fbaa..a0dfd1926b1b 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
 #define BXT_REVID_B0		0x3
 #define BXT_REVID_B_LAST	0x8
 #define BXT_REVID_C0		0x9
+#define BXT_REVID_D0		0xC
+#define BXT_REVID_E0		0xD
 
 #define IS_BXT_REVID(dev_priv, since, until) \
 	(IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until))
@@ -2357,7 +2359,8 @@ static inline bool intel_scanout_needs_vtd_wa(struct drm_i915_private *dev_priv)
 static inline bool
 intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
 {
-	return IS_BROXTON(dev_priv) && intel_vtd_active();
+	/* Broxton steppings starting from E0 have fixed the bug. */
+	return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D0) && intel_vtd_active();
 }
 
 /* i915_drv.c */
-- 
2.22.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0
@ 2019-08-15  1:03 dong.yang
  0 siblings, 0 replies; 6+ messages in thread
From: dong.yang @ 2019-08-15  1:03 UTC (permalink / raw)
  To: intel-gfx; +Cc: Yang

From: "Yang, Dong" <dong.yang@intel.com>

Broxton steppings starting from GT E0 have fixed the bug, remove
WA since stepping GT E0.

v2: use BXT_REVID_D_LAST replace BXT_REVID_D0, by:
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Signed-off-by: Yang, Dong <dong.yang@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5f3e5c13fbaa..b1cda9dcbea4 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
 #define BXT_REVID_B0		0x3
 #define BXT_REVID_B_LAST	0x8
 #define BXT_REVID_C0		0x9
+#define BXT_REVID_D_LAST	0xC
+#define BXT_REVID_E0		0xD
 
 #define IS_BXT_REVID(dev_priv, since, until) \
 	(IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until))
@@ -2357,7 +2359,7 @@ static inline bool intel_scanout_needs_vtd_wa(struct drm_i915_private *dev_priv)
 static inline bool
 intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
 {
-	return IS_BROXTON(dev_priv) && intel_vtd_active();
+	return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D_LAST) && intel_vtd_active();
 }
 
 /* i915_drv.c */
-- 
2.22.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-15  1:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-14  7:54 [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 dong.yang
2019-08-14  8:22 ` ✓ Fi.CI.BAT: success for drm/i915: Remove i915 ggtt WA since GT E0 (rev2) Patchwork
2019-08-14  8:53 ` [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 Chris Wilson
2019-08-14 12:07 ` Joonas Lahtinen
2019-08-14 18:46 ` ✗ Fi.CI.IGT: failure for drm/i915: Remove i915 ggtt WA since GT E0 (rev2) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2019-08-15  1:03 [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 dong.yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox