* [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 @ 2019-08-15 1:03 dong.yang 2019-08-15 1:42 ` ✓ Fi.CI.BAT: success for drm/i915: Remove i915 ggtt WA since GT E0 (rev3) Patchwork 2019-08-15 19:29 ` ✓ Fi.CI.IGT: " Patchwork 0 siblings, 2 replies; 6+ messages in thread From: dong.yang @ 2019-08-15 1:03 UTC (permalink / raw) To: intel-gfx; +Cc: Yang From: "Yang, Dong" <dong.yang@intel.com> Broxton steppings starting from GT E0 have fixed the bug, remove WA since stepping GT E0. v2: use BXT_REVID_D_LAST replace BXT_REVID_D0, by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Signed-off-by: Yang, Dong <dong.yang@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 5f3e5c13fbaa..b1cda9dcbea4 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, #define BXT_REVID_B0 0x3 #define BXT_REVID_B_LAST 0x8 #define BXT_REVID_C0 0x9 +#define BXT_REVID_D_LAST 0xC +#define BXT_REVID_E0 0xD #define IS_BXT_REVID(dev_priv, since, until) \ (IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until)) @@ -2357,7 +2359,7 @@ static inline bool intel_scanout_needs_vtd_wa(struct drm_i915_private *dev_priv) static inline bool intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv) { - return IS_BROXTON(dev_priv) && intel_vtd_active(); + return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D_LAST) && intel_vtd_active(); } /* i915_drv.c */ -- 2.22.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Remove i915 ggtt WA since GT E0 (rev3) 2019-08-15 1:03 [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 dong.yang @ 2019-08-15 1:42 ` Patchwork 2019-08-15 19:29 ` ✓ Fi.CI.IGT: " Patchwork 1 sibling, 0 replies; 6+ messages in thread From: Patchwork @ 2019-08-15 1:42 UTC (permalink / raw) To: dong.yang; +Cc: intel-gfx == Series Details == Series: drm/i915: Remove i915 ggtt WA since GT E0 (rev3) URL : https://patchwork.freedesktop.org/series/65160/ State : success == Summary == CI Bug Log - changes from CI_DRM_6710 -> Patchwork_14021 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/ Known issues ------------ Here are the changes found in Patchwork_14021 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_create@basic-files: - fi-cml-u2: [PASS][1] -> [INCOMPLETE][2] ([fdo#110566]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/fi-cml-u2/igt@gem_ctx_create@basic-files.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/fi-cml-u2/igt@gem_ctx_create@basic-files.html * igt@gem_ctx_switch@legacy-render: - fi-apl-guc: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/fi-apl-guc/igt@gem_ctx_switch@legacy-render.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/fi-apl-guc/igt@gem_ctx_switch@legacy-render.html * igt@gem_tiled_pread_basic: - fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/fi-icl-u3/igt@gem_tiled_pread_basic.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/fi-icl-u3/igt@gem_tiled_pread_basic.html #### Possible fixes #### * igt@i915_selftest@live_mman: - fi-bsw-n3050: [DMESG-WARN][7] ([fdo#111373]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/fi-bsw-n3050/igt@i915_selftest@live_mman.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/fi-bsw-n3050/igt@i915_selftest@live_mman.html * igt@kms_busy@basic-flip-a: - fi-kbl-7567u: [SKIP][9] ([fdo#109271] / [fdo#109278]) -> [PASS][10] +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566 [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [fdo#111373]: https://bugs.freedesktop.org/show_bug.cgi?id=111373 Participating hosts (53 -> 43) ------------------------------ Additional (1): fi-kbl-8809g Missing (11): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-bxt-j4205 fi-icl-y fi-icl-guc fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6710 -> Patchwork_14021 CI-20190529: 20190529 CI_DRM_6710: 131c6ccdf21739498689f22c973b1b77660ae7b9 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5134: 81df2f22385bc275975cf199d962eed9bc10f916 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14021: 11198b10be6d7f769e87efb1dc73cd63683bc9b5 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 11198b10be6d drm/i915: Remove i915 ggtt WA since GT E0 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Remove i915 ggtt WA since GT E0 (rev3) 2019-08-15 1:03 [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 dong.yang 2019-08-15 1:42 ` ✓ Fi.CI.BAT: success for drm/i915: Remove i915 ggtt WA since GT E0 (rev3) Patchwork @ 2019-08-15 19:29 ` Patchwork 1 sibling, 0 replies; 6+ messages in thread From: Patchwork @ 2019-08-15 19:29 UTC (permalink / raw) To: dong.yang; +Cc: intel-gfx == Series Details == Series: drm/i915: Remove i915 ggtt WA since GT E0 (rev3) URL : https://patchwork.freedesktop.org/series/65160/ State : success == Summary == CI Bug Log - changes from CI_DRM_6710_full -> Patchwork_14021_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_14021_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb2/igt@gem_exec_balancer@smoke.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb6/igt@gem_exec_balancer@smoke.html * igt@gem_exec_reloc@basic-wc-active: - shard-skl: [PASS][3] -> [DMESG-WARN][4] ([fdo#106107]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-skl2/igt@gem_exec_reloc@basic-wc-active.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-skl9/igt@gem_exec_reloc@basic-wc-active.html * igt@gem_exec_schedule@preempt-queue-bsd: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd.html * igt@gem_tiled_swapping@non-threaded: - shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108686]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-apl1/igt@gem_tiled_swapping@non-threaded.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-apl4/igt@gem_tiled_swapping@non-threaded.html * igt@i915_pm_rpm@dpms-mode-unset-lpsp: - shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([fdo#107713] / [fdo#108840]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb5/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb1/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html * igt@kms_flip@2x-plain-flip-fb-recreate: - shard-glk: [PASS][11] -> [FAIL][12] ([fdo#100368]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-glk8/igt@kms_flip@2x-plain-flip-fb-recreate.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-glk3/igt@kms_flip@2x-plain-flip-fb-recreate.html * igt@kms_flip@dpms-vs-vblank-race-interruptible: - shard-glk: [PASS][13] -> [FAIL][14] ([fdo#103060]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-glk6/igt@kms_flip@dpms-vs-vblank-race-interruptible.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-glk9/igt@kms_flip@dpms-vs-vblank-race-interruptible.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][15] -> [FAIL][16] ([fdo#105363]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-kbl: [PASS][17] -> [INCOMPLETE][18] ([fdo#103665]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw: - shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#103167]) +4 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-apl: [PASS][21] -> [DMESG-WARN][22] ([fdo#108566]) +3 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-apl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-iclb: [PASS][23] -> [INCOMPLETE][24] ([fdo#107713] / [fdo#110042]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [fdo#110403]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103166]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +2 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb2/igt@kms_psr@psr2_cursor_render.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb5/igt@kms_psr@psr2_cursor_render.html * igt@kms_vblank@pipe-b-accuracy-idle: - shard-apl: [PASS][31] -> [INCOMPLETE][32] ([fdo#103927]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-apl2/igt@kms_vblank@pipe-b-accuracy-idle.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-apl1/igt@kms_vblank@pipe-b-accuracy-idle.html * igt@prime_vgem@fence-wait-bsd2: - shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109276]) +12 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb5/igt@prime_vgem@fence-wait-bsd2.html #### Possible fixes #### * igt@gem_ctx_isolation@vcs1-none: - shard-iclb: [SKIP][35] ([fdo#109276]) -> [PASS][36] +3 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb8/igt@gem_ctx_isolation@vcs1-none.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html * igt@gem_eio@reset-stress: - shard-snb: [FAIL][37] ([fdo#109661]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-snb2/igt@gem_eio@reset-stress.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-snb7/igt@gem_eio@reset-stress.html * igt@gem_exec_schedule@deep-bsd: - shard-iclb: [SKIP][39] ([fdo#111325]) -> [PASS][40] +4 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb1/igt@gem_exec_schedule@deep-bsd.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb8/igt@gem_exec_schedule@deep-bsd.html * igt@gem_softpin@noreloc-s3: - shard-skl: [INCOMPLETE][41] ([fdo#104108]) -> [PASS][42] +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-skl3/igt@gem_softpin@noreloc-s3.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-skl1/igt@gem_softpin@noreloc-s3.html * igt@gem_tiled_swapping@non-threaded: - shard-glk: [DMESG-WARN][43] ([fdo#108686]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-glk5/igt@gem_tiled_swapping@non-threaded.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-glk8/igt@gem_tiled_swapping@non-threaded.html * igt@kms_flip@plain-flip-ts-check: - shard-skl: [FAIL][45] ([fdo#100368]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-skl8/igt@kms_flip@plain-flip-ts-check.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-skl9/igt@kms_flip@plain-flip-ts-check.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite: - shard-iclb: [FAIL][47] ([fdo#103167]) -> [PASS][48] +4 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite: - shard-snb: [SKIP][49] ([fdo#109271]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-snb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-snb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping: - shard-iclb: [INCOMPLETE][51] ([fdo#107713] / [fdo#110036 ]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb7/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb2/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes: - shard-apl: [DMESG-WARN][53] ([fdo#108566]) -> [PASS][54] +1 similar issue [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-iclb: [INCOMPLETE][55] ([fdo#107713] / [fdo#110042]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_psr@psr2_dpms: - shard-iclb: [SKIP][57] ([fdo#109441]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb4/igt@kms_psr@psr2_dpms.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb2/igt@kms_psr@psr2_dpms.html * igt@perf@blocking: - shard-skl: [FAIL][59] ([fdo#110728]) -> [PASS][60] +1 similar issue [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-skl1/igt@perf@blocking.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-skl3/igt@perf@blocking.html #### Warnings #### * igt@gem_mocs_settings@mocs-rc6-bsd2: - shard-iclb: [SKIP][61] ([fdo#109276]) -> [FAIL][62] ([fdo#111330]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb8/igt@gem_mocs_settings@mocs-rc6-bsd2.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb1/igt@gem_mocs_settings@mocs-rc6-bsd2.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][63] ([fdo#109349]) -> [DMESG-WARN][64] ([fdo#107724]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6710/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686 [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661 [fdo#110036 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110036 [fdo#110042]: https://bugs.freedesktop.org/show_bug.cgi?id=110042 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6710 -> Patchwork_14021 CI-20190529: 20190529 CI_DRM_6710: 131c6ccdf21739498689f22c973b1b77660ae7b9 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5134: 81df2f22385bc275975cf199d962eed9bc10f916 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14021: 11198b10be6d7f769e87efb1dc73cd63683bc9b5 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14021/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 @ 2019-08-14 7:54 dong.yang 2019-08-14 8:53 ` Chris Wilson 2019-08-14 12:07 ` Joonas Lahtinen 0 siblings, 2 replies; 6+ messages in thread From: dong.yang @ 2019-08-14 7:54 UTC (permalink / raw) To: intel-gfx; +Cc: Yang From: "Yang, Dong" <dong.yang@intel.com> Broxton steppings starting from GT E0 have fixed the bug, remove WA since stepping GT E0. v2: add comment in code, by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Signed-off-by: Yang, Dong <dong.yang@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 5f3e5c13fbaa..a0dfd1926b1b 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, #define BXT_REVID_B0 0x3 #define BXT_REVID_B_LAST 0x8 #define BXT_REVID_C0 0x9 +#define BXT_REVID_D0 0xC +#define BXT_REVID_E0 0xD #define IS_BXT_REVID(dev_priv, since, until) \ (IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until)) @@ -2357,7 +2359,8 @@ static inline bool intel_scanout_needs_vtd_wa(struct drm_i915_private *dev_priv) static inline bool intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv) { - return IS_BROXTON(dev_priv) && intel_vtd_active(); + /* Broxton steppings starting from E0 have fixed the bug. */ + return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D0) && intel_vtd_active(); } /* i915_drv.c */ -- 2.22.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 2019-08-14 7:54 [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 dong.yang @ 2019-08-14 8:53 ` Chris Wilson 2019-08-14 12:07 ` Joonas Lahtinen 1 sibling, 0 replies; 6+ messages in thread From: Chris Wilson @ 2019-08-14 8:53 UTC (permalink / raw) To: dong.yang, intel-gfx; +Cc: Yang Quoting dong.yang@intel.com (2019-08-14 08:54:05) > From: "Yang, Dong" <dong.yang@intel.com> > > Broxton steppings starting from GT E0 have fixed the bug, remove > WA since stepping GT E0. If you have a supply of these, could you arrange for one to be put into CI. We have no coverage of bxt-iommu to assess your claim. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 2019-08-14 7:54 [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 dong.yang 2019-08-14 8:53 ` Chris Wilson @ 2019-08-14 12:07 ` Joonas Lahtinen 1 sibling, 0 replies; 6+ messages in thread From: Joonas Lahtinen @ 2019-08-14 12:07 UTC (permalink / raw) To: dong.yang, intel-gfx; +Cc: Yang Quoting dong.yang@intel.com (2019-08-14 10:54:05) > From: "Yang, Dong" <dong.yang@intel.com> > > Broxton steppings starting from GT E0 have fixed the bug, remove > WA since stepping GT E0. > > v2: add comment in code, by: > Joonas Lahtinen <joonas.lahtinen@linux.intel.com> I didn't suggest any comments, I suggested to change the code. > > Signed-off-by: Yang, Dong <dong.yang@intel.com> > --- > drivers/gpu/drm/i915/i915_drv.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 5f3e5c13fbaa..a0dfd1926b1b 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, > #define BXT_REVID_B0 0x3 > #define BXT_REVID_B_LAST 0x8 > #define BXT_REVID_C0 0x9 > +#define BXT_REVID_D0 0xC > +#define BXT_REVID_E0 0xD > > #define IS_BXT_REVID(dev_priv, since, until) \ > (IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until)) > @@ -2357,7 +2359,8 @@ static inline bool intel_scanout_needs_vtd_wa(struct drm_i915_private *dev_priv) > static inline bool > intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv) > { > - return IS_BROXTON(dev_priv) && intel_vtd_active(); > + /* Broxton steppings starting from E0 have fixed the bug. */ This comment is not needed. I suggested using BXT_REVID_D_LAST define instead of D0. Regards, Joonas _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-15 19:29 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-08-15 1:03 [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 dong.yang 2019-08-15 1:42 ` ✓ Fi.CI.BAT: success for drm/i915: Remove i915 ggtt WA since GT E0 (rev3) Patchwork 2019-08-15 19:29 ` ✓ Fi.CI.IGT: " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2019-08-14 7:54 [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0 dong.yang 2019-08-14 8:53 ` Chris Wilson 2019-08-14 12:07 ` Joonas Lahtinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox