✗ Fi.CI.CHECKPATCH: warning for series starting with [01/28] drm/i915/selftests: Add the usual batch vma managements to st_workarounds

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: series starting with [01/28] drm/i915/selftests: Add the usual batch vma managements to st_workarounds
URL   : https://patchwork.freedesktop.org/series/65785/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c46feb50a4b3 drm/i915/selftests: Add the usual batch vma managements to st_workarounds
d8a7398e45ac drm/i915/selftests: Remove accidental serialization between gpu_fill
6b9f45a2bc05 drm/i915/selftests: Try to recycle context allocations
d9c3cdfc9443 drm/i915/gtt: Downgrade Baytrail back to aliasing-ppgtt
9c4446789f7a drm/i915/gtt: Downgrade Cherryview back to aliasing-ppgtt
9d5ff6ed7063 drm/i915: Protect our local workers against I915_FENCE_TIMEOUT
b06fa86d555e drm/i915: Force PD reload on any PD update
6e00732fef73 drm/i915: Replace obj->pin_global with obj->frontbuffer
-:242: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#242: FILE: drivers/gpu/drm/i915/i915_debugfs.c:219:
+		seq_printf(m, " (fb)");

total: 0 errors, 1 warnings, 0 checks, 171 lines checked
c4b69b94331d dma-fence: Serialise signal enabling (dma_fence_enable_sw_signaling)
-:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked with dma_fence_signal")'
#14: 
See also 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked

total: 1 errors, 0 warnings, 0 checks, 24 lines checked
9b66ce0ad481 drm/mm: Pack allocated/scanned boolean into a bitfield
f6fd81297067 drm/i915: Make shrink/unshrink be atomic
2288b16c1bb7 drm/i915: Only track bound elements of the GTT
7dbc1e8e8b38 drm/i915: Make i915_vma.flags atomic_t for mutex reduction
baddd23cde7f drm/i915: Mark up address spaces that may need to allocate
04fb38398216 drm/i915: Pull i915_vma_pin under the vm->mutex
067dda6f4d10 drm/i915: Push the i915_active.retire into a worker
d2aff1d0ef1a drm/i915: Coordinate i915_active with its own mutex
-:1299: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#1299: FILE: drivers/gpu/drm/i915/i915_active_types.h:49:
+	struct mutex mutex;

total: 0 errors, 0 warnings, 1 checks, 1448 lines checked
aba79af808bb drm/i915: Move idle barrier cleanup into engine-pm
31ead25c61da drm/i915: Drop struct_mutex from around i915_retire_requests()
459bf1b2292e drm/i915: Merge wait_for_timelines with retire_request
b04562bce34d drm/i915: Serialise the fill BLT with the vma pinning
bafb3c675329 drm/i915/execlists: Always request completion before marking an error
086dedbef59f drm/i915: Only enqueue already completed requests
897e5de8863a drm/i915/execlists: Force preemption
3f19a88b00ea drm/i915: Mark up "sentinel" requests
4871b0180b24 drm/i915/execlists: Cancel banned contexts on schedule-out
bf80ea3a9801 drm/i915: Cancel non-persistent contexts on close
-:271: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#271: 
new file mode 100644

-:276: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#276: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:1:
+/*

-:277: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#277: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:2:
+ * SPDX-License-Identifier: MIT

-:336: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#336: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h:1:
+/*

-:337: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#337: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 312 lines checked
9131579e8ef2 drm/i915: Replace hangcheck by heartbeats
-:212: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'heartbeat', this function's name, in a string
#212: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:63:
+					  "%s heartbeat not ticking\n",

-:229: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'heartbeat', this function's name, in a string
#229: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:80:
+					      "stopped heartbeat on %s",

-:472: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#472: 
deleted file mode 100644

-:1145: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1145: FILE: drivers/gpu/drm/i915/i915_params.c:81:
+       "Periodically check GPU activity for detecting hangs. "$

-:1146: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1146: FILE: drivers/gpu/drm/i915/i915_params.c:82:
+       "WARNING: Disabling this can cause system wide hangs. "$

-:1147: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1147: FILE: drivers/gpu/drm/i915/i915_params.c:83:
+       "(default: true)");$

total: 0 errors, 6 warnings, 0 checks, 638 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx