Re: [PATCH 10/28] drm/mm: Pack allocated/scanned boolean into a bitfield

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3551 bytes --]

Hi Chris,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[cannot apply to v5.3-rc6 next-20190826]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-selftests-Add-the-usual-batch-vma-managements-to-st_workarounds/20190827-004721
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/vc4/vc4_crtc.c: In function 'vc4_crtc_destroy_state':
>> drivers/gpu/drm/vc4/vc4_crtc.c:997:19: error: 'struct drm_mm_node' has no member named 'allocated'
     if (vc4_state->mm.allocated) {
                      ^
--
   drivers/gpu/drm/vc4/vc4_plane.c: In function 'vc4_plane_destroy_state':
>> drivers/gpu/drm/vc4/vc4_plane.c:181:20: error: 'struct drm_mm_node' has no member named 'allocated'
     if (vc4_state->lbm.allocated) {
                       ^
   drivers/gpu/drm/vc4/vc4_plane.c: In function 'vc4_plane_allocate_lbm':
   drivers/gpu/drm/vc4/vc4_plane.c:560:21: error: 'struct drm_mm_node' has no member named 'allocated'
     if (!vc4_state->lbm.allocated) {
                        ^
--
   drivers/gpu/drm/vc4/vc4_hvs.c: In function 'vc4_hvs_unbind':
>> drivers/gpu/drm/vc4/vc4_hvs.c:318:41: error: 'struct drm_mm_node' has no member named 'allocated'
     if (vc4->hvs->mitchell_netravali_filter.allocated)
                                            ^

vim +997 drivers/gpu/drm/vc4/vc4_crtc.c

d8dbf44f13b911 Eric Anholt 2015-12-28   990  
d8dbf44f13b911 Eric Anholt 2015-12-28   991  static void vc4_crtc_destroy_state(struct drm_crtc *crtc,
d8dbf44f13b911 Eric Anholt 2015-12-28   992  				   struct drm_crtc_state *state)
d8dbf44f13b911 Eric Anholt 2015-12-28   993  {
d8dbf44f13b911 Eric Anholt 2015-12-28   994  	struct vc4_dev *vc4 = to_vc4_dev(crtc->dev);
d8dbf44f13b911 Eric Anholt 2015-12-28   995  	struct vc4_crtc_state *vc4_state = to_vc4_crtc_state(state);
d8dbf44f13b911 Eric Anholt 2015-12-28   996  
d8dbf44f13b911 Eric Anholt 2015-12-28  @997  	if (vc4_state->mm.allocated) {
d8dbf44f13b911 Eric Anholt 2015-12-28   998  		unsigned long flags;
d8dbf44f13b911 Eric Anholt 2015-12-28   999  
d8dbf44f13b911 Eric Anholt 2015-12-28  1000  		spin_lock_irqsave(&vc4->hvs->mm_lock, flags);
d8dbf44f13b911 Eric Anholt 2015-12-28  1001  		drm_mm_remove_node(&vc4_state->mm);
d8dbf44f13b911 Eric Anholt 2015-12-28  1002  		spin_unlock_irqrestore(&vc4->hvs->mm_lock, flags);
d8dbf44f13b911 Eric Anholt 2015-12-28  1003  
d8dbf44f13b911 Eric Anholt 2015-12-28  1004  	}
d8dbf44f13b911 Eric Anholt 2015-12-28  1005  
7622b255436655 Eric Anholt 2016-10-10  1006  	drm_atomic_helper_crtc_destroy_state(crtc, state);
d8dbf44f13b911 Eric Anholt 2015-12-28  1007  }
d8dbf44f13b911 Eric Anholt 2015-12-28  1008  

:::::: The code at line 997 was first introduced by commit
:::::: d8dbf44f13b91185c618219d912b246817a8d132 drm/vc4: Make the CRTCs cooperate on allocating display lists.

:::::: TO: Eric Anholt <eric@anholt.net>
:::::: CC: Eric Anholt <eric@anholt.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69533 bytes --]

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx