* [PATCH v2] drm/i915: add port info to debugfs
@ 2019-08-23 9:49 Simon Ser
2019-08-23 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Simon Ser @ 2019-08-23 9:49 UTC (permalink / raw)
To: intel-gfx; +Cc: Manasi Navare
This patch adds a line with the port name to connectors in
debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is
printed too.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Manasi Navare <nanasi.d.navare@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
---
Resending v2 to the correct mailing list.
drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index b39226d7f8d2..4ba508c954f8 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,
static void intel_connector_info(struct seq_file *m,
struct drm_connector *connector)
{
+ struct drm_i915_private *i915 = to_i915(connector->dev);
struct intel_connector *intel_connector = to_intel_connector(connector);
struct intel_encoder *intel_encoder = intel_connector->encoder;
struct drm_display_mode *mode;
+ enum tc_port tc_port;
seq_printf(m, "connector %d: type %s, status: %s\n",
connector->base.id, connector->name,
@@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m,
if (!intel_encoder)
return;
+ if (intel_encoder->port != PORT_NONE) {
+ seq_printf(m, "\tport: %c", port_name(intel_encoder->port));
+ tc_port = intel_port_to_tc(i915, intel_encoder->port);
+ if (tc_port != PORT_TC_NONE)
+ seq_printf(m, "/TC#%d", tc_port + 1);
+ seq_printf(m, "\n");
+ }
+
switch (connector->connector_type) {
case DRM_MODE_CONNECTOR_DisplayPort:
case DRM_MODE_CONNECTOR_eDP:
--
2.22.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add port info to debugfs 2019-08-23 9:49 [PATCH v2] drm/i915: add port info to debugfs Simon Ser @ 2019-08-23 14:36 ` Patchwork 2019-08-23 15:02 ` ✗ Fi.CI.BAT: failure " Patchwork ` (5 subsequent siblings) 6 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2019-08-23 14:36 UTC (permalink / raw) To: Ser, Simon; +Cc: intel-gfx == Series Details == Series: drm/i915: add port info to debugfs URL : https://patchwork.freedesktop.org/series/65695/ State : warning == Summary == $ dim checkpatch origin/drm-tip 69ae2eaab337 drm/i915: add port info to debugfs -:40: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf #40: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2593: + seq_printf(m, "\n"); total: 0 errors, 1 warnings, 0 checks, 25 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: add port info to debugfs 2019-08-23 9:49 [PATCH v2] drm/i915: add port info to debugfs Simon Ser 2019-08-23 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork @ 2019-08-23 15:02 ` Patchwork 2019-08-26 11:08 ` [PATCH v2] " Imre Deak ` (4 subsequent siblings) 6 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2019-08-23 15:02 UTC (permalink / raw) To: Ser, Simon; +Cc: intel-gfx == Series Details == Series: drm/i915: add port info to debugfs URL : https://patchwork.freedesktop.org/series/65695/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6777 -> Patchwork_14164 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_14164 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_14164, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14164/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_14164: ### IGT changes ### #### Possible regressions #### * igt@kms_chamelium@dp-edid-read: - fi-icl-u2: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14164/fi-icl-u2/igt@kms_chamelium@dp-edid-read.html Known issues ------------ Here are the changes found in Patchwork_14164 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s4-devices: - fi-blb-e6850: [PASS][2] -> [INCOMPLETE][3] ([fdo#107718]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6777/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14164/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html #### Possible fixes #### * igt@gem_ctx_switch@legacy-render: - fi-bxt-dsi: [INCOMPLETE][4] ([fdo#103927] / [fdo#111381]) -> [PASS][5] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6777/fi-bxt-dsi/igt@gem_ctx_switch@legacy-render.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14164/fi-bxt-dsi/igt@gem_ctx_switch@legacy-render.html * igt@i915_module_load@reload-with-fault-injection: - fi-hsw-4770r: [DMESG-WARN][6] ([fdo#107732]) -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6777/fi-hsw-4770r/igt@i915_module_load@reload-with-fault-injection.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14164/fi-hsw-4770r/igt@i915_module_load@reload-with-fault-injection.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732 [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673 [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045 [fdo#111049]: https://bugs.freedesktop.org/show_bug.cgi?id=111049 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381 [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 Participating hosts (53 -> 47) ------------------------------ Additional (2): fi-icl-u2 fi-gdg-551 Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6777 -> Patchwork_14164 CI-20190529: 20190529 CI_DRM_6777: f3035d74f2d44bab3dbc6673f6660b447cbefd54 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5148: 50390dd7adaccae21cafa85b866c17606cec94c3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14164: 69ae2eaab337c1d91004d44bc4c3585616f7f11c @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 69ae2eaab337 drm/i915: add port info to debugfs == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14164/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/i915: add port info to debugfs 2019-08-23 9:49 [PATCH v2] drm/i915: add port info to debugfs Simon Ser 2019-08-23 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2019-08-23 15:02 ` ✗ Fi.CI.BAT: failure " Patchwork @ 2019-08-26 11:08 ` Imre Deak 2019-08-26 16:38 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add port info to debugfs (rev2) Patchwork ` (3 subsequent siblings) 6 siblings, 0 replies; 10+ messages in thread From: Imre Deak @ 2019-08-26 11:08 UTC (permalink / raw) To: Simon Ser; +Cc: intel-gfx, Manasi Navare On Fri, Aug 23, 2019 at 12:49:46PM +0300, Simon Ser wrote: > This patch adds a line with the port name to connectors in > debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is > printed too. > > Signed-off-by: Simon Ser <simon.ser@intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Cc: Manasi Navare <nanasi.d.navare@intel.com> > Reviewed-by: Imre Deak <imre.deak@intel.com> > --- > > Resending v2 to the correct mailing list. Test results were dropped somewhere, there is one failure https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14164/fi-icl-u2/igt@kms_chamelium@dp-edid-read.html but it looks to be the unrelated https://bugs.freedesktop.org/show_bug.cgi?id=111474 I asked Lakshmi to update the cibug filter for the bug. > > drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index b39226d7f8d2..4ba508c954f8 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m, > static void intel_connector_info(struct seq_file *m, > struct drm_connector *connector) > { > + struct drm_i915_private *i915 = to_i915(connector->dev); > struct intel_connector *intel_connector = to_intel_connector(connector); > struct intel_encoder *intel_encoder = intel_connector->encoder; > struct drm_display_mode *mode; > + enum tc_port tc_port; > > seq_printf(m, "connector %d: type %s, status: %s\n", > connector->base.id, connector->name, > @@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m, > if (!intel_encoder) > return; > > + if (intel_encoder->port != PORT_NONE) { > + seq_printf(m, "\tport: %c", port_name(intel_encoder->port)); > + tc_port = intel_port_to_tc(i915, intel_encoder->port); > + if (tc_port != PORT_TC_NONE) > + seq_printf(m, "/TC#%d", tc_port + 1); > + seq_printf(m, "\n"); > + } > + > switch (connector->connector_type) { > case DRM_MODE_CONNECTOR_DisplayPort: > case DRM_MODE_CONNECTOR_eDP: > -- > 2.22.1 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add port info to debugfs (rev2) 2019-08-23 9:49 [PATCH v2] drm/i915: add port info to debugfs Simon Ser ` (2 preceding siblings ...) 2019-08-26 11:08 ` [PATCH v2] " Imre Deak @ 2019-08-26 16:38 ` Patchwork 2019-08-26 17:51 ` ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 6 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2019-08-26 16:38 UTC (permalink / raw) To: Ser, Simon; +Cc: intel-gfx == Series Details == Series: drm/i915: add port info to debugfs (rev2) URL : https://patchwork.freedesktop.org/series/65695/ State : warning == Summary == $ dim checkpatch origin/drm-tip fa91704a9919 drm/i915: add port info to debugfs -:40: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf #40: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2594: + seq_printf(m, "\n"); total: 0 errors, 1 warnings, 0 checks, 25 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: add port info to debugfs (rev2) 2019-08-23 9:49 [PATCH v2] drm/i915: add port info to debugfs Simon Ser ` (3 preceding siblings ...) 2019-08-26 16:38 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add port info to debugfs (rev2) Patchwork @ 2019-08-26 17:51 ` Patchwork 2019-08-28 16:40 ` [PATCH v2] drm/i915: add port info to debugfs Ville Syrjälä 2019-08-28 23:57 ` ✓ Fi.CI.IGT: success for drm/i915: add port info to debugfs (rev2) Patchwork 6 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2019-08-26 17:51 UTC (permalink / raw) To: Ser, Simon; +Cc: intel-gfx == Series Details == Series: drm/i915: add port info to debugfs (rev2) URL : https://patchwork.freedesktop.org/series/65695/ State : success == Summary == CI Bug Log - changes from CI_DRM_6786 -> Patchwork_14191 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/ Known issues ------------ Here are the changes found in Patchwork_14191 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@reload-no-display: - fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/fi-icl-u3/igt@i915_module_load@reload-no-display.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/fi-icl-u3/igt@i915_module_load@reload-no-display.html * igt@kms_frontbuffer_tracking@basic: - fi-icl-u3: [PASS][3] -> [FAIL][4] ([fdo#103167]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html #### Possible fixes #### * igt@gem_basic@create-close: - fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/fi-icl-u3/igt@gem_basic@create-close.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/fi-icl-u3/igt@gem_basic@create-close.html * igt@gem_exec_suspend@basic-s3: - fi-blb-e6850: [INCOMPLETE][7] ([fdo#107718]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live_execlists: - fi-skl-gvtdvm: [DMESG-FAIL][9] ([fdo#111108]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html #### Warnings #### * igt@kms_chamelium@hdmi-hpd-fast: - fi-icl-u2: [FAIL][11] ([fdo#111407]) -> [FAIL][12] ([fdo#109483]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483 [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108 [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 Participating hosts (53 -> 45) ------------------------------ Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6786 -> Patchwork_14191 CI-20190529: 20190529 CI_DRM_6786: bb5ca76098a53137d58613b37e44d1f18e11aad3 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5150: a4e8217bcdfef9bb523f26a9084bbf615a6e8abb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14191: fa91704a99190fc30bc601ded24cc7c9e244e908 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == fa91704a9919 drm/i915: add port info to debugfs == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/i915: add port info to debugfs 2019-08-23 9:49 [PATCH v2] drm/i915: add port info to debugfs Simon Ser ` (4 preceding siblings ...) 2019-08-26 17:51 ` ✓ Fi.CI.BAT: success " Patchwork @ 2019-08-28 16:40 ` Ville Syrjälä 2019-08-29 9:08 ` Ser, Simon 2019-08-28 23:57 ` ✓ Fi.CI.IGT: success for drm/i915: add port info to debugfs (rev2) Patchwork 6 siblings, 1 reply; 10+ messages in thread From: Ville Syrjälä @ 2019-08-28 16:40 UTC (permalink / raw) To: Simon Ser; +Cc: intel-gfx, Manasi Navare On Fri, Aug 23, 2019 at 12:49:46PM +0300, Simon Ser wrote: > This patch adds a line with the port name to connectors in > debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is > printed too. > > Signed-off-by: Simon Ser <simon.ser@intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Cc: Manasi Navare <nanasi.d.navare@intel.com> > Reviewed-by: Imre Deak <imre.deak@intel.com> > --- > > Resending v2 to the correct mailing list. > > drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index b39226d7f8d2..4ba508c954f8 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m, > static void intel_connector_info(struct seq_file *m, > struct drm_connector *connector) > { > + struct drm_i915_private *i915 = to_i915(connector->dev); > struct intel_connector *intel_connector = to_intel_connector(connector); > struct intel_encoder *intel_encoder = intel_connector->encoder; > struct drm_display_mode *mode; > + enum tc_port tc_port; > > seq_printf(m, "connector %d: type %s, status: %s\n", > connector->base.id, connector->name, > @@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m, > if (!intel_encoder) > return; > > + if (intel_encoder->port != PORT_NONE) { > + seq_printf(m, "\tport: %c", port_name(intel_encoder->port)); > + tc_port = intel_port_to_tc(i915, intel_encoder->port); > + if (tc_port != PORT_TC_NONE) > + seq_printf(m, "/TC#%d", tc_port + 1); > + seq_printf(m, "\n"); Maybe just print encoder->name instead? > + } > + > switch (connector->connector_type) { > case DRM_MODE_CONNECTOR_DisplayPort: > case DRM_MODE_CONNECTOR_eDP: > -- > 2.22.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/i915: add port info to debugfs 2019-08-28 16:40 ` [PATCH v2] drm/i915: add port info to debugfs Ville Syrjälä @ 2019-08-29 9:08 ` Ser, Simon 2019-08-29 10:29 ` Ville Syrjälä 0 siblings, 1 reply; 10+ messages in thread From: Ser, Simon @ 2019-08-29 9:08 UTC (permalink / raw) To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, nanasi.d.navare@intel.com On Wed, 2019-08-28 at 19:40 +0300, Ville Syrjälä wrote: > On Fri, Aug 23, 2019 at 12:49:46PM +0300, Simon Ser wrote: > > This patch adds a line with the port name to connectors in > > debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is > > printed too. > > > > Signed-off-by: Simon Ser <simon.ser@intel.com> > > Cc: Imre Deak <imre.deak@intel.com> > > Cc: Manasi Navare <nanasi.d.navare@intel.com> > > Reviewed-by: Imre Deak <imre.deak@intel.com> > > --- > > > > Resending v2 to the correct mailing list. > > > > drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > > index b39226d7f8d2..4ba508c954f8 100644 > > --- a/drivers/gpu/drm/i915/i915_debugfs.c > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > > @@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m, > > static void intel_connector_info(struct seq_file *m, > > struct drm_connector *connector) > > { > > + struct drm_i915_private *i915 = to_i915(connector->dev); > > struct intel_connector *intel_connector = to_intel_connector(connector); > > struct intel_encoder *intel_encoder = intel_connector->encoder; > > struct drm_display_mode *mode; > > + enum tc_port tc_port; > > > > seq_printf(m, "connector %d: type %s, status: %s\n", > > connector->base.id, connector->name, > > @@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m, > > if (!intel_encoder) > > return; > > > > + if (intel_encoder->port != PORT_NONE) { > > + seq_printf(m, "\tport: %c", port_name(intel_encoder->port)); > > + tc_port = intel_port_to_tc(i915, intel_encoder->port); > > + if (tc_port != PORT_TC_NONE) > > + seq_printf(m, "/TC#%d", tc_port + 1); > > + seq_printf(m, "\n"); > > Maybe just print encoder->name instead? It seems that for DisplayPort connectors, the encoder->name will be set to "DP <port name>". This misses the Type-C part, and we already expose the connector type. > > + } > > + > > switch (connector->connector_type) { > > case DRM_MODE_CONNECTOR_DisplayPort: > > case DRM_MODE_CONNECTOR_eDP: > > -- > > 2.22.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] drm/i915: add port info to debugfs 2019-08-29 9:08 ` Ser, Simon @ 2019-08-29 10:29 ` Ville Syrjälä 0 siblings, 0 replies; 10+ messages in thread From: Ville Syrjälä @ 2019-08-29 10:29 UTC (permalink / raw) To: Ser, Simon; +Cc: intel-gfx@lists.freedesktop.org, nanasi.d.navare@intel.com On Thu, Aug 29, 2019 at 09:08:54AM +0000, Ser, Simon wrote: > On Wed, 2019-08-28 at 19:40 +0300, Ville Syrjälä wrote: > > On Fri, Aug 23, 2019 at 12:49:46PM +0300, Simon Ser wrote: > > > This patch adds a line with the port name to connectors in > > > debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is > > > printed too. > > > > > > Signed-off-by: Simon Ser <simon.ser@intel.com> > > > Cc: Imre Deak <imre.deak@intel.com> > > > Cc: Manasi Navare <nanasi.d.navare@intel.com> > > > Reviewed-by: Imre Deak <imre.deak@intel.com> > > > --- > > > > > > Resending v2 to the correct mailing list. > > > > > > drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > > > index b39226d7f8d2..4ba508c954f8 100644 > > > --- a/drivers/gpu/drm/i915/i915_debugfs.c > > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > > > @@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m, > > > static void intel_connector_info(struct seq_file *m, > > > struct drm_connector *connector) > > > { > > > + struct drm_i915_private *i915 = to_i915(connector->dev); > > > struct intel_connector *intel_connector = to_intel_connector(connector); > > > struct intel_encoder *intel_encoder = intel_connector->encoder; > > > struct drm_display_mode *mode; > > > + enum tc_port tc_port; > > > > > > seq_printf(m, "connector %d: type %s, status: %s\n", > > > connector->base.id, connector->name, > > > @@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m, > > > if (!intel_encoder) > > > return; > > > > > > + if (intel_encoder->port != PORT_NONE) { > > > + seq_printf(m, "\tport: %c", port_name(intel_encoder->port)); > > > + tc_port = intel_port_to_tc(i915, intel_encoder->port); > > > + if (tc_port != PORT_TC_NONE) > > > + seq_printf(m, "/TC#%d", tc_port + 1); > > > + seq_printf(m, "\n"); > > > > Maybe just print encoder->name instead? > > It seems that for DisplayPort connectors, the encoder->name will be set > to "DP <port name>". This misses the Type-C part, and we already expose > the connector type. If the TC part is missing from the encoder name then it should be fixed. > > > > + } > > > + > > > switch (connector->connector_type) { > > > case DRM_MODE_CONNECTOR_DisplayPort: > > > case DRM_MODE_CONNECTOR_eDP: > > > -- > > > 2.22.1 > > > > > > _______________________________________________ > > > Intel-gfx mailing list > > > Intel-gfx@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: add port info to debugfs (rev2) 2019-08-23 9:49 [PATCH v2] drm/i915: add port info to debugfs Simon Ser ` (5 preceding siblings ...) 2019-08-28 16:40 ` [PATCH v2] drm/i915: add port info to debugfs Ville Syrjälä @ 2019-08-28 23:57 ` Patchwork 6 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2019-08-28 23:57 UTC (permalink / raw) To: Ser, Simon; +Cc: intel-gfx == Series Details == Series: drm/i915: add port info to debugfs (rev2) URL : https://patchwork.freedesktop.org/series/65695/ State : success == Summary == CI Bug Log - changes from CI_DRM_6786_full -> Patchwork_14191_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_14191_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@vcs1-dirty-create: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276]) +14 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb2/igt@gem_ctx_isolation@vcs1-dirty-create.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb8/igt@gem_ctx_isolation@vcs1-dirty-create.html * igt@gem_exec_schedule@preemptive-hang-bsd: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb7/igt@gem_exec_schedule@preemptive-hang-bsd.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [PASS][5] -> [FAIL][6] ([fdo#105363]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc: - shard-skl: [PASS][7] -> [FAIL][8] ([fdo#103167]) +2 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-skl9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-skl3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: - shard-iclb: [PASS][9] -> [FAIL][10] ([fdo#103167]) +3 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][11] -> [FAIL][12] ([fdo#108145] / [fdo#110403]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109642] / [fdo#111068]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb5/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_sprite_render: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb2/igt@kms_psr@psr2_sprite_render.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb5/igt@kms_psr@psr2_sprite_render.html * igt@kms_setmode@basic: - shard-hsw: [PASS][17] -> [FAIL][18] ([fdo#99912]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-hsw5/igt@kms_setmode@basic.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-hsw6/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-apl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-apl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@perf@blocking: - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#110728]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-skl8/igt@perf@blocking.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-skl5/igt@perf@blocking.html #### Possible fixes #### * igt@gem_busy@close-race: - shard-iclb: [INCOMPLETE][23] ([fdo#107713]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb4/igt@gem_busy@close-race.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb3/igt@gem_busy@close-race.html * igt@gem_ctx_isolation@vecs0-s3: - shard-apl: [DMESG-WARN][25] ([fdo#108566]) -> [PASS][26] +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-apl6/igt@gem_ctx_isolation@vecs0-s3.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-apl2/igt@gem_ctx_isolation@vecs0-s3.html * igt@gem_exec_schedule@reorder-wide-bsd: - shard-iclb: [SKIP][27] ([fdo#111325]) -> [PASS][28] +5 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb5/igt@gem_exec_schedule@reorder-wide-bsd.html * igt@kms_big_fb@yf-tiled-32bpp-rotate-90: - shard-apl: [INCOMPLETE][29] ([fdo#103927]) -> [PASS][30] +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-apl2/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-apl2/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc: - shard-iclb: [FAIL][31] ([fdo#103167]) -> [PASS][32] +7 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff: - shard-iclb: [INCOMPLETE][33] ([fdo#106978] / [fdo#107713]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][35] ([fdo#108145]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [SKIP][37] ([fdo#109441]) -> [PASS][38] +1 similar issue [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@prime_busy@after-bsd2: - shard-iclb: [SKIP][39] ([fdo#109276]) -> [PASS][40] +17 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb6/igt@prime_busy@after-bsd2.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb4/igt@prime_busy@after-bsd2.html #### Warnings #### * igt@gem_mocs_settings@mocs-rc6-bsd2: - shard-iclb: [SKIP][41] ([fdo#109276]) -> [FAIL][42] ([fdo#111330]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb8/igt@gem_mocs_settings@mocs-rc6-bsd2.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb4/igt@gem_mocs_settings@mocs-rc6-bsd2.html * igt@gem_mocs_settings@mocs-reset-bsd2: - shard-iclb: [FAIL][43] ([fdo#111330]) -> [SKIP][44] ([fdo#109276]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb4/igt@gem_mocs_settings@mocs-reset-bsd2.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb8/igt@gem_mocs_settings@mocs-reset-bsd2.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][45] ([fdo#109349]) -> [DMESG-WARN][46] ([fdo#107724]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6786/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (9 -> 10) ------------------------------ Additional (1): pig-glk-j5005 Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6786 -> Patchwork_14191 CI-20190529: 20190529 CI_DRM_6786: bb5ca76098a53137d58613b37e44d1f18e11aad3 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5150: a4e8217bcdfef9bb523f26a9084bbf615a6e8abb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14191: fa91704a99190fc30bc601ded24cc7c9e244e908 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14191/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-08-29 10:29 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-08-23 9:49 [PATCH v2] drm/i915: add port info to debugfs Simon Ser 2019-08-23 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2019-08-23 15:02 ` ✗ Fi.CI.BAT: failure " Patchwork 2019-08-26 11:08 ` [PATCH v2] " Imre Deak 2019-08-26 16:38 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add port info to debugfs (rev2) Patchwork 2019-08-26 17:51 ` ✓ Fi.CI.BAT: success " Patchwork 2019-08-28 16:40 ` [PATCH v2] drm/i915: add port info to debugfs Ville Syrjälä 2019-08-29 9:08 ` Ser, Simon 2019-08-29 10:29 ` Ville Syrjälä 2019-08-28 23:57 ` ✓ Fi.CI.IGT: success for drm/i915: add port info to debugfs (rev2) Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox