✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Prepare to split crtc state in uapi and hw state (rev2)

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: series starting with [1/4] drm/i915: Prepare to split crtc state in uapi and hw state (rev2)
URL   : https://patchwork.freedesktop.org/series/67227/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1368d49f2ac9 drm/i915: Prepare to split crtc state in uapi and hw state
-:2130: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#2130: FILE: drivers/gpu/drm/i915/display/intel_display.c:11264:
+	crtc_state->uapi.active = crtc_state->uapi.enable = true;

-:2837: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#2837: FILE: drivers/gpu/drm/i915/display/intel_display.c:16735:
+		crtc_state->hw.active = crtc_state->hw.enable =

-:4001: ERROR:CODE_INDENT: code indent should use tabs where possible
#4001: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211:
+^I^I^I^I          new_crtc_state->uapi.event);$

-:4001: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#4001: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211:
+		drm_crtc_arm_vblank_event(&crtc->base,
+				          new_crtc_state->uapi.event);

total: 1 errors, 0 warnings, 3 checks, 4371 lines checked
e3721d7eec35 drm/i915: Handle a few more cases for hw/sw split
4e6a21fdedd8 drm/i915: Complete sw/hw split, v2.
-:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15: 
- Clear crtc_state->hw on disable, instead of using clear_intel_crtc_state().

total: 0 errors, 1 warnings, 0 checks, 204 lines checked
a971c9fd2236 drm/i915: Remove begin/finish_crtc_commit, v3.
-:191: ERROR:CODE_INDENT: code indent should use tabs where possible
#191: FILE: drivers/gpu/drm/i915/display/intel_display.c:13821:
+        /*$

-:192: ERROR:CODE_INDENT: code indent should use tabs where possible
#192: FILE: drivers/gpu/drm/i915/display/intel_display.c:13822:
+         * We usually enable FIFO underrun interrupts as part of the$

-:193: ERROR:CODE_INDENT: code indent should use tabs where possible
#193: FILE: drivers/gpu/drm/i915/display/intel_display.c:13823:
+         * CRTC enable sequence during modesets.  But when we inherit a$

-:194: ERROR:CODE_INDENT: code indent should use tabs where possible
#194: FILE: drivers/gpu/drm/i915/display/intel_display.c:13824:
+         * valid pipe configuration from the BIOS we need to take care$

-:195: ERROR:CODE_INDENT: code indent should use tabs where possible
#195: FILE: drivers/gpu/drm/i915/display/intel_display.c:13825:
+         * of enabling them on the CRTC's first fastset.$

-:196: ERROR:CODE_INDENT: code indent should use tabs where possible
#196: FILE: drivers/gpu/drm/i915/display/intel_display.c:13826:
+         */$

total: 6 errors, 0 warnings, 0 checks, 247 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx