public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Matthew Auld <matthew.auld@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for LMEM basics (rev2)
Date: Thu, 03 Oct 2019 22:11:31 -0000	[thread overview]
Message-ID: <20191003221131.3221.78039@emeril.freedesktop.org> (raw)
In-Reply-To: <20191003192444.10113-1-matthew.auld@intel.com>

== Series Details ==

Series: LMEM basics (rev2)
URL   : https://patchwork.freedesktop.org/series/67350/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
617461d66e9a drm/i915/stolen: make the object creation interface consistent
-:89: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!obj"
#89: FILE: drivers/gpu/drm/i915/gem/i915_gem_stolen.c:602:
+	if (obj == NULL) {

total: 0 errors, 0 warnings, 1 checks, 145 lines checked
26e73b4fb28d drm/i915: introduce intel_memory_region
-:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

-:577: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_memory_region *' should also have an identifier name
#577: FILE: drivers/gpu/drm/i915/intel_memory_region.h:26:
+	int (*init)(struct intel_memory_region *);

-:578: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_memory_region *' should also have an identifier name
#578: FILE: drivers/gpu/drm/i915/intel_memory_region.h:27:
+	void (*release)(struct intel_memory_region *);

-:580: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_memory_region *' should also have an identifier name
#580: FILE: drivers/gpu/drm/i915/intel_memory_region.h:29:
+	struct drm_i915_gem_object *

-:580: WARNING:FUNCTION_ARGUMENTS: function definition argument 'resource_size_t' should also have an identifier name
#580: FILE: drivers/gpu/drm/i915/intel_memory_region.h:29:
+	struct drm_i915_gem_object *

-:580: WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name
#580: FILE: drivers/gpu/drm/i915/intel_memory_region.h:29:
+	struct drm_i915_gem_object *

-:595: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#595: FILE: drivers/gpu/drm/i915/intel_memory_region.h:44:
+	struct mutex mm_lock;

-:616: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#616: FILE: drivers/gpu/drm/i915/intel_memory_region.h:65:
+__intel_memory_region_get_block_buddy(struct intel_memory_region *mem,
+				     resource_size_t size,

-:619: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#619: FILE: drivers/gpu/drm/i915/intel_memory_region.h:68:
+void __intel_memory_region_put_pages_buddy(struct intel_memory_region *mem,
+					  struct list_head *blocks);

-:727: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'igt_mock_fill', this function's name, in a string
#727: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:78:
+			pr_err("igt_mock_fill failed, space still left in region\n");

total: 0 errors, 7 warnings, 3 checks, 773 lines checked
00c236d8b5a6 drm/i915/region: support contiguous allocations
-:291: WARNING:LINE_SPACING: Missing a blank line after declarations
#291: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:131:
+	LIST_HEAD(holes);
+	I915_RND_STATE(prng);

total: 0 errors, 1 warnings, 0 checks, 372 lines checked
b68b1af935fc drm/i915/region: support volatile objects
7aa479268146 drm/i915: Add memory region information to device_info
e89ff1eeb7bc drm/i915: support creating LMEM objects
-:35: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

-:117: WARNING:TYPO_SPELLING: 'UKNOWN' may be misspelled - perhaps 'UNKNOWN'?
#117: FILE: drivers/gpu/drm/i915/i915_drv.h:684:
+	struct intel_memory_region *regions[INTEL_MEMORY_UKNOWN];

-:139: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#139: FILE: drivers/gpu/drm/i915/intel_memory_region.c:10:
+#define REGION_MAP(type, inst) \
+	BIT((type) + INTEL_MEMORY_TYPE_SHIFT) | BIT(inst)

-:172: WARNING:TYPO_SPELLING: 'UKNOWN' may be misspelled - perhaps 'UNKNOWN'?
#172: FILE: drivers/gpu/drm/i915/intel_memory_region.h:34:
+	INTEL_MEMORY_UKNOWN, /* Should be last */

-:181: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'r' may be better as '(r)' to avoid precedence issues
#181: FILE: drivers/gpu/drm/i915/intel_memory_region.h:43:
+#define MEMORY_TYPE_FROM_REGION(r) (ilog2(r >> INTEL_MEMORY_TYPE_SHIFT))

-:182: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'r' may be better as '(r)' to avoid precedence issues
#182: FILE: drivers/gpu/drm/i915/intel_memory_region.h:44:
+#define MEMORY_INSTANCE_FROM_REGION(r) (ilog2(r & 0xffff))

total: 1 errors, 3 warnings, 2 checks, 269 lines checked
141deddcedec drm/i915: setup io-mapping for LMEM
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 34 lines checked
22b5c737a2e5 drm/i915/lmem: support kernel mapping
-:200: WARNING:LINE_SPACING: Missing a blank line after declarations
#200: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:283:
+	struct drm_i915_gem_object *obj;
+	I915_RND_STATE(prng);

total: 0 errors, 1 warnings, 0 checks, 276 lines checked
8b2329a12640 drm/i915/selftests: add write-dword test for LMEM
-:19: CHECK:LINE_SPACING: Please don't use multiple blank lines
#19: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:10:
 
+

-:88: WARNING:LINE_SPACING: Missing a blank line after declarations
#88: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:313:
+	struct intel_context *ce;
+	I915_RND_STATE(prng);

-:168: WARNING:LINE_SPACING: Missing a blank line after declarations
#168: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:407:
+	struct drm_file *file;
+	I915_RND_STATE(prng);

total: 0 errors, 2 warnings, 1 checks, 202 lines checked
a086cd8917d0 drm/i915/selftests: extend coverage to include LMEM huge-pages
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 151 lines checked
874fcc02b951 drm/i915: enumerate and init each supported region
69d9fee29592 drm/i915: treat shmem as a region
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:116: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#116: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:443:
+static int __create_shmem(struct drm_i915_private *i915,
 			struct drm_gem_object *obj,

-:128: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#128: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:466:
+	     unsigned flags)

-:190: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#190: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:590:
+	if (err)
+		 DRM_NOTE("Unable to create a private tmpfs mount, hugepage support will be disabled(%d).\n", err);

-:191: WARNING:LONG_LINE: line over 100 characters
#191: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:591:
+		 DRM_NOTE("Unable to create a private tmpfs mount, hugepage support will be disabled(%d).\n", err);

total: 0 errors, 4 warnings, 1 checks, 346 lines checked
dd23d57731f5 drm/i915: treat stolen as a region
-:108: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#108: FILE: drivers/gpu/drm/i915/gem/i915_gem_stolen.c:630:
+{
+

total: 0 errors, 0 warnings, 1 checks, 176 lines checked
d16cdaa6c6e7 drm/i915: define HAS_MAPPABLE_APERTURE
-:20: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'dev_priv' may be better as '(dev_priv)' to avoid precedence issues
#20: FILE: drivers/gpu/drm/i915/i915_drv.h:2122:
+#define HAS_MAPPABLE_APERTURE(dev_priv) (dev_priv->ggtt.mappable_end > 0)

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
cc9d79ef7bd0 drm/i915: do not map aperture if it is not available.
-:38: CHECK:SPACING: No space is necessary after a cast
#38: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:3046:
+			(struct resource) DEFINE_RES_MEM(pci_resource_start(pdev, 2),

total: 0 errors, 0 warnings, 1 checks, 53 lines checked
908263a2b6a3 drm/i915: set num_fence_regs to 0 if there is no aperture
b3003a848d99 drm/i915: error capture with no ggtt slot
-:175: WARNING:LINE_SPACING: Missing a blank line after declarations
#175: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:1720:
+		const u64 slot = ggtt->error_capture.start;
+		ggtt->vm.clear_range(&ggtt->vm, slot, PAGE_SIZE);

total: 0 errors, 1 warnings, 0 checks, 149 lines checked
9f8c8b13f035 drm/i915: Don't try to place HWS in non-existing mappable region
f38b0f688e31 drm/i915: don't allocate the ring in stolen if we lack aperture
c2ea0b63ac44 drm/i915/selftests: fallback to using the gpu to trash stolen
9a338d43fab2 drm/i915/selftests: check for missing aperture
5d9f53513a22 HAX drm/i915: add the fake lmem region
-:49: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
#49: FILE: arch/x86/kernel/early-quirks.c:624:
+	printk(KERN_INFO "Intel graphics fake LMEM starts at %pa\n",

total: 0 errors, 1 warnings, 0 checks, 228 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-03 22:11 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 19:24 [PATCH v2 00/22] LMEM basics Matthew Auld
2019-10-03 19:24 ` [PATCH v2 01/22] drm/i915/stolen: make the object creation interface consistent Matthew Auld
2019-10-03 19:29   ` Chris Wilson
2019-10-03 19:24 ` [PATCH v2 02/22] drm/i915: introduce intel_memory_region Matthew Auld
2019-10-03 19:24 ` [PATCH v2 03/22] drm/i915/region: support contiguous allocations Matthew Auld
2019-10-03 19:24 ` [PATCH v2 04/22] drm/i915/region: support volatile objects Matthew Auld
2019-10-03 19:40   ` Chris Wilson
2019-10-03 19:24 ` [PATCH v2 05/22] drm/i915: Add memory region information to device_info Matthew Auld
2019-10-03 19:24 ` [PATCH v2 06/22] drm/i915: support creating LMEM objects Matthew Auld
2019-10-03 19:46   ` Chris Wilson
2019-10-03 19:24 ` [PATCH v2 07/22] drm/i915: setup io-mapping for LMEM Matthew Auld
2019-10-03 19:24 ` [PATCH v2 08/22] drm/i915/lmem: support kernel mapping Matthew Auld
2019-10-03 19:48   ` Chris Wilson
2019-10-03 19:24 ` [PATCH v2 09/22] drm/i915/selftests: add write-dword test for LMEM Matthew Auld
2019-10-03 19:24 ` [PATCH v2 10/22] drm/i915/selftests: extend coverage to include LMEM huge-pages Matthew Auld
2019-10-03 19:24 ` [PATCH v2 11/22] drm/i915: enumerate and init each supported region Matthew Auld
2019-10-03 19:24 ` [PATCH v2 12/22] drm/i915: treat shmem as a region Matthew Auld
2019-10-03 19:24 ` [PATCH v2 13/22] drm/i915: treat stolen " Matthew Auld
2019-10-03 19:43   ` Tang, CQ
2019-10-03 19:24 ` [PATCH v2 14/22] drm/i915: define HAS_MAPPABLE_APERTURE Matthew Auld
2019-10-03 19:53   ` Chris Wilson
2019-10-03 19:24 ` [PATCH v2 15/22] drm/i915: do not map aperture if it is not available Matthew Auld
2019-10-03 19:24 ` [PATCH v2 16/22] drm/i915: set num_fence_regs to 0 if there is no aperture Matthew Auld
2019-10-03 19:24 ` [PATCH v2 17/22] drm/i915: error capture with no ggtt slot Matthew Auld
2019-10-03 19:24 ` [PATCH v2 18/22] drm/i915: Don't try to place HWS in non-existing mappable region Matthew Auld
2019-10-03 19:24 ` [PATCH v2 19/22] drm/i915: don't allocate the ring in stolen if we lack aperture Matthew Auld
2019-10-03 19:37   ` Tang, CQ
2019-10-03 19:55   ` Chris Wilson
2019-10-03 19:24 ` [PATCH v2 20/22] drm/i915/selftests: fallback to using the gpu to trash stolen Matthew Auld
2019-10-03 20:02   ` Chris Wilson
2019-10-03 19:24 ` [PATCH v2 21/22] drm/i915/selftests: check for missing aperture Matthew Auld
2019-10-03 19:24 ` [PATCH v2 22/22] HAX drm/i915: add the fake lmem region Matthew Auld
2019-10-03 22:11 ` Patchwork [this message]
2019-10-03 22:21 ` ✗ Fi.CI.SPARSE: warning for LMEM basics (rev2) Patchwork
2019-10-03 22:34 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-04 11:34 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-10-04 12:06   ` Kai Vehmanen
2019-10-04 12:08     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191003221131.3221.78039@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox