* [PATCH tip/core/rcu 03/10] drivers/gpu: Replace rcu_swap_protected() with rcu_replace() [not found] <20191022191136.GA25627@paulmck-ThinkPad-P72> @ 2019-10-22 19:12 ` paulmck 2019-10-28 12:57 ` Joonas Lahtinen 0 siblings, 1 reply; 5+ messages in thread From: paulmck @ 2019-10-22 19:12 UTC (permalink / raw) To: rcu Cc: peterz, fweisbec, jiangshanlai, dri-devel, oleg, dhowells, edumazet, joel, mingo, David Airlie, dipankar, Paul E. McKenney, intel-gfx, josh, mathieu.desnoyers, rostedt, Rodrigo Vivi, tglx, Tvrtko Ursulin, linux-kernel, akpm From: "Paul E. McKenney" <paulmck@kernel.org> This commit replaces the use of rcu_swap_protected() with the more intuitively appealing rcu_replace() as a step towards removing rcu_swap_protected(). Link: https://lore.kernel.org/lkml/CAHk-=wiAsJLw1egFEE=Z7-GGtM6wcvtyytXZA1+BHqta4gg6Hw@mail.gmail.com/ Reported-by: Linus Torvalds <torvalds@linux-foundation.org> [ paulmck: From rcu_replace() to rcu_replace_pointer() per Ingo Molnar. ] Signed-off-by: Paul E. McKenney <paulmck@kernel.org> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: <intel-gfx@lists.freedesktop.org> Cc: <dri-devel@lists.freedesktop.org> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index 1cdfe05..3f3e803 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -1629,7 +1629,7 @@ set_engines(struct i915_gem_context *ctx, i915_gem_context_set_user_engines(ctx); else i915_gem_context_clear_user_engines(ctx); - rcu_swap_protected(ctx->engines, set.engines, 1); + set.engines = rcu_replace_pointer(ctx->engines, set.engines, 1); mutex_unlock(&ctx->engines_mutex); call_rcu(&set.engines->rcu, free_engines_rcu); -- 2.9.5 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH tip/core/rcu 03/10] drivers/gpu: Replace rcu_swap_protected() with rcu_replace() 2019-10-22 19:12 ` [PATCH tip/core/rcu 03/10] drivers/gpu: Replace rcu_swap_protected() with rcu_replace() paulmck @ 2019-10-28 12:57 ` Joonas Lahtinen 2019-10-28 12:57 ` [Intel-gfx] " Joonas Lahtinen 2019-10-28 13:40 ` Paul E. McKenney 0 siblings, 2 replies; 5+ messages in thread From: Joonas Lahtinen @ 2019-10-28 12:57 UTC (permalink / raw) To: rcu Cc: linux-kernel, mingo, jiangshanlai, dipankar, akpm, mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells, edumazet, fweisbec, oleg, joel, Paul E. McKenney, Jani Nikula, Rodrigo Vivi, David Airlie, Daniel Vetter, Chris Wilson, Tvrtko Ursulin, intel-gfx, dri-devel Quoting paulmck@kernel.org (2019-10-22 22:12:08) > From: "Paul E. McKenney" <paulmck@kernel.org> > > This commit replaces the use of rcu_swap_protected() with the more > intuitively appealing rcu_replace() as a step towards removing > rcu_swap_protected(). > > Link: https://lore.kernel.org/lkml/CAHk-=wiAsJLw1egFEE=Z7-GGtM6wcvtyytXZA1+BHqta4gg6Hw@mail.gmail.com/ > Reported-by: Linus Torvalds <torvalds@linux-foundation.org> > [ paulmck: From rcu_replace() to rcu_replace_pointer() per Ingo Molnar. ] > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: <intel-gfx@lists.freedesktop.org> > Cc: <dri-devel@lists.freedesktop.org> "drm/i915:" preferred as the subject prefix for increased specificity. Let me know which tree you end up merging with. Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Regards, Joonas ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH tip/core/rcu 03/10] drivers/gpu: Replace rcu_swap_protected() with rcu_replace() 2019-10-28 12:57 ` Joonas Lahtinen @ 2019-10-28 12:57 ` Joonas Lahtinen 2019-10-28 13:40 ` Paul E. McKenney 1 sibling, 0 replies; 5+ messages in thread From: Joonas Lahtinen @ 2019-10-28 12:57 UTC (permalink / raw) To: paulmck, rcu Cc: peterz, fweisbec, jiangshanlai, dri-devel, oleg, dhowells, edumazet, joel, mingo, David Airlie, dipankar, Paul E. McKenney, intel-gfx, josh, mathieu.desnoyers, rostedt, tglx, linux-kernel, akpm Quoting paulmck@kernel.org (2019-10-22 22:12:08) > From: "Paul E. McKenney" <paulmck@kernel.org> > > This commit replaces the use of rcu_swap_protected() with the more > intuitively appealing rcu_replace() as a step towards removing > rcu_swap_protected(). > > Link: https://lore.kernel.org/lkml/CAHk-=wiAsJLw1egFEE=Z7-GGtM6wcvtyytXZA1+BHqta4gg6Hw@mail.gmail.com/ > Reported-by: Linus Torvalds <torvalds@linux-foundation.org> > [ paulmck: From rcu_replace() to rcu_replace_pointer() per Ingo Molnar. ] > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: <intel-gfx@lists.freedesktop.org> > Cc: <dri-devel@lists.freedesktop.org> "drm/i915:" preferred as the subject prefix for increased specificity. Let me know which tree you end up merging with. Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Regards, Joonas _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH tip/core/rcu 03/10] drivers/gpu: Replace rcu_swap_protected() with rcu_replace() 2019-10-28 12:57 ` Joonas Lahtinen 2019-10-28 12:57 ` [Intel-gfx] " Joonas Lahtinen @ 2019-10-28 13:40 ` Paul E. McKenney 2019-10-28 13:40 ` [Intel-gfx] " Paul E. McKenney 1 sibling, 1 reply; 5+ messages in thread From: Paul E. McKenney @ 2019-10-28 13:40 UTC (permalink / raw) To: Joonas Lahtinen Cc: rcu, linux-kernel, mingo, jiangshanlai, dipankar, akpm, mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells, edumazet, fweisbec, oleg, joel, Jani Nikula, Rodrigo Vivi, David Airlie, Daniel Vetter, Chris Wilson, Tvrtko Ursulin, intel-gfx, dri-devel On Mon, Oct 28, 2019 at 02:57:26PM +0200, Joonas Lahtinen wrote: > Quoting paulmck@kernel.org (2019-10-22 22:12:08) > > From: "Paul E. McKenney" <paulmck@kernel.org> > > > > This commit replaces the use of rcu_swap_protected() with the more > > intuitively appealing rcu_replace() as a step towards removing > > rcu_swap_protected(). > > > > Link: https://lore.kernel.org/lkml/CAHk-=wiAsJLw1egFEE=Z7-GGtM6wcvtyytXZA1+BHqta4gg6Hw@mail.gmail.com/ > > Reported-by: Linus Torvalds <torvalds@linux-foundation.org> > > [ paulmck: From rcu_replace() to rcu_replace_pointer() per Ingo Molnar. ] > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Cc: <intel-gfx@lists.freedesktop.org> > > Cc: <dri-devel@lists.freedesktop.org> > > "drm/i915:" preferred as the subject prefix for increased specificity. "drm/i915" it is! > Let me know which tree you end up merging with. I expect to be sending a pull request for inclusion into the -tip tree in a day or three. > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Applied, thank you! Thanx, Paul ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH tip/core/rcu 03/10] drivers/gpu: Replace rcu_swap_protected() with rcu_replace() 2019-10-28 13:40 ` Paul E. McKenney @ 2019-10-28 13:40 ` Paul E. McKenney 0 siblings, 0 replies; 5+ messages in thread From: Paul E. McKenney @ 2019-10-28 13:40 UTC (permalink / raw) To: Joonas Lahtinen Cc: peterz, fweisbec, jiangshanlai, dri-devel, oleg, dhowells, edumazet, joel, mingo, David Airlie, dipankar, intel-gfx, josh, rcu, mathieu.desnoyers, rostedt, tglx, linux-kernel, akpm On Mon, Oct 28, 2019 at 02:57:26PM +0200, Joonas Lahtinen wrote: > Quoting paulmck@kernel.org (2019-10-22 22:12:08) > > From: "Paul E. McKenney" <paulmck@kernel.org> > > > > This commit replaces the use of rcu_swap_protected() with the more > > intuitively appealing rcu_replace() as a step towards removing > > rcu_swap_protected(). > > > > Link: https://lore.kernel.org/lkml/CAHk-=wiAsJLw1egFEE=Z7-GGtM6wcvtyytXZA1+BHqta4gg6Hw@mail.gmail.com/ > > Reported-by: Linus Torvalds <torvalds@linux-foundation.org> > > [ paulmck: From rcu_replace() to rcu_replace_pointer() per Ingo Molnar. ] > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Cc: <intel-gfx@lists.freedesktop.org> > > Cc: <dri-devel@lists.freedesktop.org> > > "drm/i915:" preferred as the subject prefix for increased specificity. "drm/i915" it is! > Let me know which tree you end up merging with. I expect to be sending a pull request for inclusion into the -tip tree in a day or three. > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Applied, thank you! Thanx, Paul _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-28 15:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20191022191136.GA25627@paulmck-ThinkPad-P72>
2019-10-22 19:12 ` [PATCH tip/core/rcu 03/10] drivers/gpu: Replace rcu_swap_protected() with rcu_replace() paulmck
2019-10-28 12:57 ` Joonas Lahtinen
2019-10-28 12:57 ` [Intel-gfx] " Joonas Lahtinen
2019-10-28 13:40 ` Paul E. McKenney
2019-10-28 13:40 ` [Intel-gfx] " Paul E. McKenney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox