From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/2] lib: Restore i915.reset before testing it in igt_allow_hang()
Date: Sun, 27 Oct 2019 21:01:17 +0200 [thread overview]
Message-ID: <20191027184427.GA12997@intel.intel> (raw)
In-Reply-To: <20191026193456.19445-1-chris@chris-wilson.co.uk>
Hi Chris,
On Sat, Oct 26, 2019 at 08:34:55PM +0100, Chris Wilson wrote:
> igt_allow_hang() checks that the GPU can be reset before allowing the
> test to cause a GPU hang (which would need the reset to recover).
> However, our checking for allowing a hang depends on i915.reset which we
> later restore. Do that restoration before the check so that this test is
> not affected by earlier fails.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Andi Shyti <andi.shyti@intel.com>
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: Restore i915.reset before testing it in igt_allow_hang()
Date: Sun, 27 Oct 2019 21:01:17 +0200 [thread overview]
Message-ID: <20191027184427.GA12997@intel.intel> (raw)
Message-ID: <20191027190117.f9HY-k7u-UWB-zirv3b7WIG9904GVkYVankN6vHjBt8@z> (raw)
In-Reply-To: <20191026193456.19445-1-chris@chris-wilson.co.uk>
Hi Chris,
On Sat, Oct 26, 2019 at 08:34:55PM +0100, Chris Wilson wrote:
> igt_allow_hang() checks that the GPU can be reset before allowing the
> test to cause a GPU hang (which would need the reset to recover).
> However, our checking for allowing a hang depends on i915.reset which we
> later restore. Do that restoration before the check so that this test is
> not affected by earlier fails.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Andi Shyti <andi.shyti@intel.com>
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-27 19:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 19:34 [PATCH i-g-t 1/2] lib: Restore i915.reset before testing it in igt_allow_hang() Chris Wilson
2019-10-26 19:34 ` [Intel-gfx] " Chris Wilson
2019-10-26 19:34 ` [PATCH i-g-t 2/2] i915/gem_ctx_exec: Enable resets for basic-nohangcheck Chris Wilson
2019-10-26 19:34 ` [Intel-gfx] " Chris Wilson
2019-10-27 19:01 ` Andi Shyti
2019-10-27 19:01 ` [Intel-gfx] " Andi Shyti
2019-10-27 19:05 ` Chris Wilson
2019-10-27 19:05 ` [Intel-gfx] " Chris Wilson
2019-10-27 19:33 ` Andi Shyti
2019-10-27 19:33 ` [Intel-gfx] " Andi Shyti
2019-10-27 19:06 ` Chris Wilson
2019-10-27 19:06 ` [Intel-gfx] " Chris Wilson
2019-10-27 19:01 ` Andi Shyti [this message]
2019-10-27 19:01 ` [Intel-gfx] [PATCH i-g-t 1/2] lib: Restore i915.reset before testing it in igt_allow_hang() Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027184427.GA12997@intel.intel \
--to=andi.shyti@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox