From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/rps: Flip interpretation of ips fmin/fmax to max rps
Date: Sun, 27 Oct 2019 21:01:33 +0200 [thread overview]
Message-ID: <20191027190133.GC12997@intel.intel> (raw)
In-Reply-To: <20191026200917.1780-1-chris@chris-wilson.co.uk>
Hi Chris,
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index 30f56c786468..032a0c6389f9 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -180,8 +180,8 @@ static void gen5_rps_init(struct intel_rps *rps)
> DRM_DEBUG_DRIVER("fmax: %d, fmin: %d, fstart: %d\n",
> fmax, fmin, fstart);
>
> - rps->min_freq = -fstart;
and we don't need fstart anymore... can we remove it?
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Andi
> - rps->max_freq = -fmin;
> + rps->min_freq = fmax;
> + rps->max_freq = fmin;
>
> rps->idle_freq = rps->min_freq;
> rps->cur_freq = rps->idle_freq;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/rps: Flip interpretation of ips fmin/fmax to max rps
Date: Sun, 27 Oct 2019 21:01:33 +0200 [thread overview]
Message-ID: <20191027190133.GC12997@intel.intel> (raw)
Message-ID: <20191027190133.WVwtuYNuO2nfD4_77gotUDFS2AfWF9aOitMHc24cah0@z> (raw)
In-Reply-To: <20191026200917.1780-1-chris@chris-wilson.co.uk>
Hi Chris,
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index 30f56c786468..032a0c6389f9 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -180,8 +180,8 @@ static void gen5_rps_init(struct intel_rps *rps)
> DRM_DEBUG_DRIVER("fmax: %d, fmin: %d, fstart: %d\n",
> fmax, fmin, fstart);
>
> - rps->min_freq = -fstart;
and we don't need fstart anymore... can we remove it?
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Andi
> - rps->max_freq = -fmin;
> + rps->min_freq = fmax;
> + rps->max_freq = fmin;
>
> rps->idle_freq = rps->min_freq;
> rps->cur_freq = rps->idle_freq;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-27 19:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 20:09 [PATCH] drm/i915/rps: Flip interpretation of ips fmin/fmax to max rps Chris Wilson
2019-10-26 20:09 ` [Intel-gfx] " Chris Wilson
2019-10-26 20:43 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-26 20:43 ` [Intel-gfx] " Patchwork
2019-10-27 19:01 ` Andi Shyti [this message]
2019-10-27 19:01 ` [Intel-gfx] [PATCH] " Andi Shyti
2019-10-27 19:11 ` Chris Wilson
2019-10-27 19:11 ` [Intel-gfx] " Chris Wilson
2019-10-28 10:20 ` ✗ Fi.CI.IGT: failure for " Patchwork
2019-10-28 10:20 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027190133.GC12997@intel.intel \
--to=andi.shyti@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox