Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/blt: fixup block_size rounding
Date: Mon, 28 Oct 2019 18:46:46 +0200	[thread overview]
Message-ID: <20191028164646.GR1208@intel.com> (raw)
In-Reply-To: <20191028163950.9429-1-matthew.auld@intel.com>

On Mon, Oct 28, 2019 at 04:39:50PM +0000, Matthew Auld wrote:
> There is nothing to say that the obj->base.size is actually a multiple
> of the block_size.
> 
> Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
> index 516e61e99212..5597f1345a63 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
> @@ -30,7 +30,7 @@ struct i915_vma *intel_emit_vma_fill_blt(struct intel_context *ce,
>  	GEM_BUG_ON(intel_engine_is_virtual(ce->engine));
>  	intel_engine_pm_get(ce->engine);
>  
> -	count = div_u64(vma->size, block_size);
> +	count = DIV64_U64_ROUND_UP(vma->size, block_size);

block_size size look to be u32?

>  	size = (1 + 8 * count) * sizeof(u32);
>  	size = round_up(size, PAGE_SIZE);
>  	pool = intel_engine_get_pool(ce->engine, size);
> @@ -214,7 +214,7 @@ struct i915_vma *intel_emit_vma_copy_blt(struct intel_context *ce,
>  	GEM_BUG_ON(intel_engine_is_virtual(ce->engine));
>  	intel_engine_pm_get(ce->engine);
>  
> -	count = div_u64(dst->size, block_size);
> +	count = DIV64_U64_ROUND_UP(dst->size, block_size);
>  	size = (1 + 11 * count) * sizeof(u32);
>  	size = round_up(size, PAGE_SIZE);
>  	pool = intel_engine_get_pool(ce->engine, size);
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/blt: fixup block_size rounding
Date: Mon, 28 Oct 2019 18:46:46 +0200	[thread overview]
Message-ID: <20191028164646.GR1208@intel.com> (raw)
Message-ID: <20191028164646.iA3h8QUS_xV0E_BL1E-aFD7_sQSM7llVh4FnsQKA4kM@z> (raw)
In-Reply-To: <20191028163950.9429-1-matthew.auld@intel.com>

On Mon, Oct 28, 2019 at 04:39:50PM +0000, Matthew Auld wrote:
> There is nothing to say that the obj->base.size is actually a multiple
> of the block_size.
> 
> Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
> index 516e61e99212..5597f1345a63 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
> @@ -30,7 +30,7 @@ struct i915_vma *intel_emit_vma_fill_blt(struct intel_context *ce,
>  	GEM_BUG_ON(intel_engine_is_virtual(ce->engine));
>  	intel_engine_pm_get(ce->engine);
>  
> -	count = div_u64(vma->size, block_size);
> +	count = DIV64_U64_ROUND_UP(vma->size, block_size);

block_size size look to be u32?

>  	size = (1 + 8 * count) * sizeof(u32);
>  	size = round_up(size, PAGE_SIZE);
>  	pool = intel_engine_get_pool(ce->engine, size);
> @@ -214,7 +214,7 @@ struct i915_vma *intel_emit_vma_copy_blt(struct intel_context *ce,
>  	GEM_BUG_ON(intel_engine_is_virtual(ce->engine));
>  	intel_engine_pm_get(ce->engine);
>  
> -	count = div_u64(dst->size, block_size);
> +	count = DIV64_U64_ROUND_UP(dst->size, block_size);
>  	size = (1 + 11 * count) * sizeof(u32);
>  	size = round_up(size, PAGE_SIZE);
>  	pool = intel_engine_get_pool(ce->engine, size);
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-28 16:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 16:39 [PATCH] drm/i915/blt: fixup block_size rounding Matthew Auld
2019-10-28 16:39 ` [Intel-gfx] " Matthew Auld
2019-10-28 16:46 ` Ville Syrjälä [this message]
2019-10-28 16:46   ` Ville Syrjälä
2019-10-28 17:33   ` Chris Wilson
2019-10-28 17:33     ` [Intel-gfx] " Chris Wilson
2019-10-28 20:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-28 20:10   ` [Intel-gfx] " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2019-10-28 21:55 [PATCH] " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191028164646.GR1208@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox