Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/dp: Do not switch aux to TBT mode for non-TC ports
@ 2019-10-29  1:10 José Roberto de Souza
  2019-10-29  1:10 ` [Intel-gfx] " José Roberto de Souza
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: José Roberto de Souza @ 2019-10-29  1:10 UTC (permalink / raw)
  To: intel-gfx

Non-TC ports always have tc_mode == TC_PORT_TBT_ALT so it was
switching aux to TC mode for all combo-phy ports, happily this did
not caused any issue but is better follow BSpec.
Also this is reserved bit before ICL.

Fixes: 6f211ed43438 ("drm/i915/icl: Set TBT IO in Aux transaction")
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 86989ec25bc6..379623397301 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1291,6 +1291,9 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp,
 				u32 unused)
 {
 	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
+	struct drm_i915_private *i915 =
+			to_i915(intel_dig_port->base.base.dev);
+	enum phy phy = intel_port_to_phy(i915, intel_dig_port->base.port);
 	u32 ret;
 
 	ret = DP_AUX_CH_CTL_SEND_BUSY |
@@ -1303,7 +1306,8 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp,
 	      DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(32) |
 	      DP_AUX_CH_CTL_SYNC_PULSE_SKL(32);
 
-	if (intel_dig_port->tc_mode == TC_PORT_TBT_ALT)
+	if (intel_phy_is_tc(i915, phy) &&
+	    intel_dig_port->tc_mode == TC_PORT_TBT_ALT)
 		ret |= DP_AUX_CH_CTL_TBT_IO;
 
 	return ret;
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-10-31 17:26 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-29  1:10 [PATCH] drm/i915/dp: Do not switch aux to TBT mode for non-TC ports José Roberto de Souza
2019-10-29  1:10 ` [Intel-gfx] " José Roberto de Souza
2019-10-29  2:23 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-10-29  2:23   ` [Intel-gfx] " Patchwork
2019-10-29 10:03 ` [PATCH] " Imre Deak
2019-10-29 10:03   ` [Intel-gfx] " Imre Deak
2019-10-30  2:30 ` ✓ Fi.CI.BAT: success for drm/i915/dp: Do not switch aux to TBT mode for non-TC ports (rev2) Patchwork
2019-10-30  2:30   ` [Intel-gfx] " Patchwork
2019-10-31  5:38 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-31  5:38   ` [Intel-gfx] " Patchwork
2019-10-31 17:26   ` Souza, Jose
2019-10-31 17:26     ` [Intel-gfx] " Souza, Jose

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox