Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Stuart Summers <stuart.summers@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Skip MCHBAR queries on dgfx
Date: Thu, 31 Oct 2019 17:58:20 +0200	[thread overview]
Message-ID: <20191031155820.GB1208@intel.com> (raw)
In-Reply-To: <20191031151124.177930-1-stuart.summers@intel.com>

On Thu, Oct 31, 2019 at 08:11:24AM -0700, Stuart Summers wrote:
> dgfx does not map the MCHBAR MMIO into the GFX device BAR.
> Skip this sequence when running on dgfx.
> 
> Signed-off-by: Stuart Summers <stuart.summers@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 21273b516dbe..1de46bfa5a19 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1056,7 +1056,7 @@ intel_get_dram_info(struct drm_i915_private *dev_priv)
>  	 */
>  	dram_info->is_16gb_dimm = !IS_GEN9_LP(dev_priv);
>  
> -	if (INTEL_GEN(dev_priv) < 9)
> +	if (INTEL_GEN(dev_priv) < 9 || IS_DGFX(dev_priv))
>  		return;
>  
>  	if (IS_GEN9_LP(dev_priv))
> -- 
> 2.22.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Stuart Summers <stuart.summers@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Skip MCHBAR queries on dgfx
Date: Thu, 31 Oct 2019 17:58:20 +0200	[thread overview]
Message-ID: <20191031155820.GB1208@intel.com> (raw)
Message-ID: <20191031155820.YP5tctSh5wIAv4kwO7vz-KX4OCKfcCrVCBV1_M8G1gs@z> (raw)
In-Reply-To: <20191031151124.177930-1-stuart.summers@intel.com>

On Thu, Oct 31, 2019 at 08:11:24AM -0700, Stuart Summers wrote:
> dgfx does not map the MCHBAR MMIO into the GFX device BAR.
> Skip this sequence when running on dgfx.
> 
> Signed-off-by: Stuart Summers <stuart.summers@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 21273b516dbe..1de46bfa5a19 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1056,7 +1056,7 @@ intel_get_dram_info(struct drm_i915_private *dev_priv)
>  	 */
>  	dram_info->is_16gb_dimm = !IS_GEN9_LP(dev_priv);
>  
> -	if (INTEL_GEN(dev_priv) < 9)
> +	if (INTEL_GEN(dev_priv) < 9 || IS_DGFX(dev_priv))
>  		return;
>  
>  	if (IS_GEN9_LP(dev_priv))
> -- 
> 2.22.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-31 15:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 15:11 [PATCH] drm/i915: Skip MCHBAR queries on dgfx Stuart Summers
2019-10-31 15:11 ` [Intel-gfx] " Stuart Summers
2019-10-31 15:58 ` Ville Syrjälä [this message]
2019-10-31 15:58   ` Ville Syrjälä
2019-10-31 18:37 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-31 18:37   ` [Intel-gfx] " Patchwork
2019-11-01 22:59 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-01 22:59   ` [Intel-gfx] " Patchwork
2019-11-02  5:18 ` [PATCH] " kbuild test robot
2019-11-02  5:18   ` [Intel-gfx] " kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191031155820.GB1208@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stuart.summers@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox