From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Start kthreads before stopping
Date: Fri, 01 Nov 2019 09:37:14 -0000 [thread overview]
Message-ID: <20191101093714.19149.66279@emeril.freedesktop.org> (raw)
In-Reply-To: <20191101084940.31838-1-chris@chris-wilson.co.uk>
== Series Details ==
Series: drm/i915/selftests: Start kthreads before stopping
URL : https://patchwork.freedesktop.org/series/68852/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9a1bad00fe0c drm/i915/selftests: Start kthreads before stopping
-:25: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#25: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:348:
+ yield(); /* start all threads before we kthread_stop() */
-:38: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#38: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:476:
+ yield(); /* start all threads before we kthread_stop() */
-:51: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#51: FILE: drivers/gpu/drm/i915/gt/selftest_hangcheck.c:829:
+ yield(); /* start all threads before we begin */
-:64: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#64: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:2255:
+ yield(); /* start all threads before we kthread_stop() */
-:77: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#77: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:467:
+ yield(); /* start all threads before we begin */
-:85: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#85: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1318:
+ yield(); /* start all threads before we begin */
total: 0 errors, 6 warnings, 0 checks, 46 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Chris Wilson" <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Start kthreads before stopping
Date: Fri, 01 Nov 2019 09:37:14 -0000 [thread overview]
Message-ID: <20191101093714.19149.66279@emeril.freedesktop.org> (raw)
Message-ID: <20191101093714.rFLb2RQWeS9WtC1R0AO4jXf8gbDIobQiraERh22Gq6o@z> (raw)
In-Reply-To: <20191101084940.31838-1-chris@chris-wilson.co.uk>
== Series Details ==
Series: drm/i915/selftests: Start kthreads before stopping
URL : https://patchwork.freedesktop.org/series/68852/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9a1bad00fe0c drm/i915/selftests: Start kthreads before stopping
-:25: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#25: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:348:
+ yield(); /* start all threads before we kthread_stop() */
-:38: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#38: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:476:
+ yield(); /* start all threads before we kthread_stop() */
-:51: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#51: FILE: drivers/gpu/drm/i915/gt/selftest_hangcheck.c:829:
+ yield(); /* start all threads before we begin */
-:64: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#64: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:2255:
+ yield(); /* start all threads before we kthread_stop() */
-:77: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#77: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:467:
+ yield(); /* start all threads before we begin */
-:85: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#85: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1318:
+ yield(); /* start all threads before we begin */
total: 0 errors, 6 warnings, 0 checks, 46 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-01 9:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 8:49 [PATCH] drm/i915/selftests: Start kthreads before stopping Chris Wilson
2019-11-01 8:49 ` [Intel-gfx] " Chris Wilson
2019-11-01 9:37 ` Patchwork [this message]
2019-11-01 9:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-01 9:54 ` [PATCH] " Matthew Auld
2019-11-01 9:54 ` [Intel-gfx] " Matthew Auld
2019-11-01 10:08 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-01 10:08 ` [Intel-gfx] " Patchwork
2019-11-02 14:59 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-02 14:59 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101093714.19149.66279@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox