Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lee Shawn C <shawn.c.lee@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
	Cooper Chiou <cooper.chiou@intel.com>,
	intel-gfx@lists.freedesktop.org,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH v6 1/2] drm/i915/cml: Remove unsupport PCI ID
Date: Fri, 1 Nov 2019 15:33:39 +0200	[thread overview]
Message-ID: <20191101133339.GG1208@intel.com> (raw)
In-Reply-To: <20191029160407.21178-1-shawn.c.lee@intel.com>

On Wed, Oct 30, 2019 at 12:04:06AM +0800, Lee Shawn C wrote:
> commit 'a7b4deeb02b9 ("drm/i915/cml: Add CML PCI IDS)'
> introduced new PCI ID that CML support. But some PCI
> IDs were removed from CML IDs in BSpec.

Series lgtm.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Please rebase onto latest drm-tip and repost so that CI can
have a go at it.

> 
> v2: remove some inaccurate descriptions.
> v3: fix typo.
> v4: add missing version number.
> v5: no update.
> v6: update patch comment.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
>  include/drm/i915_pciids.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index a70c982ddff9..56e823cdc717 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -448,9 +448,7 @@
>  #define INTEL_CML_GT1_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x9B21, info), \
>  	INTEL_VGA_DEVICE(0x9BAA, info), \
> -	INTEL_VGA_DEVICE(0x9BAB, info), \
>  	INTEL_VGA_DEVICE(0x9BAC, info), \
> -	INTEL_VGA_DEVICE(0x9BA0, info), \
>  	INTEL_VGA_DEVICE(0x9BA5, info), \
>  	INTEL_VGA_DEVICE(0x9BA8, info), \
>  	INTEL_VGA_DEVICE(0x9BA4, info), \
> @@ -460,9 +458,7 @@
>  #define INTEL_CML_GT2_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x9B41, info), \
>  	INTEL_VGA_DEVICE(0x9BCA, info), \
> -	INTEL_VGA_DEVICE(0x9BCB, info), \
>  	INTEL_VGA_DEVICE(0x9BCC, info), \
> -	INTEL_VGA_DEVICE(0x9BC0, info), \
>  	INTEL_VGA_DEVICE(0x9BC5, info), \
>  	INTEL_VGA_DEVICE(0x9BC8, info), \
>  	INTEL_VGA_DEVICE(0x9BC4, info), \
> -- 
> 2.17.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lee Shawn C <shawn.c.lee@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
	Cooper Chiou <cooper.chiou@intel.com>,
	intel-gfx@lists.freedesktop.org,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v6 1/2] drm/i915/cml: Remove unsupport PCI ID
Date: Fri, 1 Nov 2019 15:33:39 +0200	[thread overview]
Message-ID: <20191101133339.GG1208@intel.com> (raw)
Message-ID: <20191101133339.pxkH4XSd_EdGV1nKx_f4S3IN0xmKGhZhx-azO7_y6II@z> (raw)
In-Reply-To: <20191029160407.21178-1-shawn.c.lee@intel.com>

On Wed, Oct 30, 2019 at 12:04:06AM +0800, Lee Shawn C wrote:
> commit 'a7b4deeb02b9 ("drm/i915/cml: Add CML PCI IDS)'
> introduced new PCI ID that CML support. But some PCI
> IDs were removed from CML IDs in BSpec.

Series lgtm.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Please rebase onto latest drm-tip and repost so that CI can
have a go at it.

> 
> v2: remove some inaccurate descriptions.
> v3: fix typo.
> v4: add missing version number.
> v5: no update.
> v6: update patch comment.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
>  include/drm/i915_pciids.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index a70c982ddff9..56e823cdc717 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -448,9 +448,7 @@
>  #define INTEL_CML_GT1_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x9B21, info), \
>  	INTEL_VGA_DEVICE(0x9BAA, info), \
> -	INTEL_VGA_DEVICE(0x9BAB, info), \
>  	INTEL_VGA_DEVICE(0x9BAC, info), \
> -	INTEL_VGA_DEVICE(0x9BA0, info), \
>  	INTEL_VGA_DEVICE(0x9BA5, info), \
>  	INTEL_VGA_DEVICE(0x9BA8, info), \
>  	INTEL_VGA_DEVICE(0x9BA4, info), \
> @@ -460,9 +458,7 @@
>  #define INTEL_CML_GT2_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x9B41, info), \
>  	INTEL_VGA_DEVICE(0x9BCA, info), \
> -	INTEL_VGA_DEVICE(0x9BCB, info), \
>  	INTEL_VGA_DEVICE(0x9BCC, info), \
> -	INTEL_VGA_DEVICE(0x9BC0, info), \
>  	INTEL_VGA_DEVICE(0x9BC5, info), \
>  	INTEL_VGA_DEVICE(0x9BC8, info), \
>  	INTEL_VGA_DEVICE(0x9BC4, info), \
> -- 
> 2.17.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-01 13:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 16:04 [PATCH v6 1/2] drm/i915/cml: Remove unsupport PCI ID Lee Shawn C
2019-10-29  9:27 ` ✗ Fi.CI.BUILD: failure for series starting with [v6,1/2] " Patchwork
2019-10-29  9:27   ` [Intel-gfx] " Patchwork
2019-10-29 16:04 ` [Intel-gfx] [PATCH v6 1/2] " Lee Shawn C
2019-10-29 16:04 ` [PATCH v6 2/2] drm/i915/cml: Separate U series pci id from origianl list Lee Shawn C
2019-10-29 16:04   ` [Intel-gfx] " Lee Shawn C
2019-11-01 13:33 ` Ville Syrjälä [this message]
2019-11-01 13:33   ` [Intel-gfx] [PATCH v6 1/2] drm/i915/cml: Remove unsupport PCI ID Ville Syrjälä
  -- strict thread matches above, loose matches on Subject: below --
2019-10-25 20:32 [PATCH v4] " Lee Shawn C
2019-10-28 17:03 ` [PATCH v6 1/2] " Lee Shawn C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191101133339.GG1208@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=cooper.chiou@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=shawn.c.lee@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox