Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: add for_each_port() and use it
Date: Fri, 1 Nov 2019 16:10:32 +0200	[thread overview]
Message-ID: <20191101141032.GH1208@intel.com> (raw)
In-Reply-To: <20191101134333.11612-1-jani.nikula@intel.com>

On Fri, Nov 01, 2019 at 03:43:33PM +0200, Jani Nikula wrote:
> Add another for_each style macro to the pile of custom looping macros.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_bios.c    | 8 ++++----
>  drivers/gpu/drm/i915/display/intel_display.h | 7 +++++--
>  2 files changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 63c1bd4c2954..a03f56b7b4ef 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1246,7 +1246,7 @@ static enum port get_port_by_ddc_pin(struct drm_i915_private *i915, u8 ddc_pin)
>  	const struct ddi_vbt_port_info *info;
>  	enum port port;
>  
> -	for (port = PORT_A; port < I915_MAX_PORTS; port++) {
> +	for_each_port(port) {
>  		info = &i915->vbt.ddi_port_info[port];
>  
>  		if (info->child && ddc_pin == info->alternate_ddc_pin)
> @@ -1297,7 +1297,7 @@ static enum port get_port_by_aux_ch(struct drm_i915_private *i915, u8 aux_ch)
>  	const struct ddi_vbt_port_info *info;
>  	enum port port;
>  
> -	for (port = PORT_A; port < I915_MAX_PORTS; port++) {
> +	for_each_port(port) {
>  		info = &i915->vbt.ddi_port_info[port];
>  
>  		if (info->child && aux_ch == info->alternate_aux_channel)
> @@ -1722,7 +1722,7 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
>  			!HAS_PCH_SPLIT(dev_priv));
>  	DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
>  
> -	for (port = PORT_A; port < I915_MAX_PORTS; port++) {
> +	for_each_port(port) {
>  		struct ddi_vbt_port_info *info =
>  			&dev_priv->vbt.ddi_port_info[port];
>  
> @@ -1736,7 +1736,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
>  {
>  	enum port port;
>  
> -	for (port = PORT_A; port < I915_MAX_PORTS; port++) {
> +	for_each_port(port) {
>  		struct ddi_vbt_port_info *info =
>  			&dev_priv->vbt.ddi_port_info[port];
>  		enum phy phy = intel_port_to_phy(dev_priv, port);
> diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
> index 355c50088589..4522ef167a91 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -333,8 +333,11 @@ enum phy_fia {
>  	     (__s) < RUNTIME_INFO(__dev_priv)->num_sprites[(__p)];	\
>  	     (__s)++)
>  
> -#define for_each_port_masked(__port, __ports_mask) \
> -	for ((__port) = PORT_A; (__port) < I915_MAX_PORTS; (__port)++)	\
> +#define for_each_port(__port) \
> +	for ((__port) = PORT_A; (__port) < I915_MAX_PORTS; (__port)++)
> +
> +#define for_each_port_masked(__port, __ports_mask)			\
> +	for_each_port(__port)						\
>  		for_each_if((__ports_mask) & BIT(__port))
>  
>  #define for_each_phy_masked(__phy, __phys_mask) \
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: add for_each_port() and use it
Date: Fri, 1 Nov 2019 16:10:32 +0200	[thread overview]
Message-ID: <20191101141032.GH1208@intel.com> (raw)
Message-ID: <20191101141032.pQyKDpWyWwgzDvn3iuTTin1HDmGByHeH-WDP6zd_ypA@z> (raw)
In-Reply-To: <20191101134333.11612-1-jani.nikula@intel.com>

On Fri, Nov 01, 2019 at 03:43:33PM +0200, Jani Nikula wrote:
> Add another for_each style macro to the pile of custom looping macros.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_bios.c    | 8 ++++----
>  drivers/gpu/drm/i915/display/intel_display.h | 7 +++++--
>  2 files changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 63c1bd4c2954..a03f56b7b4ef 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1246,7 +1246,7 @@ static enum port get_port_by_ddc_pin(struct drm_i915_private *i915, u8 ddc_pin)
>  	const struct ddi_vbt_port_info *info;
>  	enum port port;
>  
> -	for (port = PORT_A; port < I915_MAX_PORTS; port++) {
> +	for_each_port(port) {
>  		info = &i915->vbt.ddi_port_info[port];
>  
>  		if (info->child && ddc_pin == info->alternate_ddc_pin)
> @@ -1297,7 +1297,7 @@ static enum port get_port_by_aux_ch(struct drm_i915_private *i915, u8 aux_ch)
>  	const struct ddi_vbt_port_info *info;
>  	enum port port;
>  
> -	for (port = PORT_A; port < I915_MAX_PORTS; port++) {
> +	for_each_port(port) {
>  		info = &i915->vbt.ddi_port_info[port];
>  
>  		if (info->child && aux_ch == info->alternate_aux_channel)
> @@ -1722,7 +1722,7 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
>  			!HAS_PCH_SPLIT(dev_priv));
>  	DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
>  
> -	for (port = PORT_A; port < I915_MAX_PORTS; port++) {
> +	for_each_port(port) {
>  		struct ddi_vbt_port_info *info =
>  			&dev_priv->vbt.ddi_port_info[port];
>  
> @@ -1736,7 +1736,7 @@ init_vbt_missing_defaults(struct drm_i915_private *dev_priv)
>  {
>  	enum port port;
>  
> -	for (port = PORT_A; port < I915_MAX_PORTS; port++) {
> +	for_each_port(port) {
>  		struct ddi_vbt_port_info *info =
>  			&dev_priv->vbt.ddi_port_info[port];
>  		enum phy phy = intel_port_to_phy(dev_priv, port);
> diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
> index 355c50088589..4522ef167a91 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -333,8 +333,11 @@ enum phy_fia {
>  	     (__s) < RUNTIME_INFO(__dev_priv)->num_sprites[(__p)];	\
>  	     (__s)++)
>  
> -#define for_each_port_masked(__port, __ports_mask) \
> -	for ((__port) = PORT_A; (__port) < I915_MAX_PORTS; (__port)++)	\
> +#define for_each_port(__port) \
> +	for ((__port) = PORT_A; (__port) < I915_MAX_PORTS; (__port)++)
> +
> +#define for_each_port_masked(__port, __ports_mask)			\
> +	for_each_port(__port)						\
>  		for_each_if((__ports_mask) & BIT(__port))
>  
>  #define for_each_phy_masked(__phy, __phys_mask) \
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-01 14:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01 13:43 [PATCH] drm/i915: add for_each_port() and use it Jani Nikula
2019-11-01 13:43 ` [Intel-gfx] " Jani Nikula
2019-11-01 14:10 ` Ville Syrjälä [this message]
2019-11-01 14:10   ` Ville Syrjälä
2019-11-04 13:20   ` Jani Nikula
2019-11-04 13:20     ` [Intel-gfx] " Jani Nikula
2019-11-01 16:52 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-01 16:52   ` [Intel-gfx] " Patchwork
2019-11-01 17:35 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-01 17:35   ` [Intel-gfx] " Patchwork
2019-11-03  2:55 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-03  2:55   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191101141032.GH1208@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox