Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: James Ausmus <james.ausmus@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/tgl: Add second TGL PCH ID
Date: Wed, 6 Nov 2019 16:58:00 -0800	[thread overview]
Message-ID: <20191107005800.GD16742@jausmus-gentoo-dev6.jf.intel.com> (raw)
In-Reply-To: <20191107002527.m4vghm7tmbx5c4zt@ldmartin-desk1>

On Wed, Nov 06, 2019 at 04:25:27PM -0800, Lucas De Marchi wrote:
> On Tue, Nov 05, 2019 at 05:13:29PM -0800, Jose Souza wrote:
> >On Tue, 2019-11-05 at 16:55 -0800, James Ausmus wrote:
> >> Another TGP ID has shown up, so let's add it to avoid South Display
> >> breakage on systems that have this ID.
> >>
> >
> >Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> 
> and pushed, thanks

Thanks Lucas!

-James

> 
> Lucas De Marchi
> 
> >
> >> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> >> Cc: José Roberto de Souza <jose.souza@intel.com>
> >> Signed-off-by: James Ausmus <james.ausmus@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/intel_pch.c | 1 +
> >>  drivers/gpu/drm/i915/intel_pch.h | 1 +
> >>  2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_pch.c
> >> b/drivers/gpu/drm/i915/intel_pch.c
> >> index 000ba43e2c02..fd22355b9a96 100644
> >> --- a/drivers/gpu/drm/i915/intel_pch.c
> >> +++ b/drivers/gpu/drm/i915/intel_pch.c
> >> @@ -85,6 +85,7 @@ intel_pch_type(const struct drm_i915_private
> >> *dev_priv, unsigned short id)
> >>  		WARN_ON(!IS_ELKHARTLAKE(dev_priv));
> >>  		return PCH_MCC;
> >>  	case INTEL_PCH_TGP_DEVICE_ID_TYPE:
> >> +	case INTEL_PCH_TGP2_DEVICE_ID_TYPE:
> >>  		DRM_DEBUG_KMS("Found Tiger Lake LP PCH\n");
> >>  		WARN_ON(!IS_TIGERLAKE(dev_priv));
> >>  		return PCH_TGP;
> >> diff --git a/drivers/gpu/drm/i915/intel_pch.h
> >> b/drivers/gpu/drm/i915/intel_pch.h
> >> index 1115c6a0522c..52d145dcdb15 100644
> >> --- a/drivers/gpu/drm/i915/intel_pch.h
> >> +++ b/drivers/gpu/drm/i915/intel_pch.h
> >> @@ -47,6 +47,7 @@ enum intel_pch {
> >>  #define INTEL_PCH_ICP_DEVICE_ID_TYPE		0x3480
> >>  #define INTEL_PCH_MCC_DEVICE_ID_TYPE		0x4B00
> >>  #define INTEL_PCH_TGP_DEVICE_ID_TYPE		0xA080
> >> +#define INTEL_PCH_TGP2_DEVICE_ID_TYPE		0x4380
> >>  #define INTEL_PCH_JSP_DEVICE_ID_TYPE		0x4D80
> >>  #define INTEL_PCH_JSP2_DEVICE_ID_TYPE		0x3880
> >>  #define INTEL_PCH_P2X_DEVICE_ID_TYPE		0x7100
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: James Ausmus <james.ausmus@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add second TGL PCH ID
Date: Wed, 6 Nov 2019 16:58:00 -0800	[thread overview]
Message-ID: <20191107005800.GD16742@jausmus-gentoo-dev6.jf.intel.com> (raw)
Message-ID: <20191107005800.3kv5p_i2Oe2oVTltjcg_0UXGwMSZD5XFGiZ63Ix_m2E@z> (raw)
In-Reply-To: <20191107002527.m4vghm7tmbx5c4zt@ldmartin-desk1>

On Wed, Nov 06, 2019 at 04:25:27PM -0800, Lucas De Marchi wrote:
> On Tue, Nov 05, 2019 at 05:13:29PM -0800, Jose Souza wrote:
> >On Tue, 2019-11-05 at 16:55 -0800, James Ausmus wrote:
> >> Another TGP ID has shown up, so let's add it to avoid South Display
> >> breakage on systems that have this ID.
> >>
> >
> >Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> 
> and pushed, thanks

Thanks Lucas!

-James

> 
> Lucas De Marchi
> 
> >
> >> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> >> Cc: José Roberto de Souza <jose.souza@intel.com>
> >> Signed-off-by: James Ausmus <james.ausmus@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/intel_pch.c | 1 +
> >>  drivers/gpu/drm/i915/intel_pch.h | 1 +
> >>  2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_pch.c
> >> b/drivers/gpu/drm/i915/intel_pch.c
> >> index 000ba43e2c02..fd22355b9a96 100644
> >> --- a/drivers/gpu/drm/i915/intel_pch.c
> >> +++ b/drivers/gpu/drm/i915/intel_pch.c
> >> @@ -85,6 +85,7 @@ intel_pch_type(const struct drm_i915_private
> >> *dev_priv, unsigned short id)
> >>  		WARN_ON(!IS_ELKHARTLAKE(dev_priv));
> >>  		return PCH_MCC;
> >>  	case INTEL_PCH_TGP_DEVICE_ID_TYPE:
> >> +	case INTEL_PCH_TGP2_DEVICE_ID_TYPE:
> >>  		DRM_DEBUG_KMS("Found Tiger Lake LP PCH\n");
> >>  		WARN_ON(!IS_TIGERLAKE(dev_priv));
> >>  		return PCH_TGP;
> >> diff --git a/drivers/gpu/drm/i915/intel_pch.h
> >> b/drivers/gpu/drm/i915/intel_pch.h
> >> index 1115c6a0522c..52d145dcdb15 100644
> >> --- a/drivers/gpu/drm/i915/intel_pch.h
> >> +++ b/drivers/gpu/drm/i915/intel_pch.h
> >> @@ -47,6 +47,7 @@ enum intel_pch {
> >>  #define INTEL_PCH_ICP_DEVICE_ID_TYPE		0x3480
> >>  #define INTEL_PCH_MCC_DEVICE_ID_TYPE		0x4B00
> >>  #define INTEL_PCH_TGP_DEVICE_ID_TYPE		0xA080
> >> +#define INTEL_PCH_TGP2_DEVICE_ID_TYPE		0x4380
> >>  #define INTEL_PCH_JSP_DEVICE_ID_TYPE		0x4D80
> >>  #define INTEL_PCH_JSP2_DEVICE_ID_TYPE		0x3880
> >>  #define INTEL_PCH_P2X_DEVICE_ID_TYPE		0x7100
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-07  0:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06  0:55 [PATCH] drm/i915/tgl: Add second TGL PCH ID James Ausmus
2019-11-06  0:55 ` [Intel-gfx] " James Ausmus
2019-11-06  1:13 ` Souza, Jose
2019-11-06  1:13   ` [Intel-gfx] " Souza, Jose
2019-11-07  0:25   ` Lucas De Marchi
2019-11-07  0:25     ` [Intel-gfx] " Lucas De Marchi
2019-11-07  0:58     ` James Ausmus [this message]
2019-11-07  0:58       ` James Ausmus
2019-11-06  1:30 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-06  1:30   ` [Intel-gfx] " Patchwork
2019-11-06 22:26 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-06 22:26   ` [Intel-gfx] " Patchwork
2019-11-06 23:10   ` James Ausmus
2019-11-06 23:10     ` [Intel-gfx] " James Ausmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107005800.GD16742@jausmus-gentoo-dev6.jf.intel.com \
    --to=james.ausmus@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox