Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com,
	alex.williamson@redhat.com, mst@redhat.com, tiwei.bie@intel.com,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, maxime.coquelin@redhat.com,
	cunming.liang@intel.com, zhihong.wang@intel.com,
	rob.miller@broadcom.com, xiao.w.wang@intel.com,
	haotian.wang@sifive.com, zhenyuw@linux.intel.com,
	zhi.a.wang@intel.com, jani.nikula@linux.intel.com,
	joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
	airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com,
	pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com,
	heiko.carstens@de.ibm.com, gor@linux.ibm.c
Subject: Re: [PATCH V11 3/6] mdev: introduce device specific ops
Date: Thu, 7 Nov 2019 16:36:06 +0100	[thread overview]
Message-ID: <20191107163606.293a4f62.cohuck@redhat.com> (raw)
In-Reply-To: <20191107151109.23261-4-jasowang@redhat.com>

On Thu,  7 Nov 2019 23:11:06 +0800
Jason Wang <jasowang@redhat.com> wrote:

> Currently, except for the create and remove, the rest of
> mdev_parent_ops is designed for vfio-mdev driver only and may not help
> for kernel mdev driver. With the help of class id, this patch
> introduces device specific callbacks inside mdev_device
> structure. This allows different set of callback to be used by
> vfio-mdev and virtio-mdev.
> 
> Reviewed-by: Parav Pandit <parav@mellanox.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  .../driver-api/vfio-mediated-device.rst       | 35 +++++++++----
>  MAINTAINERS                                   |  1 +
>  drivers/gpu/drm/i915/gvt/kvmgt.c              | 18 ++++---
>  drivers/s390/cio/vfio_ccw_ops.c               | 18 ++++---
>  drivers/s390/crypto/vfio_ap_ops.c             | 14 +++--
>  drivers/vfio/mdev/mdev_core.c                 | 24 ++++++++-
>  drivers/vfio/mdev/mdev_private.h              |  5 ++
>  drivers/vfio/mdev/vfio_mdev.c                 | 37 ++++++-------
>  include/linux/mdev.h                          | 43 ++++-----------
>  include/linux/mdev_vfio_ops.h                 | 52 +++++++++++++++++++
>  samples/vfio-mdev/mbochs.c                    | 20 ++++---
>  samples/vfio-mdev/mdpy.c                      | 20 ++++---
>  samples/vfio-mdev/mtty.c                      | 18 ++++---
>  13 files changed, 206 insertions(+), 99 deletions(-)
>  create mode 100644 include/linux/mdev_vfio_ops.h

You dropped my R-b :(, here it is again:

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: christophe.de.dinechin@gmail.com, kvm@vger.kernel.org,
	mst@redhat.com, airlied@linux.ie, heiko.carstens@de.ibm.com,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org, kwankhede@nvidia.com,
	rob.miller@broadcom.com, linux-s390@vger.kernel.org,
	sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com,
	pasic@linux.ibm.com, borntraeger@de.ibm.com,
	haotian.wang@sifive.com, cunming.liang@intel.com,
	farman@linux.ibm.com, parav@mellanox.com, gor@linux.ibm.com,
	intel-gfx@lists.freedesktop.org, xiao.w.wang@intel.com,
	freude@linux.ibm.com, stefanha@redhat.com,
	zhihong.wang@intel.com, intel-gvt-dev@lists.freedesktop.org,
	akrowiak@linux.ibm.com, oberpar@linux.ibm.com,
	tiwei.bie@intel.com, netdev@vger.kernel.org,
	rdunlap@infradead.org, linux-kernel@vger.kernel.org,
	maxime.coquelin@redhat.com, lingshan.zhu@intel.com
Subject: Re: [Intel-gfx] [PATCH V11 3/6] mdev: introduce device specific ops
Date: Thu, 7 Nov 2019 16:36:06 +0100	[thread overview]
Message-ID: <20191107163606.293a4f62.cohuck@redhat.com> (raw)
Message-ID: <20191107153606.Afh13S2mbtp9uoWbbJrDe2QYUTbGWgRN-zGH1vKavKA@z> (raw)
In-Reply-To: <20191107151109.23261-4-jasowang@redhat.com>

On Thu,  7 Nov 2019 23:11:06 +0800
Jason Wang <jasowang@redhat.com> wrote:

> Currently, except for the create and remove, the rest of
> mdev_parent_ops is designed for vfio-mdev driver only and may not help
> for kernel mdev driver. With the help of class id, this patch
> introduces device specific callbacks inside mdev_device
> structure. This allows different set of callback to be used by
> vfio-mdev and virtio-mdev.
> 
> Reviewed-by: Parav Pandit <parav@mellanox.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  .../driver-api/vfio-mediated-device.rst       | 35 +++++++++----
>  MAINTAINERS                                   |  1 +
>  drivers/gpu/drm/i915/gvt/kvmgt.c              | 18 ++++---
>  drivers/s390/cio/vfio_ccw_ops.c               | 18 ++++---
>  drivers/s390/crypto/vfio_ap_ops.c             | 14 +++--
>  drivers/vfio/mdev/mdev_core.c                 | 24 ++++++++-
>  drivers/vfio/mdev/mdev_private.h              |  5 ++
>  drivers/vfio/mdev/vfio_mdev.c                 | 37 ++++++-------
>  include/linux/mdev.h                          | 43 ++++-----------
>  include/linux/mdev_vfio_ops.h                 | 52 +++++++++++++++++++
>  samples/vfio-mdev/mbochs.c                    | 20 ++++---
>  samples/vfio-mdev/mdpy.c                      | 20 ++++---
>  samples/vfio-mdev/mtty.c                      | 18 ++++---
>  13 files changed, 206 insertions(+), 99 deletions(-)
>  create mode 100644 include/linux/mdev_vfio_ops.h

You dropped my R-b :(, here it is again:

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-07 15:36 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 15:11 [PATCH V11 0/6] mdev based hardware virtio offloading support Jason Wang
2019-11-07 15:11 ` [Intel-gfx] " Jason Wang
2019-11-07 15:11 ` [PATCH V11 1/6] mdev: class id support Jason Wang
2019-11-07 15:11   ` [Intel-gfx] " Jason Wang
2019-11-07 19:35   ` Kirti Wankhede
2019-11-07 19:35     ` [Intel-gfx] " Kirti Wankhede
2019-11-07 15:11 ` [PATCH V11 2/6] modpost: add support for mdev class id Jason Wang
2019-11-07 15:11   ` [Intel-gfx] " Jason Wang
2019-11-07 19:36   ` Kirti Wankhede
2019-11-07 19:36     ` [Intel-gfx] " Kirti Wankhede
2019-11-07 15:11 ` [PATCH V11 3/6] mdev: introduce device specific ops Jason Wang
2019-11-07 15:11   ` [Intel-gfx] " Jason Wang
2019-11-07 15:36   ` Cornelia Huck [this message]
2019-11-07 15:36     ` Cornelia Huck
2019-11-07 19:39   ` Kirti Wankhede
2019-11-07 19:39     ` [Intel-gfx] " Kirti Wankhede
2019-11-07 15:11 ` [PATCH V11 4/6] mdev: introduce virtio device and its device ops Jason Wang
2019-11-07 15:11   ` [Intel-gfx] " Jason Wang
2019-11-07 19:42   ` Kirti Wankhede
2019-11-07 19:42     ` [Intel-gfx] " Kirti Wankhede
2019-11-07 15:11 ` [PATCH V11 5/6] virtio: introduce a mdev based transport Jason Wang
2019-11-07 15:11   ` [Intel-gfx] " Jason Wang
2019-11-07 15:11 ` [PATCH V11 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang
2019-11-07 15:11   ` [Intel-gfx] " Jason Wang
2019-11-07 15:34   ` Cornelia Huck
2019-11-07 15:34     ` [Intel-gfx] " Cornelia Huck
2019-11-07 15:54 ` [PATCH V11 0/6] mdev based hardware virtio offloading support Michael S. Tsirkin
2019-11-07 15:54   ` [Intel-gfx] " Michael S. Tsirkin
2019-11-07 18:31 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-07 18:31   ` [Intel-gfx] " Patchwork
2019-11-07 18:52 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-07 18:52   ` [Intel-gfx] " Patchwork
2019-11-09  0:07 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-09  0:07   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107163606.293a4f62.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=airlied@linux.ie \
    --cc=alex.williamson@redhat.com \
    --cc=cunming.liang@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=farman@linux.ibm.com \
    --cc=gor@linux.ibm.c \
    --cc=haotian.wang@sifive.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jasowang@redhat.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwankhede@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=oberpar@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=rob.miller@broadcom.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=sebott@linux.ibm.com \
    --cc=tiwei.bie@intel.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xiao.w.wang@intel.com \
    --cc=zhenyuw@linux.intel.com \
    --cc=zhi.a.wang@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox