From: Sean Paul <sean@poorly.run>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RESEND 0/8] drm/print: cleanup and new drm_device based logging
Date: Tue, 12 Nov 2019 10:21:34 -0500 [thread overview]
Message-ID: <20191112152134.GA25787@art_vandelay> (raw)
In-Reply-To: <cover.1572258935.git.jani.nikula@intel.com>
On Mon, Oct 28, 2019 at 12:38:14PM +0200, Jani Nikula wrote:
> Resend of [1]; I may have rebased but I'm not sure anymore...
>
> For starters some fairly benign cleanup, and a proposal for new struct
> drm_device based drm logging macros analoguous to core kernel struct
> device based macros.
>
> Please let's at least get the first 7 reviewed/acked/merged, shall we?
>
Acked-by: Sean Paul <sean@poorly.run>
>
> BR,
> Jani.
>
>
> [1] https://patchwork.freedesktop.org/series/67795/
>
>
> Jani Nikula (8):
> drm/i915: use drm_debug_enabled() to check for debug categories
> drm/nouveau: use drm_debug_enabled() to check for debug categories
> drm/amdgpu: use drm_debug_enabled() to check for debug categories
> drm/print: rename drm_debug to __drm_debug to discourage use
> drm/print: underscore prefix functions that should be private to print
> drm/print: convert debug category macros into an enum
> drm/print: group logging functions by prink or device based
> drm/print: introduce new struct drm_device based logging macros
>
> drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 +-
> drivers/gpu/drm/drm_print.c | 18 +-
> drivers/gpu/drm/i915/display/intel_display.c | 4 +-
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> drivers/gpu/drm/i915/i915_drv.c | 2 +-
> drivers/gpu/drm/i915/i915_gem.h | 2 +-
> drivers/gpu/drm/i915/i915_utils.c | 2 +-
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> drivers/gpu/drm/nouveau/dispnv50/disp.h | 4 +-
> drivers/gpu/drm/nouveau/nouveau_drv.h | 4 +-
> include/drm/drm_print.h | 304 ++++++++++++-------
> 11 files changed, 224 insertions(+), 124 deletions(-)
>
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH RESEND 0/8] drm/print: cleanup and new drm_device based logging
Date: Tue, 12 Nov 2019 10:21:34 -0500 [thread overview]
Message-ID: <20191112152134.GA25787@art_vandelay> (raw)
Message-ID: <20191112152134.GHeRECbfEOscF9TZtGvJcgHTMDGHhjhLvlZrEy5QxzQ@z> (raw)
In-Reply-To: <cover.1572258935.git.jani.nikula@intel.com>
On Mon, Oct 28, 2019 at 12:38:14PM +0200, Jani Nikula wrote:
> Resend of [1]; I may have rebased but I'm not sure anymore...
>
> For starters some fairly benign cleanup, and a proposal for new struct
> drm_device based drm logging macros analoguous to core kernel struct
> device based macros.
>
> Please let's at least get the first 7 reviewed/acked/merged, shall we?
>
Acked-by: Sean Paul <sean@poorly.run>
>
> BR,
> Jani.
>
>
> [1] https://patchwork.freedesktop.org/series/67795/
>
>
> Jani Nikula (8):
> drm/i915: use drm_debug_enabled() to check for debug categories
> drm/nouveau: use drm_debug_enabled() to check for debug categories
> drm/amdgpu: use drm_debug_enabled() to check for debug categories
> drm/print: rename drm_debug to __drm_debug to discourage use
> drm/print: underscore prefix functions that should be private to print
> drm/print: convert debug category macros into an enum
> drm/print: group logging functions by prink or device based
> drm/print: introduce new struct drm_device based logging macros
>
> drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 +-
> drivers/gpu/drm/drm_print.c | 18 +-
> drivers/gpu/drm/i915/display/intel_display.c | 4 +-
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> drivers/gpu/drm/i915/i915_drv.c | 2 +-
> drivers/gpu/drm/i915/i915_gem.h | 2 +-
> drivers/gpu/drm/i915/i915_utils.c | 2 +-
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> drivers/gpu/drm/nouveau/dispnv50/disp.h | 4 +-
> drivers/gpu/drm/nouveau/nouveau_drv.h | 4 +-
> include/drm/drm_print.h | 304 ++++++++++++-------
> 11 files changed, 224 insertions(+), 124 deletions(-)
>
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-12 15:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 10:38 [PATCH RESEND 0/8] drm/print: cleanup and new drm_device based logging Jani Nikula
2019-10-28 10:38 ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38 ` [PATCH RESEND 1/8] drm/i915: use drm_debug_enabled() to check for debug categories Jani Nikula
2019-10-28 10:38 ` [Intel-gfx] " Jani Nikula
[not found] ` <cover.1572258935.git.jani.nikula-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-10-28 10:38 ` [PATCH RESEND 2/8] drm/nouveau: " Jani Nikula
2019-10-28 10:38 ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38 ` [PATCH RESEND 3/8] drm/amdgpu: " Jani Nikula
2019-10-28 10:38 ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38 ` [PATCH RESEND 4/8] drm/print: rename drm_debug to __drm_debug to discourage use Jani Nikula
2019-10-28 10:38 ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38 ` [PATCH RESEND 5/8] drm/print: underscore prefix functions that should be private to print Jani Nikula
2019-10-28 10:38 ` [Intel-gfx] " Jani Nikula
2019-11-01 20:16 ` Rodrigo Vivi
2019-11-01 20:16 ` [Intel-gfx] " Rodrigo Vivi
2019-10-28 10:38 ` [PATCH RESEND 6/8] drm/print: convert debug category macros into an enum Jani Nikula
2019-10-28 10:38 ` [Intel-gfx] " Jani Nikula
2019-10-29 9:02 ` Joonas Lahtinen
2019-10-29 9:02 ` [Intel-gfx] " Joonas Lahtinen
2019-10-29 9:27 ` Jani Nikula
2019-10-29 9:27 ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38 ` [PATCH RESEND 7/8] drm/print: group logging functions by prink or device based Jani Nikula
2019-10-28 10:38 ` [Intel-gfx] " Jani Nikula
2019-11-01 20:25 ` Rodrigo Vivi
2019-11-01 20:25 ` [Intel-gfx] " Rodrigo Vivi
2019-10-28 10:38 ` [PATCH RESEND 8/8] drm/print: introduce new struct drm_device based logging macros Jani Nikula
2019-10-28 10:38 ` [Intel-gfx] " Jani Nikula
2019-10-28 17:09 ` Ville Syrjälä
2019-10-28 17:09 ` [Intel-gfx] " Ville Syrjälä
2019-11-01 20:27 ` Rodrigo Vivi
2019-11-01 20:27 ` [Intel-gfx] " Rodrigo Vivi
2019-10-28 13:28 ` ✗ Fi.CI.CHECKPATCH: warning for drm/print: cleanup and new drm_device based logging (rev2) Patchwork
2019-10-28 13:28 ` [Intel-gfx] " Patchwork
2019-10-28 13:49 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-28 13:49 ` [Intel-gfx] " Patchwork
2019-10-28 18:49 ` ✗ Fi.CI.CHECKPATCH: warning for drm/print: cleanup and new drm_device based logging (rev3) Patchwork
2019-10-28 18:49 ` [Intel-gfx] " Patchwork
2019-10-28 19:30 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-28 19:30 ` [Intel-gfx] " Patchwork
2019-10-29 13:57 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-29 13:57 ` [Intel-gfx] " Patchwork
2019-11-12 15:21 ` Sean Paul [this message]
2019-11-12 15:21 ` [Intel-gfx] [PATCH RESEND 0/8] drm/print: cleanup and new drm_device based logging Sean Paul
2019-11-14 12:27 ` Jani Nikula
2019-11-14 12:27 ` [Intel-gfx] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112152134.GA25787@art_vandelay \
--to=sean@poorly.run \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox