From: Boris Brezillon <boris.brezillon@collabora.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Sam Ravnborg <sam@ravnborg.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/8] drm/atmel: ditch fb_create wrapper
Date: Fri, 15 Nov 2019 10:33:24 +0100 [thread overview]
Message-ID: <20191115103324.1fbeca63@collabora.com> (raw)
In-Reply-To: <20191115092120.4445-3-daniel.vetter@ffwll.ch>
On Fri, 15 Nov 2019 10:21:14 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Spotted while looking through them all.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Boris Brezillon <bbrezillon@kernel.org>
Acked-by: Boris Brezillon <boris.brezillon@collabora.com>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> index 92640298ad41..8dc917a1270b 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> @@ -557,12 +557,6 @@ static irqreturn_t atmel_hlcdc_dc_irq_handler(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> -static struct drm_framebuffer *atmel_hlcdc_fb_create(struct drm_device *dev,
> - struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd)
> -{
> - return drm_gem_fb_create(dev, file_priv, mode_cmd);
> -}
> -
> struct atmel_hlcdc_dc_commit {
> struct work_struct work;
> struct drm_device *dev;
> @@ -657,7 +651,7 @@ static int atmel_hlcdc_dc_atomic_commit(struct drm_device *dev,
> }
>
> static const struct drm_mode_config_funcs mode_config_funcs = {
> - .fb_create = atmel_hlcdc_fb_create,
> + .fb_create = drm_gem_fb_create,
> .atomic_check = drm_atomic_helper_check,
> .atomic_commit = atmel_hlcdc_dc_atomic_commit,
> };
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Sam Ravnborg <sam@ravnborg.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-gfx] [PATCH 2/8] drm/atmel: ditch fb_create wrapper
Date: Fri, 15 Nov 2019 10:33:24 +0100 [thread overview]
Message-ID: <20191115103324.1fbeca63@collabora.com> (raw)
Message-ID: <20191115093324.uHksbwqWE76ulH2w0l_SB3X7LUN6hKjQXxdSuyK5gtY@z> (raw)
In-Reply-To: <20191115092120.4445-3-daniel.vetter@ffwll.ch>
On Fri, 15 Nov 2019 10:21:14 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Spotted while looking through them all.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Boris Brezillon <bbrezillon@kernel.org>
Acked-by: Boris Brezillon <boris.brezillon@collabora.com>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> index 92640298ad41..8dc917a1270b 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> @@ -557,12 +557,6 @@ static irqreturn_t atmel_hlcdc_dc_irq_handler(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> -static struct drm_framebuffer *atmel_hlcdc_fb_create(struct drm_device *dev,
> - struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd)
> -{
> - return drm_gem_fb_create(dev, file_priv, mode_cmd);
> -}
> -
> struct atmel_hlcdc_dc_commit {
> struct work_struct work;
> struct drm_device *dev;
> @@ -657,7 +651,7 @@ static int atmel_hlcdc_dc_atomic_commit(struct drm_device *dev,
> }
>
> static const struct drm_mode_config_funcs mode_config_funcs = {
> - .fb_create = atmel_hlcdc_fb_create,
> + .fb_create = drm_gem_fb_create,
> .atomic_check = drm_atomic_helper_check,
> .atomic_commit = atmel_hlcdc_dc_atomic_commit,
> };
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-15 9:33 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 9:21 [PATCH 0/8] fb_create drive-through cleanups Daniel Vetter
2019-11-15 9:21 ` [Intel-gfx] " Daniel Vetter
2019-11-15 9:21 ` [PATCH 1/8] drm/fb: More paranoia in addfb checks Daniel Vetter
2019-11-15 9:21 ` [Intel-gfx] " Daniel Vetter
2019-11-15 10:49 ` Pekka Paalanen
2019-11-15 10:49 ` [Intel-gfx] " Pekka Paalanen
2019-11-15 12:44 ` Ville Syrjälä
2019-11-15 12:44 ` Ville Syrjälä
2019-11-15 15:26 ` Daniel Vetter
2019-11-15 15:26 ` Daniel Vetter
2019-11-15 9:21 ` [PATCH 2/8] drm/atmel: ditch fb_create wrapper Daniel Vetter
2019-11-15 9:21 ` [Intel-gfx] " Daniel Vetter
2019-11-15 9:33 ` Boris Brezillon [this message]
2019-11-15 9:33 ` Boris Brezillon
2019-11-19 21:22 ` Daniel Vetter
2019-11-19 21:22 ` [Intel-gfx] " Daniel Vetter
2019-11-23 8:49 ` Sam Ravnborg
2019-11-23 8:49 ` [Intel-gfx] " Sam Ravnborg
2019-11-15 9:21 ` [PATCH 3/8] drm/mediatek: don't open-code drm_gem_fb_create Daniel Vetter
2019-11-15 9:21 ` [Intel-gfx] " Daniel Vetter
2019-11-22 7:42 ` CK Hu
2019-11-22 7:42 ` [Intel-gfx] " CK Hu
2019-11-22 17:09 ` Daniel Vetter
2019-11-22 17:09 ` [Intel-gfx] " Daniel Vetter
2019-11-15 9:21 ` [PATCH 4/8] drm/rockchip: Use drm_gem_fb_create_with_dirty Daniel Vetter
2019-11-15 9:21 ` [Intel-gfx] " Daniel Vetter
2019-11-27 11:45 ` Andrzej Pietrasiewicz
2019-11-27 11:45 ` [Intel-gfx] " Andrzej Pietrasiewicz
2019-11-27 17:33 ` Andrzej Pietrasiewicz
2019-11-27 17:33 ` [Intel-gfx] " Andrzej Pietrasiewicz
2019-11-27 17:54 ` Daniel Vetter
2019-11-27 17:54 ` [Intel-gfx] " Daniel Vetter
2019-11-15 9:21 ` [PATCH 5/8] drm/tilcdc: Drop drm_gem_fb_create wrapper Daniel Vetter
2019-11-15 9:21 ` [Intel-gfx] " Daniel Vetter
2019-11-15 13:21 ` Jyri Sarha
2019-11-15 13:21 ` [Intel-gfx] " Jyri Sarha
2019-11-19 21:25 ` Daniel Vetter
2019-11-19 21:25 ` [Intel-gfx] " Daniel Vetter
2019-11-15 9:21 ` [PATCH 6/8] drm/xen: Simplify fb_create Daniel Vetter
2019-11-15 9:21 ` [Intel-gfx] " Daniel Vetter
2019-11-15 10:33 ` Oleksandr Andrushchenko
2019-11-15 10:33 ` [Intel-gfx] " Oleksandr Andrushchenko
2019-11-19 21:25 ` Daniel Vetter
2019-11-19 21:25 ` [Intel-gfx] " Daniel Vetter
2019-11-15 9:21 ` [PATCH 7/8] drm/hibmc: Use drm_gem_fb_create Daniel Vetter
2019-11-15 9:21 ` [Intel-gfx] " Daniel Vetter
2019-11-22 8:09 ` Thomas Zimmermann
2019-11-22 8:09 ` [Intel-gfx] " Thomas Zimmermann
2019-11-22 8:16 ` Thomas Zimmermann
2019-11-22 8:16 ` [Intel-gfx] " Thomas Zimmermann
2019-11-22 9:12 ` Daniel Vetter
2019-11-22 9:12 ` [Intel-gfx] " Daniel Vetter
2019-11-15 9:21 ` [PATCH 8/8] drm/todo: Add entry for fb funcs related cleanups Daniel Vetter
2019-11-15 9:21 ` [Intel-gfx] " Daniel Vetter
2019-11-20 10:46 ` Daniel Vetter
2019-11-20 10:46 ` [Intel-gfx] " Daniel Vetter
2019-11-15 9:30 ` ✗ Fi.CI.CHECKPATCH: warning for fb_create drive-through cleanups Patchwork
2019-11-15 9:30 ` [Intel-gfx] " Patchwork
2019-11-15 9:50 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-11-15 9:50 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115103324.1fbeca63@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox