Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 07/10] drm/i915: Pass dev_priv to cpt_verify_modeset()
Date: Mon, 18 Nov 2019 18:44:27 +0200	[thread overview]
Message-ID: <20191118164430.27265-8-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20191118164430.27265-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Get rid of the last 'dev' usage in ironlake_crtc_enable() by
passing dev_priv to cpt_verify_modeset().

Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 68a7e5d467ff..556b31bf2fb0 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -5474,9 +5474,9 @@ static void lpt_pch_enable(const struct intel_atomic_state *state,
 	lpt_enable_pch_transcoder(dev_priv, cpu_transcoder);
 }
 
-static void cpt_verify_modeset(struct drm_device *dev, enum pipe pipe)
+static void cpt_verify_modeset(struct drm_i915_private *dev_priv,
+			       enum pipe pipe)
 {
-	struct drm_i915_private *dev_priv = to_i915(dev);
 	i915_reg_t dslreg = PIPEDSL(pipe);
 	u32 temp;
 
@@ -6550,7 +6550,7 @@ static void ironlake_crtc_enable(struct intel_crtc_state *pipe_config,
 	intel_encoders_enable(state, intel_crtc);
 
 	if (HAS_PCH_CPT(dev_priv))
-		cpt_verify_modeset(dev, intel_crtc->pipe);
+		cpt_verify_modeset(dev_priv, pipe);
 
 	/*
 	 * Must wait for vblank to avoid spurious PCH FIFO underruns.
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v2 07/10] drm/i915: Pass dev_priv to cpt_verify_modeset()
Date: Mon, 18 Nov 2019 18:44:27 +0200	[thread overview]
Message-ID: <20191118164430.27265-8-ville.syrjala@linux.intel.com> (raw)
Message-ID: <20191118164427.CXJddF9AJvynuFrZi8QNFrjoheETXihG4wFA41V3eyE@z> (raw)
In-Reply-To: <20191118164430.27265-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Get rid of the last 'dev' usage in ironlake_crtc_enable() by
passing dev_priv to cpt_verify_modeset().

Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 68a7e5d467ff..556b31bf2fb0 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -5474,9 +5474,9 @@ static void lpt_pch_enable(const struct intel_atomic_state *state,
 	lpt_enable_pch_transcoder(dev_priv, cpu_transcoder);
 }
 
-static void cpt_verify_modeset(struct drm_device *dev, enum pipe pipe)
+static void cpt_verify_modeset(struct drm_i915_private *dev_priv,
+			       enum pipe pipe)
 {
-	struct drm_i915_private *dev_priv = to_i915(dev);
 	i915_reg_t dslreg = PIPEDSL(pipe);
 	u32 temp;
 
@@ -6550,7 +6550,7 @@ static void ironlake_crtc_enable(struct intel_crtc_state *pipe_config,
 	intel_encoders_enable(state, intel_crtc);
 
 	if (HAS_PCH_CPT(dev_priv))
-		cpt_verify_modeset(dev, intel_crtc->pipe);
+		cpt_verify_modeset(dev_priv, pipe);
 
 	/*
 	 * Must wait for vblank to avoid spurious PCH FIFO underruns.
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-18 16:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 16:44 [PATCH v2 00/10] drm/i915: Cleanups around .crtc_enable/disable() Ville Syrjala
2019-11-18 16:44 ` [Intel-gfx] " Ville Syrjala
2019-11-18 16:44 ` [PATCH v2 01/10] drm/i915: Change intel_encoders_<hook>() calling convention Ville Syrjala
2019-11-18 16:44   ` [Intel-gfx] " Ville Syrjala
2019-11-18 16:44 ` [PATCH v2 02/10] drm/i915: Add intel_crtc_vblank_off() Ville Syrjala
2019-11-18 16:44   ` [Intel-gfx] " Ville Syrjala
2019-11-18 16:44 ` [PATCH v2 03/10] drm/i915: Move assert_vblank_disabled() into intel_crtc_vblank_on() Ville Syrjala
2019-11-18 16:44   ` [Intel-gfx] " Ville Syrjala
2019-11-18 16:44 ` [PATCH v2 04/10] drm/i915: Move crtc_state to tighter scope Ville Syrjala
2019-11-18 16:44   ` [Intel-gfx] " Ville Syrjala
2019-11-18 16:44 ` [PATCH v2 05/10] drm/i915: Pass intel_crtc to ironlake_fdi_disable() Ville Syrjala
2019-11-18 16:44   ` [Intel-gfx] " Ville Syrjala
2019-11-18 16:44 ` [PATCH v2 06/10] drm/i915: Change watermark hook calling convention Ville Syrjala
2019-11-18 16:44   ` [Intel-gfx] " Ville Syrjala
2019-11-18 16:44 ` Ville Syrjala [this message]
2019-11-18 16:44   ` [Intel-gfx] [PATCH v2 07/10] drm/i915: Pass dev_priv to cpt_verify_modeset() Ville Syrjala
2019-11-18 16:44 ` [PATCH v2 08/10] drm/i915: s/intel_crtc/crtc/ in .crtc_enable() and .crtc_disable() Ville Syrjala
2019-11-18 16:44   ` [Intel-gfx] " Ville Syrjala
2019-11-18 16:44 ` [PATCH v2 09/10] drm/i915: s/pipe_config/new_crtc_state/ in .crtc_enable() Ville Syrjala
2019-11-18 16:44   ` [Intel-gfx] " Ville Syrjala
2019-11-18 16:44 ` [PATCH v2 10/10] drm/i915: Change .crtc_enable/disable() calling convention Ville Syrjala
2019-11-18 16:44   ` [Intel-gfx] " Ville Syrjala
2019-11-18 20:00 ` ✗ Fi.CI.BAT: failure for drm/i915: Cleanups around .crtc_enable/disable() (rev3) Patchwork
2019-11-18 20:00   ` [Intel-gfx] " Patchwork
2019-11-19 14:27   ` Ville Syrjälä
2019-11-19 14:27     ` [Intel-gfx] " Ville Syrjälä
2019-11-19 15:22 ` ✓ Fi.CI.BAT: success for drm/i915: Cleanups around .crtc_enable/disable() (rev4) Patchwork
2019-11-19 15:22   ` [Intel-gfx] " Patchwork
2019-11-20  0:02 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-20  0:02   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191118164430.27265-8-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox