From: Ramalingam C <ramalingam.c@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/i915: Skip the Wa_1604555607 verification
Date: Wed, 20 Nov 2019 23:03:44 +0530 [thread overview]
Message-ID: <20191120173343.GA1084@intel.com> (raw)
In-Reply-To: <748e3937-c8d3-efa4-15c1-f0a4b31d27f3@linux.intel.com>
On 2019-11-20 at 16:55:35 +0000, Tvrtko Ursulin wrote:
>
> On 20/11/2019 16:40, Ramalingam C wrote:
> > At TGL A0 stepping, FF_MODE2 register read back is broken, hence
> > disabling the WA verification.
> >
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> > index 8c441bf10cb1..0a3034e841c4 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> > @@ -580,7 +580,10 @@ static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine,
> > val = intel_uncore_read(engine->uncore, FF_MODE2);
> > val &= ~FF_MODE2_TDS_TIMER_MASK;
> > val |= FF_MODE2_TDS_TIMER_128;
> > - wa_write_masked_or(wal, FF_MODE2, FF_MODE2_TDS_TIMER_MASK, val, true);
> > + /* At TGL A0 silicon FF_MODE2 reg read is not functional. */
> > + wa_write_masked_or(wal, FF_MODE2, FF_MODE2_TDS_TIMER_MASK, val,
> > + !IS_TGL_REVID(engine->uncore->i915, 0,
> > + TGL_REVID_A0));
>
> Why do you need the previous patch and can't just re-add the helper (we had
> it at some point) which creates the workaround with wa->read = 0 directly?
>
> wa_write_masked_or__no_verify, or __wa_write_masked_or with read mask
> explicitly passed in?
Thanks Tvrtko. That helped to avoid many changes across file.
implemented wa_write_masked_or__no_verify
-Ram
>
> Regards,
>
> Tvrtko
>
> > }
> > static void
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Ramalingam C <ramalingam.c@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: Skip the Wa_1604555607 verification
Date: Wed, 20 Nov 2019 23:03:44 +0530 [thread overview]
Message-ID: <20191120173343.GA1084@intel.com> (raw)
Message-ID: <20191120173344.RUJrcV8sRd7-2yY2rxRCYXViCkcKofHAdkRNV1aSHWE@z> (raw)
In-Reply-To: <748e3937-c8d3-efa4-15c1-f0a4b31d27f3@linux.intel.com>
On 2019-11-20 at 16:55:35 +0000, Tvrtko Ursulin wrote:
>
> On 20/11/2019 16:40, Ramalingam C wrote:
> > At TGL A0 stepping, FF_MODE2 register read back is broken, hence
> > disabling the WA verification.
> >
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> > index 8c441bf10cb1..0a3034e841c4 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> > @@ -580,7 +580,10 @@ static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine,
> > val = intel_uncore_read(engine->uncore, FF_MODE2);
> > val &= ~FF_MODE2_TDS_TIMER_MASK;
> > val |= FF_MODE2_TDS_TIMER_128;
> > - wa_write_masked_or(wal, FF_MODE2, FF_MODE2_TDS_TIMER_MASK, val, true);
> > + /* At TGL A0 silicon FF_MODE2 reg read is not functional. */
> > + wa_write_masked_or(wal, FF_MODE2, FF_MODE2_TDS_TIMER_MASK, val,
> > + !IS_TGL_REVID(engine->uncore->i915, 0,
> > + TGL_REVID_A0));
>
> Why do you need the previous patch and can't just re-add the helper (we had
> it at some point) which creates the workaround with wa->read = 0 directly?
>
> wa_write_masked_or__no_verify, or __wa_write_masked_or with read mask
> explicitly passed in?
Thanks Tvrtko. That helped to avoid many changes across file.
implemented wa_write_masked_or__no_verify
-Ram
>
> Regards,
>
> Tvrtko
>
> > }
> > static void
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-20 17:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 16:40 [PATCH 0/3] Wa_1604555607 implementation and verification skip Ramalingam C
2019-11-20 16:40 ` [Intel-gfx] " Ramalingam C
2019-11-20 16:40 ` [PATCH 1/3] drm/i915/tgl: Implement Wa_1604555607 Ramalingam C
2019-11-20 16:40 ` [Intel-gfx] " Ramalingam C
2019-11-20 16:40 ` [PATCH 2/3] drm/i915: marking readability of WA registers Ramalingam C
2019-11-20 16:40 ` [Intel-gfx] " Ramalingam C
2019-11-20 16:40 ` [PATCH 3/3] drm/i915: Skip the Wa_1604555607 verification Ramalingam C
2019-11-20 16:40 ` [Intel-gfx] " Ramalingam C
2019-11-20 16:55 ` Tvrtko Ursulin
2019-11-20 16:55 ` [Intel-gfx] " Tvrtko Ursulin
2019-11-20 17:33 ` Ramalingam C [this message]
2019-11-20 17:33 ` Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120173343.GA1084@intel.com \
--to=ramalingam.c@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox