From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gt: Mark the execlists->active as the primary volatile access
Date: Mon, 25 Nov 2019 12:51:31 +0200 [thread overview]
Message-ID: <20191125105131.GA1815@intel.intel> (raw)
In-Reply-To: <20191123174946.891350-1-chris@chris-wilson.co.uk>
Hi Chris,
On Sat, Nov 23, 2019 at 05:49:46PM +0000, Chris Wilson wrote:
> Since we want to do a lockless read of the current active request, and
> that request is written to by process_csb also without serialisation, we
> need to instruct gcc to take care in reading the pointer itself.
>
> Otherwise, we have observed execlists_active() to report 0x40.
>
> [ 2400.760381] igt/para-4098 1..s. 2376479300us : process_csb: rcs0 cs-irq head=3, tail=4
> [ 2400.760826] igt/para-4098 1..s. 2376479303us : process_csb: rcs0 csb[4]: status=0x00000001:0x00000000
> [ 2400.761271] igt/para-4098 1..s. 2376479306us : trace_ports: rcs0: promote { b9c59:2622, b9c55:2624 }
> [ 2400.761726] igt/para-4097 0d... 2376479311us : __i915_schedule: rcs0: -2147483648->3, inflight:0000000000000040, rq:ffff888208c1e940
>
> which is impossible!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Tested-by: Andi Shyti <andi.shyti@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Mark the execlists->active as the primary volatile access
Date: Mon, 25 Nov 2019 12:51:31 +0200 [thread overview]
Message-ID: <20191125105131.GA1815@intel.intel> (raw)
Message-ID: <20191125105131.rpx27tdg1aUq5JZ06a1MrxchPaw0agkIZM2ZSRZJB9A@z> (raw)
In-Reply-To: <20191123174946.891350-1-chris@chris-wilson.co.uk>
Hi Chris,
On Sat, Nov 23, 2019 at 05:49:46PM +0000, Chris Wilson wrote:
> Since we want to do a lockless read of the current active request, and
> that request is written to by process_csb also without serialisation, we
> need to instruct gcc to take care in reading the pointer itself.
>
> Otherwise, we have observed execlists_active() to report 0x40.
>
> [ 2400.760381] igt/para-4098 1..s. 2376479300us : process_csb: rcs0 cs-irq head=3, tail=4
> [ 2400.760826] igt/para-4098 1..s. 2376479303us : process_csb: rcs0 csb[4]: status=0x00000001:0x00000000
> [ 2400.761271] igt/para-4098 1..s. 2376479306us : trace_ports: rcs0: promote { b9c59:2622, b9c55:2624 }
> [ 2400.761726] igt/para-4097 0d... 2376479311us : __i915_schedule: rcs0: -2147483648->3, inflight:0000000000000040, rq:ffff888208c1e940
>
> which is impossible!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Tested-by: Andi Shyti <andi.shyti@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-25 10:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 11:03 [PATCH] drm/i915/gt: Mark the execlists->active as the primary volatile access Chris Wilson
2019-11-23 11:03 ` [Intel-gfx] " Chris Wilson
2019-11-23 11:37 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-23 11:37 ` [Intel-gfx] " Patchwork
2019-11-23 17:35 ` [PATCH] " Chris Wilson
2019-11-23 17:35 ` [Intel-gfx] " Chris Wilson
2019-11-23 17:46 ` Chris Wilson
2019-11-23 17:46 ` [Intel-gfx] " Chris Wilson
2019-11-23 17:49 ` Chris Wilson
2019-11-23 17:49 ` [Intel-gfx] " Chris Wilson
2019-11-23 18:05 ` Chris Wilson
2019-11-23 18:05 ` [Intel-gfx] " Chris Wilson
2019-11-25 10:51 ` Andi Shyti [this message]
2019-11-25 10:51 ` Andi Shyti
2019-11-23 17:58 ` ✗ Fi.CI.BAT: failure for drm/i915/gt: Mark the execlists->active as the primary volatile access (rev2) Patchwork
2019-11-23 17:58 ` [Intel-gfx] " Patchwork
2019-11-23 18:26 ` ✗ Fi.CI.BAT: failure for drm/i915/gt: Mark the execlists->active as the primary volatile access (rev4) Patchwork
2019-11-23 18:26 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125105131.GA1815@intel.intel \
--to=andi.shyti@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox