From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/execlists: Fixup cancel_port_requests()
Date: Mon, 25 Nov 2019 15:13:56 +0200 [thread overview]
Message-ID: <20191125131356.GB1815@intel.intel> (raw)
In-Reply-To: <20191125112520.1760492-1-chris@chris-wilson.co.uk>
Hi Chris,
> /* Mark the end of active before we overwrite *active */
> - WRITE_ONCE(execlists->active, execlists->pending);
> -
> - for (port = execlists->active; (rq = *port); port++)
> - execlists_schedule_out(rq);
> - execlists->active =
> - memset(execlists->inflight, 0, sizeof(execlists->inflight));
> + for (port = xchg(&execlists->active, execlists->pending); *port; port++)
> + execlists_schedule_out(*port);
> + WRITE_ONCE(execlists->active,
> + memset(execlists->inflight, 0, sizeof(execlists->inflight)));
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/execlists: Fixup cancel_port_requests()
Date: Mon, 25 Nov 2019 15:13:56 +0200 [thread overview]
Message-ID: <20191125131356.GB1815@intel.intel> (raw)
Message-ID: <20191125131356.rIYKJZrut-bz4lzvB1xBGDmcNJeCv8G3HX0sCRXwtwk@z> (raw)
In-Reply-To: <20191125112520.1760492-1-chris@chris-wilson.co.uk>
Hi Chris,
> /* Mark the end of active before we overwrite *active */
> - WRITE_ONCE(execlists->active, execlists->pending);
> -
> - for (port = execlists->active; (rq = *port); port++)
> - execlists_schedule_out(rq);
> - execlists->active =
> - memset(execlists->inflight, 0, sizeof(execlists->inflight));
> + for (port = xchg(&execlists->active, execlists->pending); *port; port++)
> + execlists_schedule_out(*port);
> + WRITE_ONCE(execlists->active,
> + memset(execlists->inflight, 0, sizeof(execlists->inflight)));
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-25 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 11:25 [PATCH] drm/i915/execlists: Fixup cancel_port_requests() Chris Wilson
2019-11-25 11:25 ` [Intel-gfx] " Chris Wilson
2019-11-25 13:07 ` Tvrtko Ursulin
2019-11-25 13:07 ` [Intel-gfx] " Tvrtko Ursulin
2019-11-25 13:13 ` Andi Shyti [this message]
2019-11-25 13:13 ` Andi Shyti
2019-11-25 14:34 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-11-25 14:34 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125131356.GB1815@intel.intel \
--to=andi.shyti@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox