From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support more QGV points (rev4)
Date: Tue, 26 Nov 2019 18:31:05 +0200 [thread overview]
Message-ID: <20191126163105.GD1208@intel.com> (raw)
In-Reply-To: <157470131319.15532.15154144390739232460@emeril.freedesktop.org>
On Mon, Nov 25, 2019 at 05:01:53PM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Support more QGV points (rev4)
> URL : https://patchwork.freedesktop.org/series/69886/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> d993a329d475 drm/i915: Support more QGV points
> -:45: CHECK:BRACES: braces {} should be used on all arms of this statement
> #45: FILE: drivers/gpu/drm/i915/display/intel_bw.c:279:
> + if (INTEL_GEN(dev_priv) >= 11) {
> [...]
> + }
> [...]
Still has a trivial checkpatch issue. I fixed this while pushing.
Next time please try to fix these before sending the patch.
Also "Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189"
is wrong. It should be "Bugzilla: <link>". dim refused to push due to
this so had to fix this one as well.
Anyways, now pushed to dinq. Thanks for the patch.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support more QGV points (rev4)
Date: Tue, 26 Nov 2019 18:31:05 +0200 [thread overview]
Message-ID: <20191126163105.GD1208@intel.com> (raw)
Message-ID: <20191126163105.rB8B98WLqqrgPZyyq80MwopHgyueyNYk9CXT32laTTo@z> (raw)
In-Reply-To: <157470131319.15532.15154144390739232460@emeril.freedesktop.org>
On Mon, Nov 25, 2019 at 05:01:53PM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Support more QGV points (rev4)
> URL : https://patchwork.freedesktop.org/series/69886/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> d993a329d475 drm/i915: Support more QGV points
> -:45: CHECK:BRACES: braces {} should be used on all arms of this statement
> #45: FILE: drivers/gpu/drm/i915/display/intel_bw.c:279:
> + if (INTEL_GEN(dev_priv) >= 11) {
> [...]
> + }
> [...]
Still has a trivial checkpatch issue. I fixed this while pushing.
Next time please try to fix these before sending the patch.
Also "Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189"
is wrong. It should be "Bugzilla: <link>". dim refused to push due to
this so had to fix this one as well.
Anyways, now pushed to dinq. Thanks for the patch.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-26 16:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 16:08 [PATCH v3] drm/i915: Support more QGV points Stanislav Lisovskiy
2019-11-25 16:08 ` [Intel-gfx] " Stanislav Lisovskiy
2019-11-25 17:01 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support more QGV points (rev4) Patchwork
2019-11-25 17:01 ` [Intel-gfx] " Patchwork
2019-11-26 16:31 ` Ville Syrjälä [this message]
2019-11-26 16:31 ` Ville Syrjälä
2019-11-25 17:25 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-25 17:25 ` [Intel-gfx] " Patchwork
2019-11-26 3:54 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-26 3:54 ` [Intel-gfx] " Patchwork
2019-11-26 8:31 ` Lisovskiy, Stanislav
2019-11-26 8:31 ` [Intel-gfx] " Lisovskiy, Stanislav
2019-11-26 11:49 ` Patchwork
2019-11-26 11:49 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126163105.GD1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox