* [Intel-gfx] [PATCH][next] drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR
@ 2020-01-06 7:01 Gustavo A. R. Silva
2020-01-06 7:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2020-01-06 7:01 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Manasi Navare, Matt Roper
Cc: intel-gfx, linux-kernel, dri-devel, Gustavo A. R. Silva
Fix inconsistent IS_ERR and PTR_ERR in intel_modeset_all_tiles().
The proper pointer to be passed as argument is crtc_state.
This bug was detected with the help of Coccinelle.
Fixes: a603f5bd1691 ("drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index da5266e76738..a96bee699a5e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -14424,7 +14424,7 @@ intel_modeset_all_tiles(struct intel_atomic_state *state, int tile_grp_id)
crtc_state = drm_atomic_get_crtc_state(&state->base,
conn_state->crtc);
if (IS_ERR(crtc_state)) {
- ret = PTR_ERR(conn_state);
+ ret = PTR_ERR(crtc_state);
break;
}
crtc_state->mode_changed = true;
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR 2020-01-06 7:01 [Intel-gfx] [PATCH][next] drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR Gustavo A. R. Silva @ 2020-01-06 7:50 ` Patchwork 2020-01-06 9:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-01-08 11:06 ` [Intel-gfx] [PATCH][next] " Jani Nikula 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2020-01-06 7:50 UTC (permalink / raw) To: Gustavo A. R. Silva; +Cc: intel-gfx == Series Details == Series: drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR URL : https://patchwork.freedesktop.org/series/71642/ State : success == Summary == CI Bug Log - changes from CI_DRM_7680 -> Patchwork_15997 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/index.html Known issues ------------ Here are the changes found in Patchwork_15997 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@reload-with-fault-injection: - fi-skl-6700k2: [PASS][1] -> [INCOMPLETE][2] ([i915#671]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_selftest@live_blt: - fi-bsw-nick: [PASS][3] -> [DMESG-FAIL][4] ([i915#723]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/fi-bsw-nick/igt@i915_selftest@live_blt.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/fi-bsw-nick/igt@i915_selftest@live_blt.html * igt@i915_selftest@live_execlists: - fi-kbl-soraka: [PASS][5] -> [DMESG-FAIL][6] ([i915#656]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/fi-kbl-soraka/igt@i915_selftest@live_execlists.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/fi-kbl-soraka/igt@i915_selftest@live_execlists.html #### Possible fixes #### * igt@i915_selftest@live_active: - fi-icl-y: [DMESG-FAIL][7] ([i915#765]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/fi-icl-y/igt@i915_selftest@live_active.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/fi-icl-y/igt@i915_selftest@live_active.html * igt@i915_selftest@live_blt: - fi-ivb-3770: [DMESG-FAIL][9] ([i915#725]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/fi-ivb-3770/igt@i915_selftest@live_blt.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/fi-ivb-3770/igt@i915_selftest@live_blt.html - fi-hsw-4770: [DMESG-FAIL][11] ([i915#553] / [i915#725]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/fi-hsw-4770/igt@i915_selftest@live_blt.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/fi-hsw-4770/igt@i915_selftest@live_blt.html #### Warnings #### * igt@i915_module_load@reload-with-fault-injection: - fi-skl-lmem: [INCOMPLETE][13] ([i915#671]) -> [DMESG-WARN][14] ([i915#889]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_selftest@live_blt: - fi-hsw-4770r: [DMESG-FAIL][15] ([i915#553] / [i915#725]) -> [DMESG-FAIL][16] ([i915#725]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/fi-hsw-4770r/igt@i915_selftest@live_blt.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/fi-hsw-4770r/igt@i915_selftest@live_blt.html [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553 [i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656 [i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671 [i915#723]: https://gitlab.freedesktop.org/drm/intel/issues/723 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 [i915#765]: https://gitlab.freedesktop.org/drm/intel/issues/765 [i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889 Participating hosts (43 -> 41) ------------------------------ Additional (6): fi-bdw-gvtdvm fi-glk-dsi fi-ilk-650 fi-cfl-8109u fi-kbl-8809g fi-skl-6600u Missing (8): fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-kbl-7500u fi-ctg-p8600 fi-byt-n2820 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7680 -> Patchwork_15997 CI-20190529: 20190529 CI_DRM_7680: b70a5ffaee3192a3d21296a6d68f4a1b4f4cecd5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5357: a555a4b98f90dab655d24bb3d07e9291a8b8dac8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15997: 217fb4660750a9954ed87c200ac50537e43ff0c9 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 217fb4660750 drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR 2020-01-06 7:01 [Intel-gfx] [PATCH][next] drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR Gustavo A. R. Silva 2020-01-06 7:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2020-01-06 9:20 ` Patchwork 2020-01-08 11:06 ` [Intel-gfx] [PATCH][next] " Jani Nikula 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2020-01-06 9:20 UTC (permalink / raw) To: Gustavo A. R. Silva; +Cc: intel-gfx == Series Details == Series: drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR URL : https://patchwork.freedesktop.org/series/71642/ State : success == Summary == CI Bug Log - changes from CI_DRM_7680_full -> Patchwork_15997_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_15997_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@processes: - shard-iclb: [PASS][1] -> [FAIL][2] ([i915#570]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb1/igt@gem_ctx_persistence@processes.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb8/igt@gem_ctx_persistence@processes.html * igt@gem_ctx_persistence@vcs1-queued: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +4 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb4/igt@gem_ctx_persistence@vcs1-queued.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb7/igt@gem_ctx_persistence@vcs1-queued.html * igt@gem_eio@unwedge-stress: - shard-snb: [PASS][5] -> [FAIL][6] ([i915#232]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-snb5/igt@gem_eio@unwedge-stress.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-snb2/igt@gem_eio@unwedge-stress.html * igt@gem_exec_await@wide-contexts: - shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([fdo#111736]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb6/igt@gem_exec_await@wide-contexts.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb6/igt@gem_exec_await@wide-contexts.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#110854]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb4/igt@gem_exec_balancer@smoke.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb7/igt@gem_exec_balancer@smoke.html * igt@gem_exec_reloc@basic-active: - shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([i915#472]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb7/igt@gem_exec_reloc@basic-active.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb9/igt@gem_exec_reloc@basic-active.html * igt@gem_exec_schedule@independent-bsd1: - shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([i915#435]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb6/igt@gem_exec_schedule@independent-bsd1.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb5/igt@gem_exec_schedule@independent-bsd1.html * igt@gem_exec_schedule@preempt-contexts-bsd2: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109276]) +15 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb2/igt@gem_exec_schedule@preempt-contexts-bsd2.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb5/igt@gem_exec_schedule@preempt-contexts-bsd2.html * igt@gem_exec_schedule@wide-bsd: - shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +3 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb7/igt@gem_exec_schedule@wide-bsd.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb1/igt@gem_exec_schedule@wide-bsd.html * igt@gem_exec_suspend@basic-s3: - shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([fdo#111736] / [i915#460]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb8/igt@gem_exec_suspend@basic-s3.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb3/igt@gem_exec_suspend@basic-s3.html * igt@gem_persistent_relocs@forked-interruptible-thrashing: - shard-tglb: [PASS][21] -> [TIMEOUT][22] ([fdo#112126] / [i915#530]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html * igt@gem_persistent_relocs@forked-thrash-inactive: - shard-iclb: [PASS][23] -> [INCOMPLETE][24] ([i915#140] / [i915#530]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb6/igt@gem_persistent_relocs@forked-thrash-inactive.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb6/igt@gem_persistent_relocs@forked-thrash-inactive.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-iclb: [PASS][25] -> [FAIL][26] ([i915#644]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb7/igt@gem_ppgtt@flink-and-close-vma-leak.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb6/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@i915_selftest@live_blt: - shard-hsw: [PASS][27] -> [DMESG-FAIL][28] ([i915#725]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-hsw5/igt@i915_selftest@live_blt.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-hsw5/igt@i915_selftest@live_blt.html * igt@kms_color@pipe-a-ctm-green-to-red: - shard-skl: [PASS][29] -> [FAIL][30] ([i915#129]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-skl3/igt@kms_color@pipe-a-ctm-green-to-red.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-skl6/igt@kms_color@pipe-a-ctm-green-to-red.html * igt@kms_color@pipe-b-ctm-green-to-red: - shard-skl: [PASS][31] -> [DMESG-WARN][32] ([i915#109]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-skl4/igt@kms_color@pipe-b-ctm-green-to-red.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-skl3/igt@kms_color@pipe-b-ctm-green-to-red.html * igt@kms_cursor_legacy@cursora-vs-flipa-legacy: - shard-glk: [PASS][33] -> [INCOMPLETE][34] ([i915#58] / [k.org#198133]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-glk4/igt@kms_cursor_legacy@cursora-vs-flipa-legacy.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-glk4/igt@kms_cursor_legacy@cursora-vs-flipa-legacy.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [PASS][35] -> [FAIL][36] ([i915#79]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-skl10/igt@kms_flip@flip-vs-expired-vblank.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-skl5/igt@kms_flip@flip-vs-expired-vblank.html - shard-kbl: [PASS][37] -> [FAIL][38] ([i915#79]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-kbl6/igt@kms_flip@flip-vs-expired-vblank.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-kbl4/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite: - shard-tglb: [PASS][39] -> [FAIL][40] ([i915#49]) +1 similar issue [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc: - shard-skl: [PASS][41] -> [FAIL][42] ([i915#49]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-apl: [PASS][43] -> [DMESG-WARN][44] ([i915#180]) +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_plane@plane-position-covered-pipe-a-planes: - shard-skl: [PASS][45] -> [FAIL][46] ([i915#247]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-skl3/igt@kms_plane@plane-position-covered-pipe-a-planes.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-skl6/igt@kms_plane@plane-position-covered-pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [PASS][47] -> [FAIL][48] ([fdo#108145]) +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#109441]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html * igt@kms_setmode@basic: - shard-skl: [PASS][51] -> [FAIL][52] ([i915#31]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-skl5/igt@kms_setmode@basic.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-skl10/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-skl: [PASS][53] -> [INCOMPLETE][54] ([i915#69]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-skl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-skl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html * igt@perf_pmu@busy-no-semaphores-vcs1: - shard-iclb: [PASS][55] -> [SKIP][56] ([fdo#112080]) +13 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb1/igt@perf_pmu@busy-no-semaphores-vcs1.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb7/igt@perf_pmu@busy-no-semaphores-vcs1.html #### Possible fixes #### * igt@gem_ctx_isolation@rcs0-s3: - shard-kbl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58] +9 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html * igt@gem_ctx_isolation@vcs1-clean: - shard-iclb: [SKIP][59] ([fdo#109276] / [fdo#112080]) -> [PASS][60] +3 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb6/igt@gem_ctx_isolation@vcs1-clean.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb1/igt@gem_ctx_isolation@vcs1-clean.html * igt@gem_ctx_persistence@rcs0-mixed-process: - shard-apl: [FAIL][61] ([i915#679]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-apl4/igt@gem_ctx_persistence@rcs0-mixed-process.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-apl7/igt@gem_ctx_persistence@rcs0-mixed-process.html * igt@gem_ctx_shared@q-smoketest-vebox: - shard-tglb: [INCOMPLETE][63] ([fdo#111735]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb9/igt@gem_ctx_shared@q-smoketest-vebox.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb8/igt@gem_ctx_shared@q-smoketest-vebox.html * igt@gem_eio@reset-stress: - shard-snb: [FAIL][65] ([i915#232]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-snb6/igt@gem_eio@reset-stress.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-snb5/igt@gem_eio@reset-stress.html * igt@gem_eio@unwedge-stress: - shard-tglb: [INCOMPLETE][67] ([i915#469]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb2/igt@gem_eio@unwedge-stress.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb1/igt@gem_eio@unwedge-stress.html * igt@gem_exec_basic@basic-vcs1: - shard-iclb: [SKIP][69] ([fdo#112080]) -> [PASS][70] +6 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb3/igt@gem_exec_basic@basic-vcs1.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb4/igt@gem_exec_basic@basic-vcs1.html * igt@gem_exec_schedule@independent-bsd2: - shard-iclb: [SKIP][71] ([fdo#109276]) -> [PASS][72] +18 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb5/igt@gem_exec_schedule@independent-bsd2.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb1/igt@gem_exec_schedule@independent-bsd2.html * {igt@gem_exec_schedule@pi-common-bsd}: - shard-iclb: [SKIP][73] ([i915#677]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb2/igt@gem_exec_schedule@pi-common-bsd.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb5/igt@gem_exec_schedule@pi-common-bsd.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [SKIP][75] ([fdo#112146]) -> [PASS][76] +7 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_exec_schedule@preempt-queue-bsd2: - shard-tglb: [INCOMPLETE][77] ([fdo#111606] / [fdo#111677]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb3/igt@gem_exec_schedule@preempt-queue-bsd2.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb7/igt@gem_exec_schedule@preempt-queue-bsd2.html * igt@gem_pipe_control_store_loop@reused-buffer: - shard-tglb: [INCOMPLETE][79] ([i915#707] / [i915#796]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb1/igt@gem_pipe_control_store_loop@reused-buffer.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb5/igt@gem_pipe_control_store_loop@reused-buffer.html * igt@gem_softpin@noreloc-s3: - shard-apl: [DMESG-WARN][81] ([i915#180]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-apl1/igt@gem_softpin@noreloc-s3.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-apl4/igt@gem_softpin@noreloc-s3.html * igt@gem_sync@basic-store-all: - shard-tglb: [INCOMPLETE][83] ([i915#472]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb9/igt@gem_sync@basic-store-all.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb2/igt@gem_sync@basic-store-all.html * igt@i915_selftest@live_gt_timelines: - shard-tglb: [INCOMPLETE][85] ([i915#455]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb1/igt@i915_selftest@live_gt_timelines.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb8/igt@i915_selftest@live_gt_timelines.html * igt@kms_color@pipe-a-ctm-0-75: - shard-skl: [DMESG-WARN][87] ([i915#109]) -> [PASS][88] +1 similar issue [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic: - shard-skl: [FAIL][89] ([IGT#5]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt: - shard-tglb: [FAIL][91] ([i915#49]) -> [PASS][92] +2 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html * igt@kms_psr@psr2_sprite_render: - shard-iclb: [SKIP][93] ([fdo#109441]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb6/igt@kms_psr@psr2_sprite_render.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb2/igt@kms_psr@psr2_sprite_render.html * igt@kms_setmode@basic: - shard-apl: [FAIL][95] ([i915#31]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-apl2/igt@kms_setmode@basic.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-apl3/igt@kms_setmode@basic.html #### Warnings #### * igt@gem_ctx_isolation@vcs1-nonpriv: - shard-iclb: [SKIP][97] ([fdo#109276] / [fdo#112080]) -> [FAIL][98] ([IGT#28]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html * igt@gem_eio@kms: - shard-snb: [INCOMPLETE][99] ([i915#82]) -> [DMESG-WARN][100] ([i915#444]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-snb7/igt@gem_eio@kms.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-snb2/igt@gem_eio@kms.html * igt@i915_pm_dc@dc6-psr: - shard-tglb: [SKIP][101] ([i915#468]) -> [FAIL][102] ([i915#454]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb3/igt@i915_pm_dc@dc6-psr.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb7/igt@i915_pm_dc@dc6-psr.html * igt@kms_atomic_transition@6x-modeset-transitions: - shard-tglb: [SKIP][103] ([fdo#112021]) -> [SKIP][104] ([fdo#112016] / [fdo#112021]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb8/igt@kms_atomic_transition@6x-modeset-transitions.html * igt@kms_atomic_transition@6x-modeset-transitions-nonblocking: - shard-tglb: [SKIP][105] ([fdo#112016] / [fdo#112021]) -> [SKIP][106] ([fdo#112021]) +1 similar issue [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-tglb7/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [DMESG-FAIL][107] ([i915#180] / [i915#54]) -> [FAIL][108] ([i915#54]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7680/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28 [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606 [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677 [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735 [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736 [fdo#112016]: https://bugs.freedesktop.org/show_bug.cgi?id=112016 [fdo#112021]: https://bugs.freedesktop.org/show_bug.cgi?id=112021 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109 [i915#129]: https://gitlab.freedesktop.org/drm/intel/issues/129 [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232 [i915#247]: https://gitlab.freedesktop.org/drm/intel/issues/247 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435 [i915#444]: https://gitlab.freedesktop.org/drm/intel/issues/444 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#455]: https://gitlab.freedesktop.org/drm/intel/issues/455 [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460 [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468 [i915#469]: https://gitlab.freedesktop.org/drm/intel/issues/469 [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570 [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#796]: https://gitlab.freedesktop.org/drm/intel/issues/796 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7680 -> Patchwork_15997 CI-20190529: 20190529 CI_DRM_7680: b70a5ffaee3192a3d21296a6d68f4a1b4f4cecd5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5357: a555a4b98f90dab655d24bb3d07e9291a8b8dac8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15997: 217fb4660750a9954ed87c200ac50537e43ff0c9 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15997/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH][next] drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR 2020-01-06 7:01 [Intel-gfx] [PATCH][next] drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR Gustavo A. R. Silva 2020-01-06 7:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-01-06 9:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2020-01-08 11:06 ` Jani Nikula 2 siblings, 0 replies; 4+ messages in thread From: Jani Nikula @ 2020-01-08 11:06 UTC (permalink / raw) To: Gustavo A. R. Silva, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, Manasi Navare, Matt Roper Cc: intel-gfx, linux-kernel, dri-devel, Gustavo A. R. Silva On Mon, 06 Jan 2020, "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote: > Fix inconsistent IS_ERR and PTR_ERR in intel_modeset_all_tiles(). > > The proper pointer to be passed as argument is crtc_state. > > This bug was detected with the help of Coccinelle. Thanks, already fixed by Dan in commit 953cac3ec55f ("drm/i915: fix an error code in intel_modeset_all_tiles()"). BR, Jani. > > Fixes: a603f5bd1691 ("drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index da5266e76738..a96bee699a5e 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -14424,7 +14424,7 @@ intel_modeset_all_tiles(struct intel_atomic_state *state, int tile_grp_id) > crtc_state = drm_atomic_get_crtc_state(&state->base, > conn_state->crtc); > if (IS_ERR(crtc_state)) { > - ret = PTR_ERR(conn_state); > + ret = PTR_ERR(crtc_state); > break; > } > crtc_state->mode_changed = true; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-08 11:06 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-01-06 7:01 [Intel-gfx] [PATCH][next] drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR Gustavo A. R. Silva 2020-01-06 7:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-01-06 9:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-01-08 11:06 ` [Intel-gfx] [PATCH][next] " Jani Nikula
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox