From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: Do not set master_trans bit in bitmak if INVALID_TRANSCODER
Date: Thu, 23 Jan 2020 20:31:55 +0200 [thread overview]
Message-ID: <20200123183155.GW13686@intel.com> (raw)
In-Reply-To: <2b07d85811faa1a630403742975914bf5fc1c7ec.camel@intel.com>
On Thu, Jan 23, 2020 at 06:25:29PM +0000, Souza, Jose wrote:
> On Wed, 2020-01-22 at 16:24 -0800, Manasi Navare wrote:
> > In the port sync mode, for the master crtc, the master_transcoder is
> > INVALID.
> > In that case since its value is -1, do not set the bit in the
> > bitmask.
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Fixes: d0eed1545fe7 ("drm/i915: Fix post-fastset modeset check for
> > port sync")
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index 878d331b9e8c..79f9054078ea 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -14649,8 +14649,10 @@ static int intel_atomic_check(struct
> > drm_device *dev,
> > }
> >
> > if (is_trans_port_sync_mode(new_crtc_state)) {
> > - u8 trans = new_crtc_state-
> > >sync_mode_slaves_mask |
> > - BIT(new_crtc_state-
> > >master_transcoder);
> > + u8 trans = new_crtc_state-
> > >sync_mode_slaves_mask;
> > +
> > + if (new_crtc_state->master_transcoder !=
> > INVALID_TRANSCODER)
> > + trans |= BIT(new_crtc_state-
> > >master_transcoder);
>
> Why not set master_transcoder in port sync master too? Would avoid have
> this check here and in future other places.
Not how the hardware works. So would complicate hw readout and
programming code needlessly.
>
> >
> > if (intel_cpu_transcoders_need_modeset(state,
> > trans)) {
> > new_crtc_state->uapi.mode_changed =
> > true;
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-23 18:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 0:24 [Intel-gfx] [PATCH 1/2] drm/i915/dp: Do not set master_trans bit in bitmak if INVALID_TRANSCODER Manasi Navare
2020-01-23 0:24 ` [Intel-gfx] [PATCH 2/2] drm/i915/dp: Modeset only the tiled connectors with CRTC Manasi Navare
2020-01-23 18:27 ` Ville Syrjälä
2020-01-23 22:47 ` Manasi Navare
2020-01-24 21:22 ` Manasi Navare
2020-01-23 4:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/dp: Do not set master_trans bit in bitmak if INVALID_TRANSCODER Patchwork
2020-01-23 5:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-01-23 14:01 ` [Intel-gfx] [PATCH 1/2] " Ville Syrjälä
2020-01-23 22:04 ` Manasi Navare
2020-01-23 18:25 ` Souza, Jose
2020-01-23 18:31 ` Ville Syrjälä [this message]
2020-01-23 18:39 ` Ville Syrjälä
2020-01-23 22:00 ` Manasi Navare
2020-01-24 1:13 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123183155.GW13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox