Re: [Intel-gfx] [PATCH 9/9] drm/todo: Update drm_fb_helper tasks

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Pankaj,

Thank you for the patch.

On Mon, Mar 02, 2020 at 06:26:49PM +0530, Pankaj Bharadiya wrote:
> Remove completed drm_fb_helper tasks from todo list.
> 
> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> ---
>  Documentation/gpu/todo.rst | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index ccf5e8e34222..98d8782e1440 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -362,17 +362,10 @@ Level: Starter
>  drm_fb_helper tasks
>  -------------------
>  
> -- drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode()
> -  not the _force variant so it can bail out if there is a master. But first
> -  these igt tests need to be fixed: kms_fbcon_fbt@psr and
> -  kms_fbcon_fbt@psr-suspend.
> -
> -- The max connector argument for drm_fb_helper_init() isn't used anymore and
> -  can be removed.
> -
> -- The helper doesn't keep an array of connectors anymore so these can be
> -  removed: drm_fb_helper_single_add_all_connectors(),
> -  drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector().
> +drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode()
> +not the _force variant so it can bail out if there is a master. But first
> +these igt tests need to be fixed: kms_fbcon_fbt@psr and
> +kms_fbcon_fbt@psr-suspend.

No need to reflow, you can keep the first list entry as-is and just
remove the next two. With this fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  Level: Intermediate
>  

-- 
Regards,

Laurent Pinchart
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx