From: Imre Deak <imre.deak@intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "Chiou, Cooper" <cooper.chiou@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"kai.heng.feng@canonical.com" <kai.heng.feng@canonical.com>
Subject: Re: [Intel-gfx] [PATCH v3 4/8] drm/i915/tc/icl: Implement TC cold sequences
Date: Wed, 8 Apr 2020 01:43:45 +0300 [thread overview]
Message-ID: <20200407224345.GF23597@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <b0f5944b4cddb06f3f7bba3b5a9d019eb1a8c7d4.camel@intel.com>
On Wed, Apr 08, 2020 at 01:20:02AM +0300, Souza, Jose wrote:
> [...]
> > > + drm_dbg_kms(&i915->drm, "TC cold block %s\n", ret ? "failed" :
> > > + "succeeded");
> >
> > You missed turning this to an error.
>
> Can we postpone this at least for ICL?
>
> The ICL machines in CI don't have the IFWI that have this PCODE
> command, so it is failing. I have asked to CI team do update but it
> is going to take a while. VLK-9040
Ah, yes it's ok. Please also add a FIXME: then.
--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-07 22:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 21:39 [Intel-gfx] [PATCH v3 1/8] drm/i915/display: Move out code to return the digital_port of the aux ch José Roberto de Souza
2020-04-07 21:39 ` [Intel-gfx] [PATCH v3 2/8] drm/i915/display: Add intel_legacy_aux_to_power_domain() José Roberto de Souza
2020-04-08 9:11 ` You-Sheng Yang
2020-04-07 21:39 ` [Intel-gfx] [PATCH v3 3/8] drm/i915/display: Split hsw_power_well_enable() into two José Roberto de Souza
2020-04-07 21:39 ` [Intel-gfx] [PATCH v3 4/8] drm/i915/tc/icl: Implement TC cold sequences José Roberto de Souza
2020-04-07 22:03 ` Imre Deak
2020-04-07 22:20 ` Souza, Jose
2020-04-07 22:43 ` Imre Deak [this message]
2020-04-07 21:39 ` [Intel-gfx] [PATCH v3 5/8] drm/i915/tc: Skip ref held check for TC legacy aux power wells José Roberto de Souza
2020-04-07 21:39 ` [Intel-gfx] [PATCH v3 6/8] drm/i915/tc/tgl: Implement TC cold sequences José Roberto de Souza
2020-04-07 22:12 ` Imre Deak
2020-04-07 21:39 ` [Intel-gfx] [PATCH v3 7/8] drm/i915/tc: Catch TC users accessing FIA registers without enable aux José Roberto de Souza
2020-04-07 21:40 ` [Intel-gfx] [PATCH v3 8/8] drm/i915/tc: Do not warn when aux power well of static TC ports timeout José Roberto de Souza
2020-04-07 22:31 ` Imre Deak
2020-04-07 21:58 ` [Intel-gfx] [PATCH v3 1/8] drm/i915/display: Move out code to return the digital_port of the aux ch Imre Deak
2020-04-07 22:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/8] " Patchwork
2020-04-07 22:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-08 8:01 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407224345.GF23597@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=cooper.chiou@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=kai.heng.feng@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox