Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: chris@chris-wilson.co.uk
Subject: [Intel-gfx] [PATCH 0/4] Steer multicast register workaround verification
Date: Thu, 30 Apr 2020 16:15:25 -0700	[thread overview]
Message-ID: <20200430231529.295556-1-matthew.d.roper@intel.com> (raw)

We're seeing some CI errors indicating that a workaround did not apply
properly on EHL/JSL.  The workaround in question is updating a multicast
register, the failures are only seen on specific CI machines, and the
failures only seem to happen on resets and such rather than on initial
driver load.  It seems likely that the culprit here is failure to steer
the multicast register readback on a SKU that has slice0 / subslice0
fused off.

This series makes a couple changes:
 * Workaround verification will explicitly steer MCR registers by
   calling read_subslice_reg rather than a regular read.
 * New multicast ranges are added for gen11 and gen12.  Sadly this
   information is still missing from the bspec (just like the updated
   forcewake tables).  The hardware guys have given us a spreadsheet
   with both the forcewake and the multicast information while they work
   on getting the spec properly updated, so that's where the new ranges
   come from.

In addition to MCR and forcewake, there's supposed to be some more bspec
updates coming soon that deal with steering (i.e., different MCR ranges
should actually be using different registers to steer rather than just
the 0xFDC register we're familiar with); I don't have the full details
on that yet, so those updates will have to wait until we actually have
an updated spec. 

References: https://gitlab.freedesktop.org/drm/intel/issues/1222

Matt Roper (4):
  drm/i915: Setup multicast register steering for all gen >= 10
  drm/i915: Steer multicast register readback in wa_verify
  drm/i915: Don't skip verification of MCR engine workarounds
  drm/i915: Add MCR ranges for gen11 and gen12

 drivers/gpu/drm/i915/gt/intel_engine.h        |   3 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  17 +-
 drivers/gpu/drm/i915/gt/intel_workarounds.c   | 146 ++++++++++++------
 .../gpu/drm/i915/gt/intel_workarounds_types.h |   2 +
 4 files changed, 110 insertions(+), 58 deletions(-)

-- 
2.24.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2020-04-30 23:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 23:15 Matt Roper [this message]
2020-04-30 23:15 ` [Intel-gfx] [PATCH 1/4] drm/i915: Setup multicast register steering for all gen >= 10 Matt Roper
2020-04-30 23:15 ` [Intel-gfx] [PATCH 2/4] drm/i915: Steer multicast register readback in wa_verify Matt Roper
2020-04-30 23:15 ` [Intel-gfx] [PATCH 3/4] drm/i915: Don't skip verification of MCR engine workarounds Matt Roper
2020-04-30 23:15 ` [Intel-gfx] [PATCH 4/4] drm/i915: Add MCR ranges for gen11 and gen12 Matt Roper
2020-05-01  0:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Steer multicast register workaround verification Patchwork
2020-05-01  0:21 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-05-01  8:01 ` [Intel-gfx] [PATCH 0/4] " Tvrtko Ursulin
2020-05-01 16:05   ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430231529.295556-1-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox