Re: [Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Manasi Navare <manasi.d.navare@intel.com>]

On Tue, Jun 09, 2020 at 09:41:40PM +0300, Imre Deak wrote:
> DSC is not supported on DP MST streams so just don't add this entry for
> MST connectors.
> 
> This also fixes an OOPS, caused by the encoder->digport cast, which is
> not valid for MST encoders.
> 
> v2:
> - Check encoder, which is unset for an MST connector, before it gets
>   enabled.
> v3:
> - Just don't add this debugfs file for MST connectors. (Ville)
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Yes now just not having this debugfs entry for MST connectors makes sense
once we support it on MST we can expose it the right way

Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Manasi

> ---
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 2b640d8ab9d2..28dd717e943a 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -2218,7 +2218,8 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
>  	}
>  
>  	if (INTEL_GEN(dev_priv) >= 10 &&
> -	    (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> +	    ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
> +	      !to_intel_connector(connector)->mst_port) ||
>  	     connector->connector_type == DRM_MODE_CONNECTOR_eDP))
>  		debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
>  				    connector, &i915_dsc_fec_support_fops);
> -- 
> 2.23.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx