* [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Implement WA 18011464164
@ 2020-07-01 1:06 José Roberto de Souza
2020-07-01 1:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/tgl: Implement WA 22010931296 José Roberto de Souza
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: José Roberto de Souza @ 2020-07-01 1:06 UTC (permalink / raw)
To: intel-gfx
This fix some possible corruptions.
v2:
Renamed SLICE_UNIT_LEVEL_CLOCK_GATING_CTL to
SLICE_UNIT_LEVEL_CLKGATE_CTL_94D8
BSpec: 52755
BSpec: 52890
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_pm.c | 8 +++++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 9d6536afc94b..76bc70d214b6 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -4174,6 +4174,9 @@ enum {
#define INF_UNIT_LEVEL_CLKGATE _MMIO(0x9560)
#define CGPSF_CLKGATE_DIS (1 << 3)
+#define SLICE_UNIT_LEVEL_CLKGATE_CTL_94D8 _MMIO(0x94D8)
+#define GS_UNIT_CLOCK_GATING_DIS REG_BIT(24)
+
/*
* Display engine regs
*/
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 2a32d6230795..80293e3e48ad 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7113,7 +7113,7 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv)
I915_WRITE(POWERGATE_ENABLE,
I915_READ(POWERGATE_ENABLE) | vd_pg_enable);
- /* Wa_1409825376:tgl (pre-prod)*/
+ /* Wa_1409825376:tgl (pre-prod) */
if (IS_TGL_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_A0))
I915_WRITE(GEN9_CLKGATE_DIS_3, I915_READ(GEN9_CLKGATE_DIS_3) |
TGL_VRH_GATING_DIS);
@@ -7121,6 +7121,12 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv)
/* Wa_14011059788:tgl */
intel_uncore_rmw(&dev_priv->uncore, GEN10_DFR_RATIO_EN_AND_CHICKEN,
0, DFR_DISABLE);
+
+ /* Wa_18011464164:tgl */
+ if (IS_TGL_REVID(dev_priv, TGL_REVID_B0, TGL_REVID_B0))
+ intel_uncore_rmw(&dev_priv->uncore,
+ SLICE_UNIT_LEVEL_CLKGATE_CTL_94D8, 0,
+ GS_UNIT_CLOCK_GATING_DIS);
}
static void cnp_init_clock_gating(struct drm_i915_private *dev_priv)
--
2.27.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Intel-gfx] [PATCH v2 2/2] drm/i915/tgl: Implement WA 22010931296 2020-07-01 1:06 [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Implement WA 18011464164 José Roberto de Souza @ 2020-07-01 1:06 ` José Roberto de Souza 2020-07-01 3:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/tgl: Implement WA 18011464164 Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: José Roberto de Souza @ 2020-07-01 1:06 UTC (permalink / raw) To: intel-gfx Fix another set of corruption issues. BSpec: 52758 BSpec: 52890 Signed-off-by: José Roberto de Souza <jose.souza@intel.com> --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c index 2da366821dda..c8bf09efd0dc 100644 --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c @@ -1677,6 +1677,10 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) * Wa_14010229206:tgl */ wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN12_DISABLE_TDL_PUSH); + + /* Wa_22010931296:tgl */ + wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2, + TDSUNIT_CLKGATE_DIS); } if (IS_GEN(i915, 11)) { diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 76bc70d214b6..df9426c39a7a 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -4169,6 +4169,7 @@ enum { #define UNSLICE_UNIT_LEVEL_CLKGATE2 _MMIO(0x94e4) #define VSUNIT_CLKGATE_DIS_TGL REG_BIT(19) +#define TDSUNIT_CLKGATE_DIS REG_BIT(11) #define PSDUNIT_CLKGATE_DIS REG_BIT(5) #define INF_UNIT_LEVEL_CLKGATE _MMIO(0x9560) -- 2.27.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/tgl: Implement WA 18011464164 2020-07-01 1:06 [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Implement WA 18011464164 José Roberto de Souza 2020-07-01 1:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/tgl: Implement WA 22010931296 José Roberto de Souza @ 2020-07-01 3:40 ` Patchwork 2020-07-01 10:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-07-01 11:57 ` [Intel-gfx] [PATCH v2 1/2] " Ville Syrjälä 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-07-01 3:40 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/2] drm/i915/tgl: Implement WA 18011464164 URL : https://patchwork.freedesktop.org/series/78965/ State : success == Summary == CI Bug Log - changes from CI_DRM_8680 -> Patchwork_18051 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/index.html Known issues ------------ Here are the changes found in Patchwork_18051 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html #### Possible fixes #### * igt@i915_module_load@reload: - {fi-tgl-dsi}: [DMESG-WARN][3] ([i915#1982]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/fi-tgl-dsi/igt@i915_module_load@reload.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/fi-tgl-dsi/igt@i915_module_load@reload.html * igt@i915_pm_backlight@basic-brightness: - fi-whl-u: [DMESG-WARN][5] ([i915#95]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/fi-whl-u/igt@i915_pm_backlight@basic-brightness.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/fi-whl-u/igt@i915_pm_backlight@basic-brightness.html * igt@kms_cursor_legacy@basic-flip-after-cursor-atomic: - fi-icl-u2: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8] +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html #### Warnings #### * igt@i915_pm_rpm@basic-pci-d3-state: - fi-kbl-guc: [FAIL][9] ([i915#138]) -> [SKIP][10] ([fdo#109271]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@kms_flip@basic-flip-vs-modeset@a-dp1: - fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#62] / [i915#92]) +4 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html * igt@kms_force_connector_basic@force-edid: - fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#138]: https://gitlab.freedesktop.org/drm/intel/issues/138 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (43 -> 36) ------------------------------ Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * Linux: CI_DRM_8680 -> Patchwork_18051 CI-20190529: 20190529 CI_DRM_8680: 62fec61ed93afa7efb507345bffc9121ca489271 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5718: af1ef32bfae90bcdbaf1b5d84c61ff4e04368505 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18051: 31a52be7f251c26b096eed75745f4605263a39ac @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 31a52be7f251 drm/i915/tgl: Implement WA 22010931296 c9810a34f602 drm/i915/tgl: Implement WA 18011464164 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915/tgl: Implement WA 18011464164 2020-07-01 1:06 [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Implement WA 18011464164 José Roberto de Souza 2020-07-01 1:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/tgl: Implement WA 22010931296 José Roberto de Souza 2020-07-01 3:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/tgl: Implement WA 18011464164 Patchwork @ 2020-07-01 10:06 ` Patchwork 2020-07-01 11:57 ` [Intel-gfx] [PATCH v2 1/2] " Ville Syrjälä 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-07-01 10:06 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/2] drm/i915/tgl: Implement WA 18011464164 URL : https://patchwork.freedesktop.org/series/78965/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8680_full -> Patchwork_18051_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_18051_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_18051_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_18051_full: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live@execlists: - shard-iclb: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-iclb3/igt@i915_selftest@live@execlists.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-iclb1/igt@i915_selftest@live@execlists.html Known issues ------------ Here are the changes found in Patchwork_18051_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@preservation-s3@rcs0: - shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +2 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@rcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@rcs0.html * igt@gem_exec_whisper@basic-contexts-forked: - shard-glk: [PASS][5] -> [DMESG-WARN][6] ([i915#118] / [i915#95]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-glk9/igt@gem_exec_whisper@basic-contexts-forked.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-glk4/igt@gem_exec_whisper@basic-contexts-forked.html * igt@i915_module_load@reload: - shard-tglb: [PASS][7] -> [DMESG-WARN][8] ([i915#402]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-tglb3/igt@i915_module_load@reload.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-tglb6/igt@i915_module_load@reload.html * igt@kms_color@pipe-c-ctm-0-25: - shard-skl: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +11 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl2/igt@kms_color@pipe-c-ctm-0-25.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl5/igt@kms_color@pipe-c-ctm-0-25.html * igt@kms_cursor_crc@pipe-b-cursor-64x64-random: - shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#1635] / [i915#95]) +15 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html - shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#93] / [i915#95]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-glk: [PASS][15] -> [FAIL][16] ([i915#72]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html * igt@kms_flip@2x-plain-flip-ts-check@ab-vga1-hdmi-a1: - shard-hsw: [PASS][17] -> [DMESG-WARN][18] ([i915#1982]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-hsw1/igt@kms_flip@2x-plain-flip-ts-check@ab-vga1-hdmi-a1.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-hsw6/igt@kms_flip@2x-plain-flip-ts-check@ab-vga1-hdmi-a1.html * igt@kms_flip@flip-vs-expired-vblank@c-edp1: - shard-skl: [PASS][19] -> [FAIL][20] ([i915#79]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1: - shard-hsw: [PASS][21] -> [INCOMPLETE][22] ([i915#2055]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-hsw7/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1: - shard-skl: [PASS][23] -> [FAIL][24] ([i915#1928]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt: - shard-apl: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite: - shard-tglb: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-tglb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-tglb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][29] -> [DMESG-FAIL][30] ([fdo#108145] / [i915#1982]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_prime@basic-crc@second-to-first: - shard-kbl: [PASS][31] -> [DMESG-FAIL][32] ([i915#95]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-kbl2/igt@kms_prime@basic-crc@second-to-first.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-kbl6/igt@kms_prime@basic-crc@second-to-first.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +2 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@kms_setmode@basic: - shard-glk: [PASS][35] -> [FAIL][36] ([i915#31]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-glk4/igt@kms_setmode@basic.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-glk7/igt@kms_setmode@basic.html * igt@perf@polling-parameterized: - shard-iclb: [PASS][37] -> [FAIL][38] ([i915#1542]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-iclb8/igt@perf@polling-parameterized.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-iclb1/igt@perf@polling-parameterized.html #### Possible fixes #### * igt@gem_exec_whisper@basic-contexts-priority-all: - shard-glk: [DMESG-WARN][39] ([i915#118] / [i915#95]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-glk7/igt@gem_exec_whisper@basic-contexts-priority-all.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-glk7/igt@gem_exec_whisper@basic-contexts-priority-all.html * igt@gen9_exec_parse@allowed-single: - shard-glk: [DMESG-WARN][41] ([i915#1436] / [i915#716]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-glk4/igt@gen9_exec_parse@allowed-single.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-glk5/igt@gen9_exec_parse@allowed-single.html * igt@i915_selftest@mock@requests: - shard-skl: [INCOMPLETE][43] ([i915#198] / [i915#2110]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl3/igt@i915_selftest@mock@requests.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl10/igt@i915_selftest@mock@requests.html * igt@kms_big_fb@x-tiled-64bpp-rotate-180: - shard-glk: [DMESG-FAIL][45] ([i915#118] / [i915#95]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-glk4/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-skl: [INCOMPLETE][47] ([i915#300]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled: - shard-glk: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-glk9/igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-glk5/igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1: - shard-skl: [FAIL][51] ([i915#79]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html * igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2: - shard-glk: [FAIL][53] ([i915#79]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-glk3/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html * igt@kms_flip@flip-vs-suspend@c-hdmi-a1: - shard-hsw: [INCOMPLETE][55] ([i915#2055]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-hsw4/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-hsw6/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html * igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1: - shard-kbl: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-kbl6/igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-kbl7/igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt: - shard-kbl: [DMESG-WARN][59] ([i915#93] / [i915#95]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-blt: - shard-tglb: [DMESG-WARN][61] ([i915#402]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-blt.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-blt.html * igt@kms_frontbuffer_tracking@psr-farfromfence: - shard-tglb: [DMESG-WARN][63] ([i915#1982]) -> [PASS][64] +2 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-tglb7/igt@kms_frontbuffer_tracking@psr-farfromfence.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-tglb8/igt@kms_frontbuffer_tracking@psr-farfromfence.html * igt@kms_hdr@bpc-switch: - shard-skl: [FAIL][65] ([i915#1188]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl5/igt@kms_hdr@bpc-switch.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl8/igt@kms_hdr@bpc-switch.html * igt@kms_plane@plane-panning-bottom-right-pipe-b-planes: - shard-skl: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68] +6 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl3/igt@kms_plane@plane-panning-bottom-right-pipe-b-planes.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl10/igt@kms_plane@plane-panning-bottom-right-pipe-b-planes.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [DMESG-FAIL][69] ([fdo#108145] / [i915#1982]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [FAIL][71] ([fdo#108145] / [i915#265]) -> [PASS][72] +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [SKIP][73] ([fdo#109441]) -> [PASS][74] +3 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-iclb7/igt@kms_psr@psr2_cursor_render.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-iclb2/igt@kms_psr@psr2_cursor_render.html * igt@kms_setmode@basic: - shard-kbl: [FAIL][75] ([i915#31]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-kbl7/igt@kms_setmode@basic.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-kbl6/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [DMESG-WARN][77] ([i915#180]) -> [PASS][78] +7 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_vblank@pipe-c-wait-idle: - shard-apl: [DMESG-WARN][79] ([i915#1982]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl7/igt@kms_vblank@pipe-c-wait-idle.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-apl6/igt@kms_vblank@pipe-c-wait-idle.html * igt@perf@blocking-parameterized: - shard-iclb: [FAIL][81] ([i915#1542]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-iclb6/igt@perf@blocking-parameterized.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-iclb5/igt@perf@blocking-parameterized.html - shard-tglb: [FAIL][83] ([i915#1542]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-tglb5/igt@perf@blocking-parameterized.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-tglb7/igt@perf@blocking-parameterized.html * igt@perf@invalid-oa-metric-set-id: - shard-apl: [DMESG-WARN][85] ([i915#1635] / [i915#95]) -> [PASS][86] +20 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl2/igt@perf@invalid-oa-metric-set-id.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-apl4/igt@perf@invalid-oa-metric-set-id.html * igt@perf_pmu@semaphore-busy@rcs0: - shard-kbl: [FAIL][87] ([i915#1820]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-kbl7/igt@perf_pmu@semaphore-busy@rcs0.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-kbl6/igt@perf_pmu@semaphore-busy@rcs0.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [FAIL][89] ([i915#1515]) -> [WARN][90] ([i915#1515]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-iclb3/igt@i915_pm_rc6_residency@rc6-idle.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-iclb3/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_content_protection@srm: - shard-kbl: [TIMEOUT][91] ([i915#1319] / [i915#2119]) -> [TIMEOUT][92] ([i915#1319] / [i915#1958] / [i915#2119]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-kbl2/igt@kms_content_protection@srm.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-kbl6/igt@kms_content_protection@srm.html * igt@kms_cursor_crc@pipe-d-cursor-512x512-random: - shard-apl: [SKIP][93] ([fdo#109271]) -> [SKIP][94] ([fdo#109271] / [i915#1635]) +10 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl3/igt@kms_cursor_crc@pipe-d-cursor-512x512-random.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-apl7/igt@kms_cursor_crc@pipe-d-cursor-512x512-random.html * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy: - shard-skl: [DMESG-FAIL][95] ([i915#1982]) -> [DMESG-WARN][96] ([i915#1982]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][97] ([fdo#109349]) -> [DMESG-WARN][98] ([i915#1226]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_frontbuffer_tracking@psr-1p-rte: - shard-apl: [SKIP][99] ([fdo#109271] / [i915#1635]) -> [SKIP][100] ([fdo#109271]) +5 similar issues [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl3/igt@kms_frontbuffer_tracking@psr-1p-rte.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-apl6/igt@kms_frontbuffer_tracking@psr-1p-rte.html * igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant: - shard-apl: [DMESG-FAIL][101] ([fdo#108145] / [i915#1635] / [i915#1982] / [i915#95]) -> [DMESG-FAIL][102] ([fdo#108145] / [i915#1635] / [i915#95]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html * igt@kms_vblank@pipe-a-query-idle-hang: - shard-apl: [DMESG-WARN][103] ([i915#1635] / [i915#95]) -> [DMESG-WARN][104] ([i915#1982]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl3/igt@kms_vblank@pipe-a-query-idle-hang.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-apl7/igt@kms_vblank@pipe-a-query-idle-hang.html * igt@runner@aborted: - shard-iclb: [FAIL][105] ([i915#2110]) -> ([FAIL][106], [FAIL][107]) ([i915#1580] / [i915#2110]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-iclb1/igt@runner@aborted.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-iclb1/igt@runner@aborted.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-iclb8/igt@runner@aborted.html - shard-apl: ([FAIL][108], [FAIL][109], [FAIL][110], [FAIL][111]) ([fdo#109271] / [i915#1610] / [i915#1635] / [i915#716]) -> ([FAIL][112], [FAIL][113]) ([fdo#109271] / [i915#1635] / [i915#716]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl4/igt@runner@aborted.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl3/igt@runner@aborted.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl6/igt@runner@aborted.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8680/shard-apl6/igt@runner@aborted.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-apl1/igt@runner@aborted.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/shard-apl7/igt@runner@aborted.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1515]: https://gitlab.freedesktop.org/drm/intel/issues/1515 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1820]: https://gitlab.freedesktop.org/drm/intel/issues/1820 [i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928 [i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055 [i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110 [i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (11 -> 11) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_8680 -> Patchwork_18051 CI-20190529: 20190529 CI_DRM_8680: 62fec61ed93afa7efb507345bffc9121ca489271 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5718: af1ef32bfae90bcdbaf1b5d84c61ff4e04368505 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18051: 31a52be7f251c26b096eed75745f4605263a39ac @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18051/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Implement WA 18011464164 2020-07-01 1:06 [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Implement WA 18011464164 José Roberto de Souza ` (2 preceding siblings ...) 2020-07-01 10:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2020-07-01 11:57 ` Ville Syrjälä 2020-07-01 11:59 ` Ville Syrjälä 3 siblings, 1 reply; 6+ messages in thread From: Ville Syrjälä @ 2020-07-01 11:57 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx On Tue, Jun 30, 2020 at 06:06:54PM -0700, José Roberto de Souza wrote: > This fix some possible corruptions. > > v2: > Renamed SLICE_UNIT_LEVEL_CLOCK_GATING_CTL to > SLICE_UNIT_LEVEL_CLKGATE_CTL_94D8 Spec people are getting creative with the naming :/ > > BSpec: 52755 > BSpec: 52890 > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/i915_reg.h | 3 +++ > drivers/gpu/drm/i915/intel_pm.c | 8 +++++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 9d6536afc94b..76bc70d214b6 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -4174,6 +4174,9 @@ enum { > #define INF_UNIT_LEVEL_CLKGATE _MMIO(0x9560) > #define CGPSF_CLKGATE_DIS (1 << 3) > > +#define SLICE_UNIT_LEVEL_CLKGATE_CTL_94D8 _MMIO(0x94D8) > +#define GS_UNIT_CLOCK_GATING_DIS REG_BIT(24) > + > /* > * Display engine regs > */ > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 2a32d6230795..80293e3e48ad 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -7113,7 +7113,7 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv) > I915_WRITE(POWERGATE_ENABLE, > I915_READ(POWERGATE_ENABLE) | vd_pg_enable); > > - /* Wa_1409825376:tgl (pre-prod)*/ > + /* Wa_1409825376:tgl (pre-prod) */ > if (IS_TGL_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_A0)) > I915_WRITE(GEN9_CLKGATE_DIS_3, I915_READ(GEN9_CLKGATE_DIS_3) | > TGL_VRH_GATING_DIS); > @@ -7121,6 +7121,12 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv) > /* Wa_14011059788:tgl */ > intel_uncore_rmw(&dev_priv->uncore, GEN10_DFR_RATIO_EN_AND_CHICKEN, > 0, DFR_DISABLE); > + > + /* Wa_18011464164:tgl */ > + if (IS_TGL_REVID(dev_priv, TGL_REVID_B0, TGL_REVID_B0)) > + intel_uncore_rmw(&dev_priv->uncore, > + SLICE_UNIT_LEVEL_CLKGATE_CTL_94D8, 0, > + GS_UNIT_CLOCK_GATING_DIS); Still looks like the wrong place for gt w/as though. > } > > static void cnp_init_clock_gating(struct drm_i915_private *dev_priv) > -- > 2.27.0 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Implement WA 18011464164 2020-07-01 11:57 ` [Intel-gfx] [PATCH v2 1/2] " Ville Syrjälä @ 2020-07-01 11:59 ` Ville Syrjälä 0 siblings, 0 replies; 6+ messages in thread From: Ville Syrjälä @ 2020-07-01 11:59 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx On Wed, Jul 01, 2020 at 02:57:22PM +0300, Ville Syrjälä wrote: > On Tue, Jun 30, 2020 at 06:06:54PM -0700, José Roberto de Souza wrote: > > This fix some possible corruptions. > > > > v2: > > Renamed SLICE_UNIT_LEVEL_CLOCK_GATING_CTL to > > SLICE_UNIT_LEVEL_CLKGATE_CTL_94D8 > > Spec people are getting creative with the naming :/ > > > > > BSpec: 52755 > > BSpec: 52890 > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > > --- > > drivers/gpu/drm/i915/i915_reg.h | 3 +++ > > drivers/gpu/drm/i915/intel_pm.c | 8 +++++++- > > 2 files changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > > index 9d6536afc94b..76bc70d214b6 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@ -4174,6 +4174,9 @@ enum { > > #define INF_UNIT_LEVEL_CLKGATE _MMIO(0x9560) > > #define CGPSF_CLKGATE_DIS (1 << 3) > > > > +#define SLICE_UNIT_LEVEL_CLKGATE_CTL_94D8 _MMIO(0x94D8) > > +#define GS_UNIT_CLOCK_GATING_DIS REG_BIT(24) > > + Oh, and that should probably live next to its cousin. > > /* > > * Display engine regs > > */ > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > index 2a32d6230795..80293e3e48ad 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -7113,7 +7113,7 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv) > > I915_WRITE(POWERGATE_ENABLE, > > I915_READ(POWERGATE_ENABLE) | vd_pg_enable); > > > > - /* Wa_1409825376:tgl (pre-prod)*/ > > + /* Wa_1409825376:tgl (pre-prod) */ > > if (IS_TGL_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_A0)) > > I915_WRITE(GEN9_CLKGATE_DIS_3, I915_READ(GEN9_CLKGATE_DIS_3) | > > TGL_VRH_GATING_DIS); > > @@ -7121,6 +7121,12 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv) > > /* Wa_14011059788:tgl */ > > intel_uncore_rmw(&dev_priv->uncore, GEN10_DFR_RATIO_EN_AND_CHICKEN, > > 0, DFR_DISABLE); > > + > > + /* Wa_18011464164:tgl */ > > + if (IS_TGL_REVID(dev_priv, TGL_REVID_B0, TGL_REVID_B0)) > > + intel_uncore_rmw(&dev_priv->uncore, > > + SLICE_UNIT_LEVEL_CLKGATE_CTL_94D8, 0, > > + GS_UNIT_CLOCK_GATING_DIS); > > Still looks like the wrong place for gt w/as though. > > > } > > > > static void cnp_init_clock_gating(struct drm_i915_private *dev_priv) > > -- > > 2.27.0 > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-01 11:59 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-07-01 1:06 [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Implement WA 18011464164 José Roberto de Souza 2020-07-01 1:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/tgl: Implement WA 22010931296 José Roberto de Souza 2020-07-01 3:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/tgl: Implement WA 18011464164 Patchwork 2020-07-01 10:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-07-01 11:57 ` [Intel-gfx] [PATCH v2 1/2] " Ville Syrjälä 2020-07-01 11:59 ` Ville Syrjälä
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox