From: Sam Ravnborg <sam@ravnborg.org>
To: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
Cc: intel-gfx@lists.freedesktop.org, edmund.j.dea@intel.com,
dri-devel@lists.freedesktop.org, daniel.vetter@intel.com
Subject: Re: [Intel-gfx] [PATCH v3] drm/kmb: Add support for KeemBay Display
Date: Sat, 18 Jul 2020 18:37:01 +0200 [thread overview]
Message-ID: <20200718163701.GA3010985@ravnborg.org> (raw)
In-Reply-To: <1595020551-30768-2-git-send-email-anitha.chrisanthus@intel.com>
Hi Anitha.
A few extra details.
> diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c
> new file mode 100644
> index 0000000..570d46e
> --- /dev/null
> +++ b/drivers/gpu/drm/kmb/kmb_crtc.c
> @@ -0,0 +1,219 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright © 2018-2020 Intel Corporation
> + */
> +
> +#include <linux/clk.h>
> +#include <linux/of_graph.h>
Not used, can be dropped. Gos for all includes except the one in
kmb_drv.c
> +#include <linux/platform_data/simplefb.h>
Not used, can be dropped. Goes for all include of this file.
> + /* disable vertical interrupt */
> + kmb_clr_bitmask_lcd(dev_p, LCD_INT_ENABLE,
> + LCD_INT_VERT_COMP);
> +}
> +
> +static const struct drm_crtc_funcs kmb_crtc_funcs = {
> + .destroy = kmb_crtc_cleanup,
> + .set_config = drm_atomic_helper_set_config,
From the description of set_config:
* Drivers implementing atomic modeset should use
* drm_atomic_helper_set_config() to implement this hook.
Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-18 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 21:15 [Intel-gfx] [PATCH v3] Add support for KeemBay DRM driver Anitha Chrisanthus
2020-07-17 21:15 ` [Intel-gfx] [PATCH v3] drm/kmb: Add support for KeemBay Display Anitha Chrisanthus
2020-07-18 13:08 ` Sam Ravnborg
2020-07-30 20:36 ` Chrisanthus, Anitha
2020-07-18 16:37 ` Sam Ravnborg [this message]
2020-07-17 21:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-07-17 22:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-17 23:37 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200718163701.GA3010985@ravnborg.org \
--to=sam@ravnborg.org \
--cc=anitha.chrisanthus@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox