Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend
@ 2020-07-17 12:04 Anshuman Gupta
  2020-07-17 12:25 ` Chris Wilson
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Anshuman Gupta @ 2020-07-17 12:04 UTC (permalink / raw)
  To: intel-gfx

While i915 device is in runtime suspend, DRM connector polling
causing device to wakeup from runtime suspend.
This harm overall cpu idle statistics, therefore
disabling polling while in runtime suspend.

Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 5fd5af4bc855..1229c72f19c9 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1595,6 +1595,8 @@ static int intel_runtime_suspend(struct device *kdev)
 
 	disable_rpm_wakeref_asserts(rpm);
 
+	drm_kms_helper_poll_disable(&dev_priv->drm);
+
 	/*
 	 * We are safe here against re-faults, since the fault handler takes
 	 * an RPM reference.
@@ -1699,6 +1701,8 @@ static int intel_runtime_resume(struct device *kdev)
 	 */
 	intel_gt_runtime_resume(&dev_priv->gt);
 
+	drm_kms_helper_poll_enable(&dev_priv->drm);
+
 	/*
 	 * On VLV/CHV display interrupts are part of the display
 	 * power well, so hpd is reinitialized from there. For
-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-07-21 16:46 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-17 12:04 [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend Anshuman Gupta
2020-07-17 12:25 ` Chris Wilson
2020-07-17 12:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-07-17 12:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-17 14:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-07-21 13:32 ` [Intel-gfx] [RFC] " Imre Deak
2020-07-21 16:34   ` Anshuman Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox