* [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend
@ 2020-07-17 12:04 Anshuman Gupta
2020-07-17 12:25 ` Chris Wilson
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Anshuman Gupta @ 2020-07-17 12:04 UTC (permalink / raw)
To: intel-gfx
While i915 device is in runtime suspend, DRM connector polling
causing device to wakeup from runtime suspend.
This harm overall cpu idle statistics, therefore
disabling polling while in runtime suspend.
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 5fd5af4bc855..1229c72f19c9 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1595,6 +1595,8 @@ static int intel_runtime_suspend(struct device *kdev)
disable_rpm_wakeref_asserts(rpm);
+ drm_kms_helper_poll_disable(&dev_priv->drm);
+
/*
* We are safe here against re-faults, since the fault handler takes
* an RPM reference.
@@ -1699,6 +1701,8 @@ static int intel_runtime_resume(struct device *kdev)
*/
intel_gt_runtime_resume(&dev_priv->gt);
+ drm_kms_helper_poll_enable(&dev_priv->drm);
+
/*
* On VLV/CHV display interrupts are part of the display
* power well, so hpd is reinitialized from there. For
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend 2020-07-17 12:04 [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend Anshuman Gupta @ 2020-07-17 12:25 ` Chris Wilson 2020-07-17 12:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork ` (3 subsequent siblings) 4 siblings, 0 replies; 7+ messages in thread From: Chris Wilson @ 2020-07-17 12:25 UTC (permalink / raw) To: Anshuman Gupta, intel-gfx Quoting Anshuman Gupta (2020-07-17 13:04:25) > While i915 device is in runtime suspend, DRM connector polling > causing device to wakeup from runtime suspend. > This harm overall cpu idle statistics, therefore > disabling polling while in runtime suspend. So what about the devices where there is no hotplug interrupt during runtime suspend? How should the device wake up when something is plugged in? As I recall the transition to polling is only meant to occur on those devices with no automatic wakeup. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Disable connector polling at runtime suspend 2020-07-17 12:04 [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend Anshuman Gupta 2020-07-17 12:25 ` Chris Wilson @ 2020-07-17 12:37 ` Patchwork 2020-07-17 12:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-07-17 12:37 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx == Series Details == Series: drm/i915: Disable connector polling at runtime suspend URL : https://patchwork.freedesktop.org/series/79593/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable connector polling at runtime suspend 2020-07-17 12:04 [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend Anshuman Gupta 2020-07-17 12:25 ` Chris Wilson 2020-07-17 12:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork @ 2020-07-17 12:58 ` Patchwork 2020-07-17 14:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-07-21 13:32 ` [Intel-gfx] [RFC] " Imre Deak 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-07-17 12:58 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 5622 bytes --] == Series Details == Series: drm/i915: Disable connector polling at runtime suspend URL : https://patchwork.freedesktop.org/series/79593/ State : success == Summary == CI Bug Log - changes from CI_DRM_8760 -> Patchwork_18202 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/index.html Known issues ------------ Here are the changes found in Patchwork_18202 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s0: - fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html * igt@i915_module_load@reload: - fi-tgl-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/fi-tgl-u2/igt@i915_module_load@reload.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/fi-tgl-u2/igt@i915_module_load@reload.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@kms_cursor_legacy@basic-flip-before-cursor-legacy: - fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html #### Possible fixes #### * igt@i915_selftest@live@gt_lrc: - fi-tgl-u2: [DMESG-FAIL][9] ([i915#1233]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/fi-tgl-u2/igt@i915_selftest@live@gt_lrc.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/fi-tgl-u2/igt@i915_selftest@live@gt_lrc.html * igt@kms_flip@basic-flip-vs-dpms@a-dsi1: - {fi-tgl-dsi}: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12] +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/fi-tgl-dsi/igt@kms_flip@basic-flip-vs-dpms@a-dsi1.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/fi-tgl-dsi/igt@kms_flip@basic-flip-vs-dpms@a-dsi1.html * igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1: - fi-icl-u2: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html * igt@vgem_basic@setversion: - fi-tgl-y: [DMESG-WARN][15] ([i915#402]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/fi-tgl-y/igt@vgem_basic@setversion.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/fi-tgl-y/igt@vgem_basic@setversion.html #### Warnings #### * igt@debugfs_test@read_all_entries: - fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92]) -> [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html * igt@kms_force_connector_basic@force-edid: - fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][20] ([i915#62] / [i915#92]) +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (45 -> 40) ------------------------------ Additional (1): fi-snb-2600 Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-whl-u fi-byt-clapper Build changes ------------- * Linux: CI_DRM_8760 -> Patchwork_18202 CI-20190529: 20190529 CI_DRM_8760: 6cd3f0d5b81362d933c87318fa0bc3badd9ab92d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5738: bc8b56fe177af34fbde7b96f1f66614a0014c6ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18202: de062fbd6187db00d5cf3e905fb90ec924ebab13 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == de062fbd6187 drm/i915: Disable connector polling at runtime suspend == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/index.html [-- Attachment #1.2: Type: text/html, Size: 7206 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Disable connector polling at runtime suspend 2020-07-17 12:04 [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend Anshuman Gupta ` (2 preceding siblings ...) 2020-07-17 12:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2020-07-17 14:24 ` Patchwork 2020-07-21 13:32 ` [Intel-gfx] [RFC] " Imre Deak 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-07-17 14:24 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 14382 bytes --] == Series Details == Series: drm/i915: Disable connector polling at runtime suspend URL : https://patchwork.freedesktop.org/series/79593/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8760_full -> Patchwork_18202_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_18202_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_18202_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_18202_full: ### IGT changes ### #### Possible regressions #### * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-skl: [PASS][1] -> [INCOMPLETE][2] +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html Known issues ------------ Here are the changes found in Patchwork_18202_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@close-race: - shard-skl: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) +8 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl4/igt@gem_busy@close-race.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl3/igt@gem_busy@close-race.html * igt@i915_module_load@reload: - shard-tglb: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-tglb3/igt@i915_module_load@reload.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-tglb5/igt@i915_module_load@reload.html * igt@kms_big_fb@x-tiled-64bpp-rotate-0: - shard-glk: [PASS][7] -> [DMESG-FAIL][8] ([i915#118] / [i915#95]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-glk9/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html * igt@kms_big_fb@x-tiled-8bpp-rotate-180: - shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#1635] / [i915#1982]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-apl2/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-apl1/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html * igt@kms_big_fb@yf-tiled-32bpp-rotate-270: - shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-kbl6/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-kbl7/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html * igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled: - shard-skl: [PASS][13] -> [FAIL][14] ([i915#177] / [i915#52] / [i915#54]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl4/igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl6/igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +4 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_hdr@bpc-switch: - shard-skl: [PASS][17] -> [FAIL][18] ([i915#1188]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl9/igt@kms_hdr@bpc-switch.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl8/igt@kms_hdr@bpc-switch.html * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: - shard-skl: [PASS][19] -> [FAIL][20] ([i915#53]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl4/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl6/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145] / [i915#265]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109642] / [fdo#111068]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-iclb8/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +2 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html * igt@perf@polling-small-buf: - shard-skl: [PASS][27] -> [FAIL][28] ([i915#1722]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl2/igt@perf@polling-small-buf.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl2/igt@perf@polling-small-buf.html #### Possible fixes #### * igt@gem_ctx_isolation@preservation-s3@vecs0: - shard-glk: [INCOMPLETE][29] -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-glk7/igt@gem_ctx_isolation@preservation-s3@vecs0.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-glk4/igt@gem_ctx_isolation@preservation-s3@vecs0.html * igt@gem_exec_balancer@bonded-early: - shard-iclb: [FAIL][31] ([i915#926]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-iclb2/igt@gem_exec_balancer@bonded-early.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-iclb5/igt@gem_exec_balancer@bonded-early.html * igt@gem_exec_reloc@basic-concurrent0: - shard-glk: [FAIL][33] ([i915#1930]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-glk3/igt@gem_exec_reloc@basic-concurrent0.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-glk5/igt@gem_exec_reloc@basic-concurrent0.html * igt@i915_module_load@reload: - shard-iclb: [DMESG-WARN][35] ([i915#1982]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-iclb5/igt@i915_module_load@reload.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-iclb5/igt@i915_module_load@reload.html * igt@i915_selftest@mock@requests: - shard-skl: [INCOMPLETE][37] ([i915#198] / [i915#2110]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl8/igt@i915_selftest@mock@requests.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl1/igt@i915_selftest@mock@requests.html * igt@kms_color@pipe-b-ctm-negative: - shard-skl: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40] +3 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl9/igt@kms_color@pipe-b-ctm-negative.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl8/igt@kms_color@pipe-b-ctm-negative.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [DMESG-WARN][41] ([i915#180]) -> [PASS][42] +3 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-skl: [INCOMPLETE][43] ([i915#300]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions: - shard-tglb: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46] +1 similar issue [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-tglb5/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-tglb2/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1: - shard-skl: [FAIL][47] ([i915#79]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html * igt@kms_flip@flip-vs-expired-vblank@b-dp1: - shard-apl: [FAIL][49] ([i915#1635] / [i915#79]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-apl7/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-apl3/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][51] ([fdo#108145] / [i915#265]) -> [PASS][52] +1 similar issue [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [SKIP][53] ([fdo#109441]) -> [PASS][54] +2 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_vblank@pipe-a-ts-continuation-dpms-rpm: - shard-tglb: [INCOMPLETE][55] -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-tglb3/igt@kms_vblank@pipe-a-ts-continuation-dpms-rpm.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-tglb1/igt@kms_vblank@pipe-a-ts-continuation-dpms-rpm.html * igt@perf_pmu@module-unload: - shard-apl: [DMESG-WARN][57] ([i915#1635] / [i915#1982]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-apl8/igt@perf_pmu@module-unload.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-apl6/igt@perf_pmu@module-unload.html #### Warnings #### * igt@runner@aborted: - shard-apl: ([FAIL][59], [FAIL][60]) ([i915#1610] / [i915#1635] / [i915#2110]) -> [FAIL][61] ([i915#1635] / [i915#2110]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-apl4/igt@runner@aborted.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8760/shard-apl4/igt@runner@aborted.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/shard-apl2/igt@runner@aborted.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722 [i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52 [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#926]: https://gitlab.freedesktop.org/drm/intel/issues/926 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_8760 -> Patchwork_18202 CI-20190529: 20190529 CI_DRM_8760: 6cd3f0d5b81362d933c87318fa0bc3badd9ab92d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5738: bc8b56fe177af34fbde7b96f1f66614a0014c6ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18202: de062fbd6187db00d5cf3e905fb90ec924ebab13 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18202/index.html [-- Attachment #1.2: Type: text/html, Size: 16851 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend 2020-07-17 12:04 [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend Anshuman Gupta ` (3 preceding siblings ...) 2020-07-17 14:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2020-07-21 13:32 ` Imre Deak 2020-07-21 16:34 ` Anshuman Gupta 4 siblings, 1 reply; 7+ messages in thread From: Imre Deak @ 2020-07-21 13:32 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx On Fri, Jul 17, 2020 at 05:34:25PM +0530, Anshuman Gupta wrote: > While i915 device is in runtime suspend, DRM connector polling > causing device to wakeup from runtime suspend. > This harm overall cpu idle statistics, therefore > disabling polling while in runtime suspend. Before disabling polling we would need to enable hotplug interrupts during the runtime suspended state. Also I haven't seen yet stats where polling (which has a 10 sec period) have a significant effect on idle residencies. > Cc: Imre Deak <imre.deak@intel.com> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > drivers/gpu/drm/i915/i915_drv.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 5fd5af4bc855..1229c72f19c9 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -1595,6 +1595,8 @@ static int intel_runtime_suspend(struct device *kdev) > > disable_rpm_wakeref_asserts(rpm); > > + drm_kms_helper_poll_disable(&dev_priv->drm); > + > /* > * We are safe here against re-faults, since the fault handler takes > * an RPM reference. > @@ -1699,6 +1701,8 @@ static int intel_runtime_resume(struct device *kdev) > */ > intel_gt_runtime_resume(&dev_priv->gt); > > + drm_kms_helper_poll_enable(&dev_priv->drm); > + > /* > * On VLV/CHV display interrupts are part of the display > * power well, so hpd is reinitialized from there. For > -- > 2.26.2 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend 2020-07-21 13:32 ` [Intel-gfx] [RFC] " Imre Deak @ 2020-07-21 16:34 ` Anshuman Gupta 0 siblings, 0 replies; 7+ messages in thread From: Anshuman Gupta @ 2020-07-21 16:34 UTC (permalink / raw) To: Imre Deak; +Cc: intel-gfx On 2020-07-21 at 16:32:17 +0300, Imre Deak wrote: > On Fri, Jul 17, 2020 at 05:34:25PM +0530, Anshuman Gupta wrote: > > While i915 device is in runtime suspend, DRM connector polling > > causing device to wakeup from runtime suspend. > > This harm overall cpu idle statistics, therefore > > disabling polling while in runtime suspend. > > Before disabling polling we would need to enable hotplug interrupts > during the runtime suspended state. Also I haven't seen yet stats where IMHO whilst it is deepest display C state, HOTPLUG interrupt will be disabled. > polling (which has a 10 sec period) have a significant effect on > idle residencies. IMHO it can still affect the runtime s0ix. Thanks, Anshuman Gupta. > > > Cc: Imre Deak <imre.deak@intel.com> > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > --- > > drivers/gpu/drm/i915/i915_drv.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > > index 5fd5af4bc855..1229c72f19c9 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -1595,6 +1595,8 @@ static int intel_runtime_suspend(struct device *kdev) > > > > disable_rpm_wakeref_asserts(rpm); > > > > + drm_kms_helper_poll_disable(&dev_priv->drm); > > + > > /* > > * We are safe here against re-faults, since the fault handler takes > > * an RPM reference. > > @@ -1699,6 +1701,8 @@ static int intel_runtime_resume(struct device *kdev) > > */ > > intel_gt_runtime_resume(&dev_priv->gt); > > > > + drm_kms_helper_poll_enable(&dev_priv->drm); > > + > > /* > > * On VLV/CHV display interrupts are part of the display > > * power well, so hpd is reinitialized from there. For > > -- > > 2.26.2 > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-21 16:46 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-07-17 12:04 [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend Anshuman Gupta 2020-07-17 12:25 ` Chris Wilson 2020-07-17 12:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork 2020-07-17 12:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-07-17 14:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-07-21 13:32 ` [Intel-gfx] [RFC] " Imre Deak 2020-07-21 16:34 ` Anshuman Gupta
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox